From: Jesper Dangaard Brouer <jbrouer@redhat.com>
To: Willy Tarreau <w@1wt.eu>, Jose Fernandez <me@jrfernandez.com>
Cc: brouer@redhat.com, "Toke Høiland-Jørgensen" <toke@redhat.com>,
"Zvi Effron" <zeffron@riotgames.com>,
Xdp <xdp-newbies@vger.kernel.org>
Subject: Re: Linux laptop with native XDP support
Date: Wed, 8 Sep 2021 11:38:17 +0200 [thread overview]
Message-ID: <9608a3e7-35e3-29bd-a414-1a73ffde26b9@redhat.com> (raw)
In-Reply-To: <20210908063807.GA14966@1wt.eu>
On 08/09/2021 08.38, Willy Tarreau wrote:
> On Tue, Sep 07, 2021 at 06:50:49PM -0700, Jose Fernandez wrote:
>>> Nope, no XDP support for WiFi. There was some exploratory discussion
>>> about that some years ago, but XDP has Ethernet as a pretty fundamental
>>> assumption so it's not an obvious fit to the Linux WiFi stack...
>>>
>>> -Toke
>>>
>>
>> I came to the realization about that a few hours after sending this
>> email. I found this link useful to identity which drivers support XDP:
>> https://elixir.bootlin.com/linux/latest/A/ident/bpf_prog_run_xdp
>>
>> I had my eyes on the latest gen "slim" Linux notebooks (Lenovo XC1,
>> Dell XPS), but these don't have built-in Ethernet anymore. So I'm back
>> to the drawing board. Thanks for the tip on ixgbe and Broadcom.
>
> Note that e1000e remains quite popular among notebooks (my last HP one
> and the two following thinkpads including the T480s I'm typing on have
> this), and there is common ancestry between e1000e and igb. When I
> implemented the NDIV framework (which basically does pretty similar
> things as XDP does in the drivers), I managed to implement e1000,
> e1000e, igb and ixgbe without too many difficulties. Maybe it could
> be a good opportunity for you to try to port XDP to e1000e using such
> a machine, by looking at the work from igb ?
The igb + igc drivers support native XDP, and I assume they must be in
some laptops.
You can deduce that hardware support / Intel marketing names via e.g.
the igb driver via looking at the pci_device_id table (igb_pci_tbl[1]):
[1]
https://elixir.bootlin.com/linux/v5.14/source/drivers/net/ethernet/intel/igb/igb_main.c#L63
I agree that it would be beneficial to add native XDP to e1000e.
AFAIK John Fastabend implemented XDP for e1000, but the patch had some
bug (report-ably for some old hardware) that we never identified. Thus,
the patch was dropped.
--Jesper
prev parent reply other threads:[~2021-09-08 9:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-05 23:28 Linux laptop with native XDP support Jose Fernandez
2021-09-07 18:50 ` Zvi Effron
2021-09-07 19:03 ` Toke Høiland-Jørgensen
2021-09-08 1:50 ` Jose Fernandez
2021-09-08 6:38 ` Willy Tarreau
2021-09-08 9:38 ` Jesper Dangaard Brouer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9608a3e7-35e3-29bd-a414-1a73ffde26b9@redhat.com \
--to=jbrouer@redhat.com \
--cc=brouer@redhat.com \
--cc=me@jrfernandez.com \
--cc=toke@redhat.com \
--cc=w@1wt.eu \
--cc=xdp-newbies@vger.kernel.org \
--cc=zeffron@riotgames.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).