From: Jonathan Corbet <corbet@lwn.net>
To: "Thomas Weißschuh" <linux@weissschuh.net>
Cc: workflows@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Christoph Hellwig" <hch@infradead.org>,
"Jani Nikula" <jani.nikula@intel.com>,
"Thomas Weißschuh" <linux@weissschuh.net>
Subject: Re: [PATCH v2] docs: submitting-patches: encourage direct notifications to commenters
Date: Tue, 10 Oct 2023 13:59:09 -0600 [thread overview]
Message-ID: <8734yi5jw2.fsf@meer.lwn.net> (raw)
In-Reply-To: <20231003-docs-cc-reviewer-v2-1-f93fb946e21e@weissschuh.net>
Thomas Weißschuh <linux@weissschuh.net> writes:
> Commenters may not receive new versions of patches via the lists.
> Without a directed notification to them they might miss those new
> versions.
>
> This is frustrating for the patch developers as they don't receive their
> earned Reviewed-by.
> It is also frustrating for the commenters, as they might think their
> review got ignored or they have to dig up new versions from the archive
> manually.
>
> So encourage patch submitters to make sure that all commenters get
> notified also when no Reviewed-by was issued yet.
>
> Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
> ---
> Changes in v2:
> - s/reviewer/commenter/ to avoid ambiguity (Christoph)
> - Link to v1: https://lore.kernel.org/r/20230927-docs-cc-reviewer-v1-1-2af46ceb2d3c@weissschuh.net
> ---
> Documentation/process/submitting-patches.rst | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/process/submitting-patches.rst b/Documentation/process/submitting-patches.rst
> index efac910e2659..3245b7b38b98 100644
> --- a/Documentation/process/submitting-patches.rst
> +++ b/Documentation/process/submitting-patches.rst
> @@ -327,6 +327,8 @@ politely and address the problems they have pointed out. When sending a next
> version, add a ``patch changelog`` to the cover letter or to individual patches
> explaining difference against previous submission (see
> :ref:`the_canonical_patch_format`).
> +Notify people that commented on your patch about new versions by adding them to
> +the patches CC list.
Applied, thanks.
jon
prev parent reply other threads:[~2023-10-10 19:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-03 6:30 [PATCH v2] docs: submitting-patches: encourage direct notifications to commenters Thomas Weißschuh
2023-10-04 14:40 ` Alexander Dahl
2023-10-05 8:50 ` Christoph Hellwig
2023-10-10 19:59 ` Jonathan Corbet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8734yi5jw2.fsf@meer.lwn.net \
--to=corbet@lwn.net \
--cc=hch@infradead.org \
--cc=jani.nikula@intel.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=workflows@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).