From: Randy Dunlap <rdunlap@infradead.org>
To: Lukas Bulwahn <lukas.bulwahn@gmail.com>,
Jonathan Corbet <corbet@lwn.net>,
workflows@vger.kernel.org, linux-doc@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] docs: submit-checklist: structure by category
Date: Wed, 28 Feb 2024 15:03:08 -0800 [thread overview]
Message-ID: <4bec9a50-e846-4507-9332-22bd7a05e7f2@infradead.org> (raw)
In-Reply-To: <20240226104653.54877-1-lukas.bulwahn@gmail.com>
Hi Lukas,
Sorry about the (my) delay.
On 2/26/24 02:46, Lukas Bulwahn wrote:
>
> Documentation/process/submit-checklist.rst | 157 +++++++++++----------
> 1 file changed, 84 insertions(+), 73 deletions(-)
>
> diff --git a/Documentation/process/submit-checklist.rst b/Documentation/process/submit-checklist.rst
> index b1bc2d37bd0a..7d8dba942fe8 100644
> --- a/Documentation/process/submit-checklist.rst
> +++ b/Documentation/process/submit-checklist.rst
> @@ -11,110 +11,121 @@ These are all above and beyond the documentation that is provided in
> and elsewhere regarding submitting Linux kernel patches.
>
>
> +*Review your code:*
These "headings" (?) shouldn't have ending ':'s IMO.
Maybe they should be real headings?
Otherwise the patch is a very good & welcome improvement, although as
Jon said, the file needs some TLC. (after this patch is applied)
Reviewed-by: Randy Dunlap <rdunlap@infradead.org>
Tested-by: Randy Dunlap <rdunlap@infradead.org>
Thanks.
--
#Randy
prev parent reply other threads:[~2024-02-28 23:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-26 10:46 [PATCH] docs: submit-checklist: structure by category Lukas Bulwahn
2024-02-26 12:48 ` Jani Nikula
2024-02-27 7:28 ` Lukas Bulwahn
2024-02-27 0:41 ` Randy Dunlap
2024-02-27 8:04 ` Lukas Bulwahn
2024-02-27 8:57 ` Geert Uytterhoeven
2024-02-27 11:03 ` Lukas Bulwahn
2024-02-27 11:24 ` Geert Uytterhoeven
2024-02-28 21:57 ` Jonathan Corbet
2024-02-28 23:03 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4bec9a50-e846-4507-9332-22bd7a05e7f2@infradead.org \
--to=rdunlap@infradead.org \
--cc=corbet@lwn.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=workflows@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).