Workflows Archive mirror
 help / color / mirror / Atom feed
From: Barry Song <21cnbao@gmail.com>
To: akpm@linux-foundation.org, linux-doc@vger.kernel.org
Cc: apw@canonical.com, broonie@kernel.org, chenhuacai@loongson.cn,
	chris@zankel.net, corbet@lwn.net, dwaipayanray1@gmail.com,
	herbert@gondor.apana.org.au, joe@perches.com,
	linux-kernel@vger.kernel.org, linux@roeck-us.net,
	lukas.bulwahn@gmail.com, mac.xxn@outlook.com,
	sfr@canb.auug.org.au, v-songbaohua@oppo.com,
	workflows@vger.kernel.org
Subject: [PATCH v4 0/2] codingstyle: avoid unused parameters for a function-like macro
Date: Thu, 28 Mar 2024 15:21:34 +1300	[thread overview]
Message-ID: <20240328022136.5789-1-21cnbao@gmail.com> (raw)

From: Barry Song <v-songbaohua@oppo.com>

-v4:
 * fix Xining's email address, s/ma.xxn@outlook.com/mac.xxn@outlook.com/g
 * fix some false positives of checkpatch.pl
 * downgrade from ERROR to WARN in checkpatch.pl

 Thanks for Joe's comments!

-v3:
 https://lore.kernel.org/all/20240322084937.66018-1-21cnbao@gmail.com/

A function-like macro could result in build warnings such as
"unused variable." This patchset updates the guidance to
recommend always using a static inline function instead
and also provides checkpatch support for this new rule.

Barry Song (1):
  Documentation: coding-style: ask function-like macros to evaluate
    parameters

Xining Xu (1):
  scripts: checkpatch: check unused parameters for function-like macro

 Documentation/process/coding-style.rst | 16 ++++++++++++++
 scripts/checkpatch.pl                  | 30 ++++++++++++++++++++++++++
 2 files changed, 46 insertions(+)

-- 
2.34.1


             reply	other threads:[~2024-03-28  2:21 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-28  2:21 Barry Song [this message]
2024-03-28  2:21 ` [PATCH v4 1/2] Documentation: coding-style: ask function-like macros to evaluate parameters Barry Song
2024-03-28  2:21 ` [PATCH v4 2/2] scripts: checkpatch: check unused parameters for function-like macro Barry Song
2024-03-28  9:57   ` Joe Perches
2024-03-31 13:43     ` Mac Xu
2024-03-31 13:46     ` Mac Xu
2024-03-31 15:54       ` Joe Perches
2024-03-31 23:21         ` Mac Xu
2024-03-28 16:01   ` Jeff Johnson
2024-03-28 21:24     ` Barry Song
2024-03-28  4:22 ` [PATCH v4 0/2] codingstyle: avoid unused parameters for a " Barry Song

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240328022136.5789-1-21cnbao@gmail.com \
    --to=21cnbao@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=apw@canonical.com \
    --cc=broonie@kernel.org \
    --cc=chenhuacai@loongson.cn \
    --cc=chris@zankel.net \
    --cc=corbet@lwn.net \
    --cc=dwaipayanray1@gmail.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=joe@perches.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=lukas.bulwahn@gmail.com \
    --cc=mac.xxn@outlook.com \
    --cc=sfr@canb.auug.org.au \
    --cc=v-songbaohua@oppo.com \
    --cc=workflows@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).