From: Nikolai Kondrashov <Nikolai.Kondrashov@redhat.com>
To: workflows@vger.kernel.org, Joe Perches <joe@perches.com>,
Andy Whitcroft <apw@canonical.com>, Theodore Ts'o <tytso@mit.edu>,
David Gow <davidgow@google.com>,
Steven Rostedt <rostedt@goodmis.org>,
Mark Brown <broonie@kernel.org>,
Shuah Khan <skhan@linuxfoundation.org>,
"Darrick J . Wong" <djwong@kernel.org>
Cc: kunit-dev@googlegroups.com, linux-kselftest@vger.kernel.org,
Veronika Kabatova <vkabatov@redhat.com>,
CKI <cki-project@redhat.com>,
kernelci@lists.linux.dev
Subject: [RFC PATCH 0/3] MAINTAINERS: Introduce V: field for required tests
Date: Wed, 15 Nov 2023 19:43:48 +0200 [thread overview]
Message-ID: <20231115175146.9848-1-Nikolai.Kondrashov@redhat.com> (raw)
The idea of this RFC is to introduce a way to catalogue and document any tests
that should be executed for changes to a subsystem, as well as to make
checkpatch.pl require a tag in commit messages certifying they were, plus
hopefully make it easier to discover and run them.
This is following a discussion Veronika Kabatova started with a few
(addressed) people at the LPC last year (IIRC), where there was a good deal of
interest for something like this.
Apart from implementing basic support (surely to be improved), two sample
changes are added on top, adding a few test suites (roughly) based on what the
maintainers described earlier. I'm definitely not qualified for describing
them adequately, and don't have the time to dig deeper, but hopefully they
could serve as illustrations, and shouldn't be merged as is.
I would defer to maintainers of the corresponding subsystems and tests to
describe their tests and requirements better. Although I would accept
amendments too, if they prefer it that way.
One bug I know that's definitely there is handling removed files. The
scripts/get_maintainer.pl chokes on non-existing files, failing to output the
required test suites (I'm sure there's a good reason, but I couldn't see it).
My first idea is to only check for required tests upon encountering the '+++
<file>' line, and ignore the '/dev/null' file, but I hope the checkpatch.pl
maintainers could recommend a better way.
Anyway, tell me what you think, and I'll work on polishing this.
Thank you!
Nick
---
Nikolai Kondrashov (3):
MAINTAINERS: Introduce V: field for required tests
MAINTAINERS: Require kvm-xfstests smoke for ext4
MAINTAINERS: Require kunit core tests for framework changes
Documentation/process/submitting-patches.rst | 19 +++++
Documentation/process/tests.rst | 80 ++++++++++++++++++
MAINTAINERS | 8 ++
scripts/checkpatch.pl | 118 ++++++++++++++++++++++++++-
scripts/get_maintainer.pl | 17 +++-
scripts/parse-maintainers.pl | 3 +-
6 files changed, 241 insertions(+), 4 deletions(-)
---
next reply other threads:[~2023-11-15 17:52 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-15 17:43 Nikolai Kondrashov [this message]
2023-11-15 17:43 ` [PATCH 1/3] MAINTAINERS: Introduce V: field for required tests Nikolai Kondrashov
2023-11-15 18:31 ` Joe Perches
2023-11-15 20:01 ` Mark Brown
2023-11-16 12:00 ` Nikolai Kondrashov
2023-11-15 20:14 ` Mark Brown
2023-11-16 12:09 ` Nikolai Kondrashov
2023-11-15 20:38 ` Konstantin Ryabitsev
2023-11-16 12:14 ` Nikolai Kondrashov
2023-11-16 13:26 ` Mark Brown
2023-11-16 13:52 ` Nikolai Kondrashov
2023-11-20 12:40 ` Gustavo Padovan
2023-11-20 13:31 ` Mark Brown
2023-11-22 17:41 ` Nikolai Kondrashov
2023-11-16 13:20 ` Bagas Sanjaya
2023-11-16 13:41 ` Nikolai Kondrashov
2023-11-16 13:43 ` Bagas Sanjaya
2023-11-16 13:59 ` Greg Kroah-Hartman
2023-11-16 14:21 ` Geert Uytterhoeven
2023-11-20 13:30 ` Ricardo Cañuelo
2023-11-20 20:51 ` Theodore Ts'o
2023-11-20 22:27 ` Mark Brown
2023-11-21 6:04 ` Theodore Ts'o
2023-11-21 10:37 ` David Gow
2023-11-21 13:27 ` Mark Brown
2023-11-22 16:16 ` Theodore Ts'o
2023-11-21 18:24 ` Nikolai Kondrashov
2023-11-21 18:02 ` Nikolai Kondrashov
2023-11-21 10:36 ` David Gow
2023-11-21 20:48 ` Mark Brown
2023-11-22 17:19 ` Nikolai Kondrashov
2023-11-22 1:08 ` kernel test robot
2023-11-15 17:43 ` [PATCH 2/3] MAINTAINERS: Require kvm-xfstests smoke for ext4 Nikolai Kondrashov
2023-11-15 18:58 ` Darrick J. Wong
2023-11-16 16:33 ` Nikolai Kondrashov
2023-11-17 7:09 ` Chandan Babu R
2023-11-19 22:54 ` Theodore Ts'o
2023-11-22 14:44 ` Nikolai Kondrashov
2023-11-22 16:17 ` Darrick J. Wong
2023-11-22 17:44 ` Nikolai Kondrashov
2023-11-22 20:51 ` Dave Chinner
2023-11-15 17:43 ` [PATCH 3/3] MAINTAINERS: Require kunit core tests for framework changes Nikolai Kondrashov
2023-11-20 18:48 ` Daniel Latypov
2023-11-22 17:38 ` Nikolai Kondrashov
2023-12-05 18:02 ` [RFC PATCH v2 00/10] MAINTAINERS: Introduce V: entry for tests Nikolai Kondrashov
2023-12-05 18:02 ` [RFC PATCH v2 01/10] get_maintainer: Survive querying missing files Nikolai Kondrashov
2023-12-05 18:55 ` Joe Perches
2023-12-06 16:16 ` Nikolai Kondrashov
2024-01-31 13:55 ` Nikolai Kondrashov
2023-12-05 18:02 ` [RFC PATCH v2 02/10] MAINTAINERS: Introduce V: entry for tests Nikolai Kondrashov
2023-12-05 18:58 ` Joe Perches
2023-12-06 16:21 ` Nikolai Kondrashov
2023-12-06 8:12 ` David Gow
2023-12-06 16:23 ` Nikolai Kondrashov
2023-12-06 16:38 ` Joe Perches
2023-12-06 16:57 ` Nikolai Kondrashov
2023-12-05 18:02 ` [RFC PATCH v2 03/10] MAINTAINERS: Propose kunit core tests for framework changes Nikolai Kondrashov
2023-12-05 18:03 ` [RFC PATCH v2 04/10] docs: submitting-patches: Introduce Tested-with: Nikolai Kondrashov
2023-12-05 18:59 ` Jonathan Corbet
2023-12-05 19:07 ` Joe Perches
2023-12-06 10:07 ` Geert Uytterhoeven
2023-12-06 16:46 ` Nikolai Kondrashov
2023-12-06 16:31 ` Nikolai Kondrashov
2023-12-05 18:03 ` [RFC PATCH v2 05/10] checkpatch: Propose tests to execute Nikolai Kondrashov
2023-12-05 18:03 ` [RFC PATCH v2 06/10] MAINTAINERS: Support referencing test docs in V: Nikolai Kondrashov
2023-12-06 8:03 ` David Gow
2023-12-06 16:54 ` Nikolai Kondrashov
2023-12-05 18:03 ` [RFC PATCH v2 07/10] MAINTAINERS: Propose kvm-xfstests smoke for ext4 Nikolai Kondrashov
2023-12-05 18:03 ` [RFC PATCH v2 08/10] docs: tests: Document kunit in general Nikolai Kondrashov
2023-12-05 18:03 ` [RFC PATCH v2 09/10] MAINTAINERS: Propose kunit tests for regmap Nikolai Kondrashov
2023-12-05 18:03 ` [RFC PATCH v2 10/10] MAINTAINERS: Add proposal strength to V: entries Nikolai Kondrashov
2024-01-08 10:42 ` [RFC PATCH v2 00/10] MAINTAINERS: Introduce V: entry for tests Nikolai Kondrashov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231115175146.9848-1-Nikolai.Kondrashov@redhat.com \
--to=nikolai.kondrashov@redhat.com \
--cc=apw@canonical.com \
--cc=broonie@kernel.org \
--cc=cki-project@redhat.com \
--cc=davidgow@google.com \
--cc=djwong@kernel.org \
--cc=joe@perches.com \
--cc=kernelci@lists.linux.dev \
--cc=kunit-dev@googlegroups.com \
--cc=linux-kselftest@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=skhan@linuxfoundation.org \
--cc=tytso@mit.edu \
--cc=vkabatov@redhat.com \
--cc=workflows@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).