From: Martin Habets <habetsm.xilinx@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, corbet@lwn.net, workflows@vger.kernel.org,
linux-doc@vger.kernel.org, rdunlap@infradead.org,
laurent.pinchart@ideasonboard.com, sd@queasysnail.net
Subject: Re: [PATCH net v4] docs: netdev: document patchwork patch states
Date: Mon, 4 Sep 2023 11:50:51 +0100 [thread overview]
Message-ID: <20230904105051.GB8198@gmail.com> (raw)
In-Reply-To: <20230901142406.586042-1-kuba@kernel.org>
On Fri, Sep 01, 2023 at 07:24:05AM -0700, Jakub Kicinski wrote:
> The patchwork states are largely self-explanatory but small
> ambiguities may still come up. Document how we interpret
> the states in networking.
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Reviewed-by: Martin Habets <habetsm.xilinx@gmail.com>
> ---
> v4:
> - clarify that patches once set to Awaiting Upstream will stay there
> v3: no change
> v2: https://lore.kernel.org/all/20230830220659.170911-1-kuba@kernel.org/
> - add a sentence about New vs Under Review
> - s/maintainer/export/ for Needs ACK
> - fix indent
> v1: https://lore.kernel.org/all/20230828184447.2142383-1-kuba@kernel.org/
>
> CC: corbet@lwn.net
> CC: workflows@vger.kernel.org
> CC: linux-doc@vger.kernel.org
>
> CC: rdunlap@infradead.org
> CC: laurent.pinchart@ideasonboard.com
> CC: sd@queasysnail.net
> ---
> Documentation/process/maintainer-netdev.rst | 32 ++++++++++++++++++++-
> 1 file changed, 31 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/process/maintainer-netdev.rst b/Documentation/process/maintainer-netdev.rst
> index c1c732e9748b..db1b81cfba9b 100644
> --- a/Documentation/process/maintainer-netdev.rst
> +++ b/Documentation/process/maintainer-netdev.rst
> @@ -120,7 +120,37 @@ Status of a patch can be checked by looking at the main patchwork
> https://patchwork.kernel.org/project/netdevbpf/list/
>
> The "State" field will tell you exactly where things are at with your
> -patch. Patches are indexed by the ``Message-ID`` header of the emails
> +patch:
> +
> +================== =============================================================
> +Patch state Description
> +================== =============================================================
> +New, Under review pending review, patch is in the maintainer’s queue for
> + review; the two states are used interchangeably (depending on
> + the exact co-maintainer handling patchwork at the time)
> +Accepted patch was applied to the appropriate networking tree, this is
> + usually set automatically by the pw-bot
> +Needs ACK waiting for an ack from an area expert or testing
> +Changes requested patch has not passed the review, new revision is expected
> + with appropriate code and commit message changes
> +Rejected patch has been rejected and new revision is not expected
> +Not applicable patch is expected to be applied outside of the networking
> + subsystem
> +Awaiting upstream patch should be reviewed and handled by appropriate
> + sub-maintainer, who will send it on to the networking trees;
> + patches set to ``Awaiting upstream`` in netdev's patchwork
> + will usually remain in this state, whether the sub-maintainer
> + requested changes, accepted or rejected the patch
> +Deferred patch needs to be reposted later, usually due to dependency
> + or because it was posted for a closed tree
> +Superseded new version of the patch was posted, usually set by the
> + pw-bot
> +RFC not to be applied, usually not in maintainer’s review queue,
> + pw-bot can automatically set patches to this state based
> + on subject tags
> +================== =============================================================
> +
> +Patches are indexed by the ``Message-ID`` header of the emails
> which carried them so if you have trouble finding your patch append
> the value of ``Message-ID`` to the URL above.
>
> --
> 2.41.0
>
prev parent reply other threads:[~2023-09-04 10:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-01 14:24 [PATCH net v4] docs: netdev: document patchwork patch states Jakub Kicinski
2023-09-04 8:48 ` patchwork-bot+netdevbpf
2023-09-04 10:50 ` Martin Habets [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230904105051.GB8198@gmail.com \
--to=habetsm.xilinx@gmail.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-doc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rdunlap@infradead.org \
--cc=sd@queasysnail.net \
--cc=workflows@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).