From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Xuan Zhuo <xuanzhuo@linux.alibaba.com>,
Jason Wang <jasowang@redhat.com>,
virtualization@lists.linux.dev, kernel@pengutronix.de
Subject: Re: [PATCH] virtio-mmio: Convert to platform remove callback returning void
Date: Fri, 12 Apr 2024 14:29:01 +0200 [thread overview]
Message-ID: <pweeconqpltug34tocjnk2i3sdqljvucwmndqprnlfusrle2lq@4rytnwrmjsnc> (raw)
In-Reply-To: <jsfldiklmu45j72rp7rqlpxfrgzjvpjmz664zsuvaetz4t2h5f@2hiy3huvrukc>
[-- Attachment #1: Type: text/plain, Size: 1642 bytes --]
On Fri, Mar 08, 2024 at 07:46:30PM +0100, Uwe Kleine-König wrote:
> Hello Michael,
>
> On Fri, Mar 08, 2024 at 12:18:26PM -0500, Michael S. Tsirkin wrote:
> > On Fri, Mar 08, 2024 at 09:51:20AM +0100, Uwe Kleine-König wrote:
> > > The .remove() callback for a platform driver returns an int which makes
> > > many driver authors wrongly assume it's possible to do error handling by
> > > returning an error code. However the value returned is ignored (apart
> > > from emitting a warning) and this typically results in resource leaks.
> > >
> > > To improve here there is a quest to make the remove callback return
> > > void. In the first step of this quest all drivers are converted to
> > > .remove_new(), which already returns void. Eventually after all drivers
> > > are converted, .remove_new() will be renamed to .remove().
> > >
> > > Trivially convert this driver from always returning zero in the remove
> > > callback to the void returning variant.
> > >
> > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> >
> > Acked-by: Michael S. Tsirkin <mst@redhat.com>
> >
> > do u want me to merge this?
>
> I have no merge plan, so if you take it, that would be great.
It seems you didn't merge it yet (at least the patch isn't in next). It
would be great if this patch made it in during the next merge window as
I intend to change struct platform_driver::remove in the merge window
leading to 6.11.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2024-04-12 12:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-08 8:51 [PATCH] virtio-mmio: Convert to platform remove callback returning void Uwe Kleine-König
2024-03-08 17:18 ` Michael S. Tsirkin
2024-03-08 18:46 ` Uwe Kleine-König
2024-04-12 12:29 ` Uwe Kleine-König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=pweeconqpltug34tocjnk2i3sdqljvucwmndqprnlfusrle2lq@4rytnwrmjsnc \
--to=u.kleine-koenig@pengutronix.de \
--cc=jasowang@redhat.com \
--cc=kernel@pengutronix.de \
--cc=mst@redhat.com \
--cc=virtualization@lists.linux.dev \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).