From: Heng Qi <hengqi@linux.alibaba.com>
To: Jiri Pirko <jiri@resnulli.us>
Cc: netdev@vger.kernel.org, virtualization@lists.linux.dev,
"Michael S. Tsirkin" <mst@redhat.com>,
Jason Wang <jasowang@redhat.com>,
Xuan Zhuo <xuanzhuo@linux.alibaba.com>,
Eric Dumazet <edumazet@google.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH net-next 1/2] virtio_net: virtnet_send_command supports command-specific-result
Date: Tue, 23 Apr 2024 19:03:08 +0800 [thread overview]
Message-ID: <cab1ae8d-00b8-40e3-a5a6-31f231966a7b@linux.alibaba.com> (raw)
In-Reply-To: <ZieK1lmc0czcEXWk@nanopsycho>
在 2024/4/23 下午6:17, Jiri Pirko 写道:
> Tue, Apr 23, 2024 at 10:42:25AM CEST, hengqi@linux.alibaba.com wrote:
>> From: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
>>
>> As the spec https://github.com/oasis-tcs/virtio-spec/commit/42f389989823039724f95bbbd243291ab0064f82
>>
>> The virtnet cvq supports to get result from the device.
> Is this a statement about current status, cause it sounds so. Could you
> make it clear by changing the patch subject and description to use
> imperative mood please. Command the codebase what to do.
Sure. Will add more text in v2.
>
> Thanks!
>
>> Signed-off-by: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
>> ---
>> drivers/net/virtio_net.c | 24 +++++++++++++++++-------
>> 1 file changed, 17 insertions(+), 7 deletions(-)
>>
>> diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
>> index 7176b956460b..3bc9b1e621db 100644
>> --- a/drivers/net/virtio_net.c
>> +++ b/drivers/net/virtio_net.c
>> @@ -2527,11 +2527,12 @@ static int virtnet_tx_resize(struct virtnet_info *vi,
>> * supported by the hypervisor, as indicated by feature bits, should
>> * never fail unless improperly formatted.
>> */
>> -static bool virtnet_send_command(struct virtnet_info *vi, u8 class, u8 cmd,
>> - struct scatterlist *out)
>> +static bool virtnet_send_command_reply(struct virtnet_info *vi, u8 class, u8 cmd,
>> + struct scatterlist *out,
>> + struct scatterlist *in)
>> {
>> - struct scatterlist *sgs[4], hdr, stat;
>> - unsigned out_num = 0, tmp;
>> + struct scatterlist *sgs[5], hdr, stat;
>> + u32 out_num = 0, tmp, in_num = 0;
>> int ret;
>>
>> /* Caller should know better */
>> @@ -2549,10 +2550,13 @@ static bool virtnet_send_command(struct virtnet_info *vi, u8 class, u8 cmd,
>>
>> /* Add return status. */
>> sg_init_one(&stat, &vi->ctrl->status, sizeof(vi->ctrl->status));
>> - sgs[out_num] = &stat;
>> + sgs[out_num + in_num++] = &stat;
>>
>> - BUG_ON(out_num + 1 > ARRAY_SIZE(sgs));
>> - ret = virtqueue_add_sgs(vi->cvq, sgs, out_num, 1, vi, GFP_ATOMIC);
>> + if (in)
>> + sgs[out_num + in_num++] = in;
>> +
>> + BUG_ON(out_num + in_num > ARRAY_SIZE(sgs));
>> + ret = virtqueue_add_sgs(vi->cvq, sgs, out_num, in_num, vi, GFP_ATOMIC);
>> if (ret < 0) {
>> dev_warn(&vi->vdev->dev,
>> "Failed to add sgs for command vq: %d\n.", ret);
>> @@ -2574,6 +2578,12 @@ static bool virtnet_send_command(struct virtnet_info *vi, u8 class, u8 cmd,
>> return vi->ctrl->status == VIRTIO_NET_OK;
>> }
>>
>> +static bool virtnet_send_command(struct virtnet_info *vi, u8 class, u8 cmd,
>> + struct scatterlist *out)
>> +{
>> + return virtnet_send_command_reply(vi, class, cmd, out, NULL);
>> +}
>> +
>> static int virtnet_set_mac_address(struct net_device *dev, void *p)
>> {
>> struct virtnet_info *vi = netdev_priv(dev);
>> --
>> 2.32.0.3.g01195cf9f
>>
>>
next prev parent reply other threads:[~2024-04-23 11:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-23 8:42 [PATCH net-next 0/2] virtio_net: support getting initial value of irq coalesce Heng Qi
2024-04-23 8:42 ` [PATCH net-next 1/2] virtio_net: virtnet_send_command supports command-specific-result Heng Qi
2024-04-23 10:17 ` Jiri Pirko
2024-04-23 11:03 ` Heng Qi [this message]
2024-04-23 8:42 ` [PATCH net-next 2/2] virtio_net: get init coalesce value when probe Heng Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cab1ae8d-00b8-40e3-a5a6-31f231966a7b@linux.alibaba.com \
--to=hengqi@linux.alibaba.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jasowang@redhat.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=virtualization@lists.linux.dev \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).