From: Andrea Righi <andrea.righi@canonical.com>
To: Ricardo Ribalda <ribalda@google.com>
Cc: Igor Mammedov <imammedo@redhat.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
virtualization@lists.linux.dev, stevensd@chromium.org
Subject: Re: ACPI timeouts when enabling KASAN
Date: Fri, 3 May 2024 10:41:38 +0200 [thread overview]
Message-ID: <ZjSjQh-deMr5IDM8@gpd> (raw)
In-Reply-To: <ZiAlMHdNVQo0zjqi@gpd>
On Wed, Apr 17, 2024 at 09:38:26PM +0200, Andrea Righi wrote:
> On Wed, Apr 17, 2024 at 06:12:10PM +0200, Ricardo Ribalda wrote:
> ...
> > > Doing the proper comparison (disabling kvm), adding '-cpu max' to the
> > > equation and measuring the boot time of multiple virtme-ng runs, gives
> > > me the following result (average of 10 runs):
> > >
> > > machine
> > > +----------------
> > > | default q35
> > > ---------+----------------
> > > cpu |default | 13s 11s
> > > |max | 15s 14s
> > >
> > > I've tried a couple of kernel configs and I get similar results.
> > >
> > > In the scope of virtme-ng (optimize boot time) I'd say that it'd makes
> > > sense to use '-machine q35' and default cpu settings when kvm is
> > > unavailable.
> > >
> > > Ricardo, do you see similar results?
> >
> > I see even more difference between q35 and default.
> > These are my kernel options:
> > https://gitlab.freedesktop.org/linux-media/media-ci/-/blob/main/test-virtme.sh?ref_type=heads#L27
>
> Ok, I'll run some tests with these options as well.
>
> > I see an issue to automatically set the machine and it is that we
> > would not be able to override it with something like:
> >
> > virtme-run .......... --qemu-opts -machine q35
>
> If I'm not wrong the last one should override the previous ones,
> so --qemu-opts should still win over the default.
>
> >
> > If this patch lands in qemu we might be able to ignore all these:
> > https://lore.kernel.org/qemu-devel/20240417135608.2613586-1-ribalda@chromium.org/T/#u
>
> Yep, this is much better, thanks for this fix. Let's keep the defaults
> for now in virtme-ng, I'll just add a note to the troubleshooting
> section.
I actually changed my mind and merged this in virtme-ng:
https://github.com/arighi/virtme-ng/pull/110
I did more tests and in terms of boot time using the q35 arch really
seems to systematically improve performance (I tested this across
multiple hardware and kernel configs).
It also seems to improve the CI run test (that is executed as a github
workflow, where kvm isn't available). As we can see here:
- default arch, run test 34s:
https://github.com/arighi/virtme-ng/actions/runs/8935862788/job/24545125258
- q35 arch, run test 28s:
https://github.com/arighi/virtme-ng/actions/runs/8936234891/job/24546173523
Ricardo's fix can help to mitigate the issue with ACPI, but for now I
think using q35 when kvm isn't available can help to speed up tests in
similar CI environments.
Thanks,
-Andrea
prev parent reply other threads:[~2024-05-03 8:41 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-12 21:43 ACPI timeouts when enabling KASAN Ricardo Ribalda
2024-04-13 5:56 ` Andrea Righi
2024-04-13 7:39 ` Ricardo Ribalda
2024-04-14 8:37 ` Michael S. Tsirkin
2024-04-15 12:51 ` Igor Mammedov
2024-04-15 12:55 ` Rafael J. Wysocki
2024-04-15 14:18 ` Ricardo Ribalda
2024-04-15 14:31 ` Rafael J. Wysocki
2024-04-15 14:49 ` Michael S. Tsirkin
2024-04-16 11:33 ` Igor Mammedov
2024-04-16 11:36 ` Ricardo Ribalda
2024-04-16 12:07 ` Andrea Righi
2024-04-17 12:13 ` Ricardo Ribalda
2024-04-17 12:52 ` Andrea Righi
2024-04-17 12:55 ` Igor Mammedov
2024-04-17 14:38 ` Andrea Righi
2024-04-17 16:12 ` Ricardo Ribalda
2024-04-17 19:38 ` Andrea Righi
2024-05-03 8:41 ` Andrea Righi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZjSjQh-deMr5IDM8@gpd \
--to=andrea.righi@canonical.com \
--cc=imammedo@redhat.com \
--cc=mst@redhat.com \
--cc=rafael@kernel.org \
--cc=ribalda@google.com \
--cc=stevensd@chromium.org \
--cc=virtualization@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).