From: Jiri Pirko <jiri@resnulli.us>
To: Benjamin Poirier <benjamin.poirier@gmail.com>
Cc: netdev@vger.kernel.org, kuba@kernel.org, pabeni@redhat.com,
davem@davemloft.net, edumazet@google.com, parav@nvidia.com,
mst@redhat.com, jasowang@redhat.com, xuanzhuo@linux.alibaba.com,
shuah@kernel.org, petrm@nvidia.com, liuhangbin@gmail.com,
vladimir.oltean@nxp.com, idosch@nvidia.com,
virtualization@lists.linux.dev
Subject: Re: [patch net-next v5 3/5] selftests: forwarding: add check_driver() helper
Date: Tue, 23 Apr 2024 12:59:05 +0200 [thread overview]
Message-ID: <ZieUeciv-0dmmPLQ@nanopsycho> (raw)
In-Reply-To: <ZiawyyOY-6radvXV@f4>
Mon, Apr 22, 2024 at 08:47:39PM CEST, benjamin.poirier@gmail.com wrote:
>On 2024-04-22 17:32 +0200, Jiri Pirko wrote:
>> From: Jiri Pirko <jiri@nvidia.com>
>>
>> Add a helper to be used to check if the netdevice is backed by specified
>> driver.
>>
>> Signed-off-by: Jiri Pirko <jiri@nvidia.com>
>> Reviewed-by: Petr Machata <petrm@nvidia.com>
>> ---
>> tools/testing/selftests/net/forwarding/lib.sh | 15 +++++++++++----
>> 1 file changed, 11 insertions(+), 4 deletions(-)
>>
>> diff --git a/tools/testing/selftests/net/forwarding/lib.sh b/tools/testing/selftests/net/forwarding/lib.sh
>> index 9d6802c6c023..00e089dd951d 100644
>> --- a/tools/testing/selftests/net/forwarding/lib.sh
>> +++ b/tools/testing/selftests/net/forwarding/lib.sh
>> @@ -278,10 +278,17 @@ check_port_mab_support()
>> fi
>> }
>>
>> -if [[ "$(id -u)" -ne 0 ]]; then
>> - echo "SKIP: need root privileges"
>> - exit $ksft_skip
>> -fi
>
>Why is the check being removed entirely? This change was not in v4 of
>this patch. Did it happen unintentionally when removing "selftests:
>forwarding: move initial root check to the beginning"?
Oh, a mistake.
I messed up the v5 submission, repost couple minutes ago but I missed
this comment. I will send v6 tomorrow.
Sorry!
>
>> +check_driver()
>> +{
>> + local dev=$1; shift
>> + local expected=$1; shift
>> + local driver_name=`driver_name_get $dev`
>> +
>> + if [[ $driver_name != $expected ]]; then
>> + echo "SKIP: expected driver $expected for $dev, got $driver_name instead"
>> + exit $ksft_skip
>> + fi
>> +}
>>
>> if [[ "$CHECK_TC" = "yes" ]]; then
>> check_tc_version
>> --
>> 2.44.0
>>
>>
next prev parent reply other threads:[~2024-04-23 10:59 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-18 16:08 [patch net-next v4 0/6] selftests: virtio_net: introduce initial testing infrastructure Jiri Pirko
2024-04-18 16:08 ` [patch net-next v4 1/6] virtio: add debugfs infrastructure to allow to debug virtio features Jiri Pirko
2024-04-19 23:52 ` kernel test robot
2024-04-18 16:08 ` [patch net-next v4 2/6] selftests: forwarding: move initial root check to the beginning Jiri Pirko
2024-04-18 16:56 ` Petr Machata
2024-04-18 18:48 ` Benjamin Poirier
2024-04-19 13:51 ` Jiri Pirko
2024-04-18 16:08 ` [patch net-next v4 3/6] selftests: forwarding: add ability to assemble NETIFS array by driver name Jiri Pirko
2024-04-18 16:58 ` Petr Machata
2024-04-18 16:08 ` [patch net-next v4 4/6] selftests: forwarding: add check_driver() helper Jiri Pirko
2024-04-18 16:08 ` [patch net-next v4 5/6] selftests: forwarding: add wait_for_dev() helper Jiri Pirko
2024-04-18 16:59 ` Petr Machata
2024-04-18 16:08 ` [patch net-next v4 6/6] selftests: virtio_net: add initial tests Jiri Pirko
2024-04-18 17:01 ` Petr Machata
2024-04-22 15:32 ` [patch net-next v5 0/5] selftests: virtio_net: introduce initial testing infrastructure Jiri Pirko
2024-04-22 15:32 ` [patch net-next v5 1/5] virtio: add debugfs infrastructure to allow to debug virtio features Jiri Pirko
2024-04-22 15:32 ` [patch net-next v5 2/5] selftests: forwarding: add ability to assemble NETIFS array by driver name Jiri Pirko
2024-04-22 15:32 ` [patch net-next v5 3/5] selftests: forwarding: add check_driver() helper Jiri Pirko
2024-04-22 18:47 ` Benjamin Poirier
2024-04-23 10:59 ` Jiri Pirko [this message]
2024-04-22 15:32 ` [patch net-next v5 4/5] selftests: forwarding: add wait_for_dev() helper Jiri Pirko
2024-04-22 15:33 ` [patch net-next v5 5/5] selftests: virtio_net: add initial tests Jiri Pirko
2024-04-22 21:04 ` [patch net-next v4 0/6] selftests: virtio_net: introduce initial testing infrastructure Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZieUeciv-0dmmPLQ@nanopsycho \
--to=jiri@resnulli.us \
--cc=benjamin.poirier@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=idosch@nvidia.com \
--cc=jasowang@redhat.com \
--cc=kuba@kernel.org \
--cc=liuhangbin@gmail.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=parav@nvidia.com \
--cc=petrm@nvidia.com \
--cc=shuah@kernel.org \
--cc=virtualization@lists.linux.dev \
--cc=vladimir.oltean@nxp.com \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).