From: Eric Dumazet <edumazet@google.com>
To: Daniel Jurgens <danielj@nvidia.com>
Cc: netdev@vger.kernel.org, mst@redhat.com, jasowang@redhat.com,
xuanzhuo@linux.alibaba.com, virtualization@lists.linux.dev,
davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
jiri@nvidia.com, Eric Dumazet <edumaset@google.com>
Subject: Re: [PATCH v3] virtio_net: Fix missed rtnl_unlock
Date: Wed, 15 May 2024 18:39:34 +0200 [thread overview]
Message-ID: <CANn89iJjMcZ74eCWqBdTferLtZ1AwyMSiGBkdqMNFMV2t0AREw@mail.gmail.com> (raw)
In-Reply-To: <20240515163125.569743-1-danielj@nvidia.com>
On Wed, May 15, 2024 at 6:32 PM Daniel Jurgens <danielj@nvidia.com> wrote:
>
> The rtnl_lock would stay locked if allocating promisc_allmulti failed.
> Also changed the allocation to GFP_KERNEL.
>
> Fixes: ff7c7d9f5261 ("virtio_net: Remove command data from control_buf")
> Reported-by: Eric Dumazet <edumaset@google.com>
> Link: https://lore.kernel.org/netdev/CANn89iLazVaUCvhPm6RPJJ0owra_oFnx7Fhc8d60gV-65ad3WQ@mail.gmail.com/
> Signed-off-by: Daniel Jurgens <danielj@nvidia.com>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Thanks !
next prev parent reply other threads:[~2024-05-15 16:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-15 16:31 [PATCH v3] virtio_net: Fix missed rtnl_unlock Daniel Jurgens
2024-05-15 16:35 ` Brett Creeley
2024-05-15 16:39 ` Eric Dumazet [this message]
2024-05-15 21:42 ` Michael S. Tsirkin
2024-05-15 22:17 ` Michael S. Tsirkin
2024-05-16 4:47 ` Jason Wang
2024-05-17 2:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANn89iJjMcZ74eCWqBdTferLtZ1AwyMSiGBkdqMNFMV2t0AREw@mail.gmail.com \
--to=edumazet@google.com \
--cc=danielj@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumaset@google.com \
--cc=jasowang@redhat.com \
--cc=jiri@nvidia.com \
--cc=kuba@kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=virtualization@lists.linux.dev \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).