From: Cindy Lu <lulu@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: jasowang@redhat.com, kvm@vger.kernel.org,
virtualization@lists.linux-foundation.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] Documentation: Add reconnect process for VDUSE
Date: Tue, 9 Apr 2024 20:55:23 +0800 [thread overview]
Message-ID: <CACLfguWC3LruVfLndc4vzpzOuomEz-+nHY0KENZ6iiXNB728eg@mail.gmail.com> (raw)
In-Reply-To: <20240408085008-mutt-send-email-mst@kernel.org>
On Mon, Apr 8, 2024 at 8:50 PM Michael S. Tsirkin <mst@redhat.com> wrote:
>
> On Mon, Apr 08, 2024 at 08:39:21PM +0800, Cindy Lu wrote:
> > On Mon, Apr 8, 2024 at 3:40 PM Michael S. Tsirkin <mst@redhat.com> wrote:
> > >
> > > On Thu, Apr 04, 2024 at 01:56:31PM +0800, Cindy Lu wrote:
> > > > Add a document explaining the reconnect process, including what the
> > > > Userspace App needs to do and how it works with the kernel.
> > > >
> > > > Signed-off-by: Cindy Lu <lulu@redhat.com>
> > > > ---
> > > > Documentation/userspace-api/vduse.rst | 41 +++++++++++++++++++++++++++
> > > > 1 file changed, 41 insertions(+)
> > > >
> > > > diff --git a/Documentation/userspace-api/vduse.rst b/Documentation/userspace-api/vduse.rst
> > > > index bdb880e01132..7faa83462e78 100644
> > > > --- a/Documentation/userspace-api/vduse.rst
> > > > +++ b/Documentation/userspace-api/vduse.rst
> > > > @@ -231,3 +231,44 @@ able to start the dataplane processing as follows:
> > > > after the used ring is filled.
> > > >
> > > > For more details on the uAPI, please see include/uapi/linux/vduse.h.
> > > > +
> > > > +HOW VDUSE devices reconnection works
> > > > +------------------------------------
> > > > +1. What is reconnection?
> > > > +
> > > > + When the userspace application loads, it should establish a connection
> > > > + to the vduse kernel device. Sometimes,the userspace application exists,
> > > > + and we want to support its restart and connect to the kernel device again
> > > > +
> > > > +2. How can I support reconnection in a userspace application?
> > > > +
> > > > +2.1 During initialization, the userspace application should first verify the
> > > > + existence of the device "/dev/vduse/vduse_name".
> > > > + If it doesn't exist, it means this is the first-time for connection. goto step 2.2
> > > > + If it exists, it means this is a reconnection, and we should goto step 2.3
> > > > +
> > > > +2.2 Create a new VDUSE instance with ioctl(VDUSE_CREATE_DEV) on
> > > > + /dev/vduse/control.
> > > > + When ioctl(VDUSE_CREATE_DEV) is called, kernel allocates memory for
> > > > + the reconnect information. The total memory size is PAGE_SIZE*vq_mumber.
> > >
> > > Confused. Where is that allocation, in code?
> > >
> > > Thanks!
> > >
> > this should allocated in function vduse_create_dev(),
>
> I mean, it's not allocated there ATM right? This is just doc patch
> to become part of a larger patchset?
>
Got it, thanks Michael I will send the whole patchset soon
thanks
Cindy
> > I will rewrite
> > this part to make it more clearer
> > will send a new version soon
> > Thanks
> > cindy
> >
> > > > +2.3 Check if the information is suitable for reconnect
> > > > + If this is reconnection :
> > > > + Before attempting to reconnect, The userspace application needs to use the
> > > > + ioctl(VDUSE_DEV_GET_CONFIG, VDUSE_DEV_GET_STATUS, VDUSE_DEV_GET_FEATURES...)
> > > > + to get the information from kernel.
> > > > + Please review the information and confirm if it is suitable to reconnect.
> > > > +
> > > > +2.4 Userspace application needs to mmap the memory to userspace
> > > > + The userspace application requires mapping one page for every vq. These pages
> > > > + should be used to save vq-related information during system running. Additionally,
> > > > + the application must define its own structure to store information for reconnection.
> > > > +
> > > > +2.5 Completed the initialization and running the application.
> > > > + While the application is running, it is important to store relevant information
> > > > + about reconnections in mapped pages. When calling the ioctl VDUSE_VQ_GET_INFO to
> > > > + get vq information, it's necessary to check whether it's a reconnection. If it is
> > > > + a reconnection, the vq-related information must be get from the mapped pages.
> > > > +
> > > > +2.6 When the Userspace application exits, it is necessary to unmap all the
> > > > + pages for reconnection
> > > > --
> > > > 2.43.0
> > >
>
prev parent reply other threads:[~2024-04-09 12:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-04 5:56 [PATCH v3] Documentation: Add reconnect process for VDUSE Cindy Lu
2024-04-08 7:39 ` Michael S. Tsirkin
2024-04-08 12:39 ` Cindy Lu
2024-04-08 12:50 ` Michael S. Tsirkin
2024-04-09 12:55 ` Cindy Lu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACLfguWC3LruVfLndc4vzpzOuomEz-+nHY0KENZ6iiXNB728eg@mail.gmail.com \
--to=lulu@redhat.com \
--cc=jasowang@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).