From: Luigi Leonardi <luigi.leonardi@outlook.com>
To: sgarzare@redhat.com
Cc: davem@davemloft.net, edumazet@google.com, jasowang@redhat.com,
kuba@kernel.org, kvm@vger.kernel.org, luigi.leonardi@outlook.com,
mst@redhat.com, netdev@vger.kernel.org, pabeni@redhat.com,
stefanha@redhat.com, virtualization@lists.linux.dev,
xuanzhuo@linux.alibaba.com
Subject: Re: [PATCH net-next 2/3] vsock/virtio: add SIOCOUTQ support for all virtio based transports
Date: Thu, 4 Apr 2024 18:14:12 +0200 [thread overview]
Message-ID: <AS2P194MB21702427C769FB68A13AF54B9A3C2@AS2P194MB2170.EURP194.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <3n325gojjzphouapo36aowmcgt3iqjrqrmckqjjqgqmhvjdz4x@4givlk4egii3>
Hi Stefano,
Thanks for the review.
>We incremented it only for VIRTIO_VSOCK_OP_RW, should we check the
>same here?
Checking for the length of the skbuf or checking for VIRTIO_VSOCK_OP_RW
AFAIK is equivalent. Since the only packet with payload is this one.
I'll add a comment in v2 to make it more clear.
>What about rename it in `consume`?
Sounds good!
Thanks,
Luigi
next prev parent reply other threads:[~2024-04-04 16:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240402150539.390269-1-luigi.leonardi@outlook.com>
2024-04-02 15:05 ` [PATCH net-next 1/3] vsock: add support for SIOCOUTQ ioctl for all vsock socket types Luigi Leonardi
2024-04-03 9:00 ` Stefano Garzarella
2024-04-02 15:05 ` [PATCH net-next 2/3] vsock/virtio: add SIOCOUTQ support for all virtio based transports Luigi Leonardi
2024-04-03 9:11 ` Stefano Garzarella
2024-04-04 16:14 ` Luigi Leonardi [this message]
2024-04-02 15:05 ` [PATCH net-next 3/3] test/vsock: add ioctl unsent bytes test Luigi Leonardi
2024-04-03 9:20 ` Stefano Garzarella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AS2P194MB21702427C769FB68A13AF54B9A3C2@AS2P194MB2170.EURP194.PROD.OUTLOOK.COM \
--to=luigi.leonardi@outlook.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jasowang@redhat.com \
--cc=kuba@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sgarzare@redhat.com \
--cc=stefanha@redhat.com \
--cc=virtualization@lists.linux.dev \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).