From: Daniel Jurgens <danielj@nvidia.com>
To: <netdev@vger.kernel.org>
Cc: <mst@redhat.com>, <jasowang@redhat.com>,
<xuanzhuo@linux.alibaba.com>, <virtualization@lists.linux.dev>,
<davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
<pabeni@redhat.com>, <jiri@nvidia.com>,
Daniel Jurgens <danielj@nvidia.com>
Subject: [PATCH net-next v5 0/6] Remove RTNL lock protection of CVQ
Date: Tue, 23 Apr 2024 06:57:40 +0300 [thread overview]
Message-ID: <20240423035746.699466-1-danielj@nvidia.com> (raw)
Currently the buffer used for control VQ commands is protected by the
RTNL lock. Previously this wasn't a major concern because the control VQ
was only used during device setup and user interaction. With the recent
addition of dynamic interrupt moderation the control VQ may be used
frequently during normal operation.
This series removes the RNTL lock dependency by introducing a mutex
to protect the control buffer and writing SGs to the control VQ.
v5:
- Changed cvq_lock to a mutex.
- Changed dim_lock to mutex, because it's held taking
the cvq_lock.
- Use spin/mutex_lock/unlock vs guard macros.
v4:
- Protect dim_enabled with same lock as well intr_coal.
- Rename intr_coal_lock to dim_lock.
- Remove some scoped_guard where the error path doesn't
have to be in the lock.
v3:
- Changed type of _offloads to __virtio16 to fix static
analysis warning.
- Moved a misplaced hunk to the correct patch.
v2:
- New patch to only process the provided queue in
virtnet_dim_work
- New patch to lock per queue rx coalescing structure.
Daniel Jurgens (6):
virtio_net: Store RSS setting in virtnet_info
virtio_net: Remove command data from control_buf
virtio_net: Add a lock for the command VQ.
virtio_net: Do DIM update for specified queue only
virtio_net: Add a lock for per queue RX coalesce
virtio_net: Remove rtnl lock protection of command buffers
drivers/net/virtio_net.c | 276 +++++++++++++++++++++++----------------
1 file changed, 163 insertions(+), 113 deletions(-)
--
2.34.1
next reply other threads:[~2024-04-23 3:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-23 3:57 Daniel Jurgens [this message]
2024-04-23 3:57 ` [PATCH net-next v5 1/6] virtio_net: Store RSS setting in virtnet_info Daniel Jurgens
2024-04-23 3:57 ` [PATCH net-next v5 2/6] virtio_net: Remove command data from control_buf Daniel Jurgens
2024-04-26 9:34 ` Paolo Abeni
2024-05-01 2:22 ` Heng Qi
2024-04-23 3:57 ` [PATCH net-next v5 3/6] virtio_net: Add a lock for the command VQ Daniel Jurgens
2024-04-26 9:38 ` Paolo Abeni
2024-04-23 3:57 ` [PATCH net-next v5 4/6] virtio_net: Do DIM update for specified queue only Daniel Jurgens
2024-04-23 3:57 ` [PATCH net-next v5 5/6] virtio_net: Add a lock for per queue RX coalesce Daniel Jurgens
2024-04-26 9:47 ` Paolo Abeni
2024-04-26 13:14 ` Dan Jurgens
2024-04-23 3:57 ` [PATCH net-next v5 6/6] virtio_net: Remove rtnl lock protection of command buffers Daniel Jurgens
2024-04-26 9:53 ` [PATCH net-next v5 0/6] Remove RTNL lock protection of CVQ Paolo Abeni
2024-04-26 13:16 ` Dan Jurgens
2024-04-26 10:08 ` Heng Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240423035746.699466-1-danielj@nvidia.com \
--to=danielj@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jasowang@redhat.com \
--cc=jiri@nvidia.com \
--cc=kuba@kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=virtualization@lists.linux.dev \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).