Virtualization Archive mirror
 help / color / mirror / Atom feed
From: flyingpenghao@gmail.com
To: jean-philippe@linaro.org
Cc: virtualization@lists.linux.dev, Peng Hao <flyingpeng@tencent.com>
Subject: [PATCH]  viommu: return error code for unknown probe type
Date: Mon, 15 Apr 2024 16:18:23 +0800	[thread overview]
Message-ID: <20240415081823.18847-1-flyingpeng@tencent.com> (raw)

From: Peng Hao <flyingpeng@tencent.com>

If the probe types processed by the loop are all unknown,
no error will be returned.

Signed-off-by: Peng Hao <flyingpeng@tencent.com>
---
 drivers/iommu/virtio-iommu.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/iommu/virtio-iommu.c b/drivers/iommu/virtio-iommu.c
index 04048f64a2c0..80352505b762 100644
--- a/drivers/iommu/virtio-iommu.c
+++ b/drivers/iommu/virtio-iommu.c
@@ -555,6 +555,7 @@ static int viommu_probe_endpoint(struct viommu_dev *viommu, struct device *dev)
 			break;
 		default:
 			dev_err(dev, "unknown viommu prop 0x%x\n", type);
+			ret = -EINVAL;
 		}
 
 		if (ret)
-- 
2.31.1


             reply	other threads:[~2024-04-15  8:18 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-15  8:18 flyingpenghao [this message]
2024-04-15 11:46 ` [PATCH] viommu: return error code for unknown probe type Jean-Philippe Brucker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240415081823.18847-1-flyingpeng@tencent.com \
    --to=flyingpenghao@gmail.com \
    --cc=flyingpeng@tencent.com \
    --cc=jean-philippe@linaro.org \
    --cc=virtualization@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).