From: Simon Horman <horms@kernel.org>
To: Heng Qi <hengqi@linux.alibaba.com>
Cc: Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, virtualization@lists.linux.dev,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Jason Wang <jasowang@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Ratheesh Kannoth <rkannoth@marvell.com>,
Alexander Lobakin <aleksander.lobakin@intel.com>,
Xuan Zhuo <xuanzhuo@linux.alibaba.com>
Subject: Re: [PATCH net-next v5 1/4] ethtool: provide customized dim profile management
Date: Thu, 11 Apr 2024 14:58:03 +0100 [thread overview]
Message-ID: <20240411135803.GM514426@kernel.org> (raw)
In-Reply-To: <a07d16d9-60cf-4263-abd5-a1adea0959ad@linux.alibaba.com>
On Wed, Apr 10, 2024 at 11:13:15AM +0800, Heng Qi wrote:
>
>
> 在 2024/4/10 上午9:44, Jakub Kicinski 写道:
> > On Tue, 9 Apr 2024 20:03:21 +0800 Heng Qi wrote:
> > > +/**
> > > + * coalesce_put_profile - fill reply with a nla nest with four child nla nests.
> > > + * @skb: socket buffer the message is stored in
> > > + * @attr_type: nest attr type ETHTOOL_A_COALESCE_*X_*QE_PROFILE
> > > + * @profile: data passed to userspace
> > > + * @supported_params: modifiable parameters supported by the driver
> > > + *
> > > + * Put a dim profile nest attribute. Refer to ETHTOOL_A_MODERATIONS_MODERATION.
> > unfortunately kdoc got more picky and it also wants us to document
> > return values now,
>
> Will add it.
>
> > you gotta add something like
> >
> > * Returns: true if ..
> >
> > actually this functions seems to return negative error codes as bool..
>
> This works, in its wrapper function its error will be passed.:)
Ok, but I think that in that case the function should return false on error.
...
next prev parent reply other threads:[~2024-04-11 13:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-09 12:03 [PATCH net-next v5 0/4] ethtool: provide the dim profile fine-tuning channel Heng Qi
2024-04-09 12:03 ` [PATCH net-next v5 1/4] ethtool: provide customized dim profile management Heng Qi
2024-04-10 1:44 ` Jakub Kicinski
2024-04-10 3:13 ` Heng Qi
2024-04-11 13:58 ` Simon Horman [this message]
2024-04-09 12:03 ` [PATCH net-next v5 2/4] linux/dim: move profiles from .c to .h file Heng Qi
2024-04-09 12:03 ` [PATCH net-next v5 3/4] virtio-net: refactor dim initialization/destruction Heng Qi
2024-04-09 12:03 ` [PATCH net-next v5 4/4] virtio-net: support dim profile fine-tuning Heng Qi
2024-04-10 1:40 ` Jakub Kicinski
2024-04-10 3:09 ` Heng Qi
2024-04-11 1:54 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240411135803.GM514426@kernel.org \
--to=horms@kernel.org \
--cc=aleksander.lobakin@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hengqi@linux.alibaba.com \
--cc=jasowang@redhat.com \
--cc=kuba@kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rkannoth@marvell.com \
--cc=virtualization@lists.linux.dev \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).