From: Heng Qi <hengqi@linux.alibaba.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org, "David S . Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@google.com>,
Jason Wang <jasowang@redhat.com>,
"Michael S . Tsirkin" <mst@redhat.com>,
Brett Creeley <bcreeley@amd.com>,
Ratheesh Kannoth <rkannoth@marvell.com>,
Alexander Lobakin <aleksander.lobakin@intel.com>,
Xuan Zhuo <xuanzhuo@linux.alibaba.com>,
Tal Gilboa <talgi@nvidia.com>, Jonathan Corbet <corbet@lwn.net>,
linux-doc@vger.kernel.org,
Maxime Chevallier <maxime.chevallier@bootlin.com>,
Jiri Pirko <jiri@resnulli.us>,
Paul Greenwalt <paul.greenwalt@intel.com>,
Ahmed Zaki <ahmed.zaki@intel.com>,
Vladimir Oltean <vladimir.oltean@nxp.com>,
Kory Maincent <kory.maincent@bootlin.com>,
Andrew Lunn <andrew@lunn.ch>,
justinstitt@google.com, Simon Horman <horms@kernel.org>,
virtualization@lists.linux.dev
Subject: Re: [PATCH net-next v12 0/4] ethtool: provide the dim profile fine-tuning channel
Date: Wed, 8 May 2024 23:53:29 +0800 [thread overview]
Message-ID: <1715183609.0604343-3-hengqi@linux.alibaba.com> (raw)
In-Reply-To: <20240507194707.7c868654@kernel.org>
On Tue, 7 May 2024 19:47:07 -0700, Jakub Kicinski <kuba@kernel.org> wrote:
> On Wed, 8 May 2024 10:12:35 +0800 Heng Qi wrote:
> > I would like to confirm if there are still comments on the current version,
> > since the current series and the just merged "Remove RTNL lock protection of
> > CVQ" conflict with a line of code with the fourth patch, if I can collect
> > other comments or ack/review tags, then release the new version seems better.
>
> Looking now!
>
> Please note that I merged a patch today which makes DIMLIB a tri-state
> config, meaning it can be a module now. So please double check that
> didn't break things, especially referring to dim symbols from the core
> code.
The transition from bool-state to tri-state has no impact on this series,
since functions in the DIM library used by external modules require
EXPORT_SYMBOL in both conditions.
Thanks.
next prev parent reply other threads:[~2024-05-08 15:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-04 6:44 [PATCH net-next v12 0/4] ethtool: provide the dim profile fine-tuning channel Heng Qi
2024-05-04 6:44 ` [PATCH net-next v12 1/4] linux/dim: move useful macros to .h file Heng Qi
2024-05-04 6:44 ` [PATCH net-next v12 2/4] ethtool: provide customized dim profile management Heng Qi
2024-05-08 2:57 ` Jakub Kicinski
2024-05-08 13:26 ` Heng Qi
2024-05-08 15:11 ` Jakub Kicinski
2024-05-08 15:52 ` Heng Qi
2024-05-04 6:44 ` [PATCH net-next v12 3/4] dim: add new interfaces for initialization and getting results Heng Qi
2024-05-04 6:44 ` [PATCH net-next v12 4/4] virtio-net: support dim profile fine-tuning Heng Qi
2024-05-08 2:12 ` [PATCH net-next v12 0/4] ethtool: provide the dim profile fine-tuning channel Heng Qi
2024-05-08 2:47 ` Jakub Kicinski
2024-05-08 15:53 ` Heng Qi [this message]
2024-05-08 3:01 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1715183609.0604343-3-hengqi@linux.alibaba.com \
--to=hengqi@linux.alibaba.com \
--cc=ahmed.zaki@intel.com \
--cc=aleksander.lobakin@intel.com \
--cc=andrew@lunn.ch \
--cc=bcreeley@amd.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jasowang@redhat.com \
--cc=jiri@resnulli.us \
--cc=justinstitt@google.com \
--cc=kory.maincent@bootlin.com \
--cc=kuba@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=maxime.chevallier@bootlin.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=paul.greenwalt@intel.com \
--cc=rkannoth@marvell.com \
--cc=talgi@nvidia.com \
--cc=virtualization@lists.linux.dev \
--cc=vladimir.oltean@nxp.com \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).