From: Stefan Hajnoczi <stefanha@redhat.com>
To: Juan Quintela <quintela@redhat.com>
Cc: Anton Kuchin <antonkuchin@yandex-team.ru>,
Stefan Hajnoczi <stefanha@gmail.com>,
qemu-devel@nongnu.org, virtio-fs@redhat.com,
Markus Armbruster <armbru@redhat.com>,
Eric Blake <eblake@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
yc-core@yandex-team.ru, "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Virtio-fs] [PATCH] vhost-user-fs: add capability to allow migration
Date: Thu, 16 Feb 2023 16:00:51 -0500 [thread overview]
Message-ID: <Y+6Zgy7JgABed+RO@fedora> (raw)
In-Reply-To: <87mt5ly03z.fsf@secure.mitica>
[-- Attachment #1: Type: text/plain, Size: 2659 bytes --]
On Fri, Feb 10, 2023 at 05:08:16PM +0100, Juan Quintela wrote:
> Anton Kuchin <antonkuchin@yandex-team.ru> wrote:
> > On 02/02/2023 11:59, Juan Quintela wrote:
> >> Anton Kuchin <antonkuchin@yandex-team.ru> wrote:
> >>> On 01/02/2023 16:26, Juan Quintela wrote:
> >>>> Anton Kuchin <antonkuchin@yandex-team.ru> wrote:
> >>>>> On 19/01/2023 18:02, Stefan Hajnoczi wrote:
> >>>>>> On Thu, 19 Jan 2023 at 10:29, Anton Kuchin <antonkuchin@yandex-team.ru> wrote:
> >>>>>>> On 19/01/2023 16:30, Stefan Hajnoczi wrote:
> >>>>>>>> On Thu, 19 Jan 2023 at 07:43, Anton Kuchin <antonkuchin@yandex-team.ru> wrote:
> >>>>>>>>> On 18/01/2023 17:52, Stefan Hajnoczi wrote:
> >>>>>>>>>> On Sun, 15 Jan 2023 at 12:21, Anton Kuchin <antonkuchin@yandex-team.ru> wrote:
> >>>> Once told that, I think that you are making your live harder in the
> >>>> future when you add the other migratable devices.
> >>>>
> >>>> static const VMStateDescription vuf_vmstate = {
> >>>> .name = "vhost-user-fs",
> >>>> .minimum_version_id = 0,
> >>>> .version_id = 0,
> >>>> .fields = (VMStateField[]) {
> >>>> VMSTATE_INT8(migration_type, struct VHostUserFS),
> >>>> VMSTATE_VIRTIO_DEVICE,
> >>>> VMSTATE_END_OF_LIST()
> >>>> },
> >>>> .pre_save = vhost_user_fs_pre_save,
> >>>> .subsections = (const VMStateDescription*[]) {
> >>>> &vmstate_vhost_user_fs_internal_sub,
> >>>> NULL
> >>>> }
> >>>> };
> >>>>
> >>>> And you are done.
> >>>>
> >>>> I will propose to use a property to set migration_type, but I didn't
> >>>> want to write the code right now.
> >
> > I have a little problem with implementation here and need an advice:
> >
> > Can we make this property adjustable at runtime after device was realized?
> > There is a statement in qemu wiki [1] that makes me think this is possible
> > but I couldn't find any code for it or example in other devices.
> >> "Properties are, by default, locked while the device is
> > realized. Exceptions
> >> can be made by the devices themselves in order to implement a way
> > for a user
> >> to interact with a device while it is realized."
> >
> > Or is your idea just to set this property once at construction and keep it
> > constant for device lifetime?
> >
> > [1] https://wiki.qemu.org/Features/QOM
>
> I have no clue here. Markus? Stefan?
Sorry for the late reply. Yes, QOM properties can be set after realize
(e.g. using the qom-set command).
The set() callback can return an error, so some properties are
implemented to refuse updates when ->realize is true.
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2023-02-16 21:00 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-15 17:09 [Virtio-fs] [PATCH] vhost-user-fs: add capability to allow migration Anton Kuchin
2023-01-18 15:52 ` Stefan Hajnoczi
2023-01-19 12:43 ` Anton Kuchin
2023-01-19 14:30 ` Stefan Hajnoczi
2023-01-19 15:29 ` Anton Kuchin
2023-01-19 16:02 ` Stefan Hajnoczi
2023-01-19 16:58 ` Anton Kuchin
2023-01-19 20:40 ` Stefan Hajnoczi
2023-02-01 14:26 ` Juan Quintela
2023-02-02 0:54 ` Anton Kuchin
2023-02-02 9:59 ` Juan Quintela
2023-02-10 14:09 ` Anton Kuchin
2023-02-10 16:08 ` Juan Quintela
2023-02-16 21:00 ` Stefan Hajnoczi [this message]
2023-01-19 12:51 ` Michael S. Tsirkin
2023-01-19 13:45 ` Anton Kuchin
2023-01-19 19:00 ` Dr. David Alan Gilbert
2023-01-19 20:47 ` Anton Kuchin
2023-01-20 13:58 ` Michael S. Tsirkin
2023-01-20 17:37 ` Anton Kuchin
2023-01-22 8:16 ` Michael S. Tsirkin
2023-01-22 12:36 ` Anton Kuchin
2023-01-22 14:46 ` Michael S. Tsirkin
2023-01-22 16:09 ` Anton Kuchin
2023-01-22 16:17 ` Michael S. Tsirkin
2023-01-23 14:09 ` Stefan Hajnoczi
2023-01-23 15:52 ` Anton Kuchin
2023-01-23 19:49 ` Stefan Hajnoczi
2023-01-23 21:00 ` Michael S. Tsirkin
2023-01-23 21:56 ` Stefan Hajnoczi
2023-01-23 18:27 ` Dr. David Alan Gilbert
2023-01-23 19:53 ` Stefan Hajnoczi
2023-01-24 1:46 ` Stefan Hajnoczi
2023-01-24 9:50 ` Dr. David Alan Gilbert
2023-01-24 12:48 ` Stefan Hajnoczi
2023-02-01 14:37 ` Juan Quintela
2023-01-25 19:46 ` Stefan Hajnoczi
2023-01-26 14:20 ` Anton Kuchin
2023-01-26 15:13 ` Stefan Hajnoczi
2023-01-26 15:21 ` Anton Kuchin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+6Zgy7JgABed+RO@fedora \
--to=stefanha@redhat.com \
--cc=antonkuchin@yandex-team.ru \
--cc=armbru@redhat.com \
--cc=dgilbert@redhat.com \
--cc=eblake@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=stefanha@gmail.com \
--cc=virtio-fs@redhat.com \
--cc=yc-core@yandex-team.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).