From: Stefan Hajnoczi <stefanha@gmail.com>
To: Vivek Goyal <vgoyal@redhat.com>
Cc: Stefan Hajnoczi <stefanha@redhat.com>,
Yusuke Okada <yokada.996@gmail.com>,
"open list:virtiofs" <virtio-fs@redhat.com>,
Yusuke Okada <okada.yusuke@jp.fujitsu.com>,
qemu-devel@nongnu.org, qemu-stable <qemu-stable@nongnu.org>
Subject: Re: [Virtio-fs] [PATCH] virtiofsd: use g_date_time_get_microsecond to get subsecond
Date: Tue, 27 Sep 2022 11:50:00 -0400 [thread overview]
Message-ID: <CAJSP0QXUWia+U1uLVVDxputRxEeYJqNapORts4R0UTUiXaL17w@mail.gmail.com> (raw)
In-Reply-To: <Yyn/UUVAHwV+bMP7@redhat.com>
On Tue, 20 Sept 2022 at 19:08, Vivek Goyal <vgoyal@redhat.com> wrote:
>
> On Wed, Aug 24, 2022 at 01:41:29PM -0400, Stefan Hajnoczi wrote:
> > On Thu, Aug 18, 2022 at 02:46:19PM -0400, Yusuke Okada wrote:
> > > From: Yusuke Okada <okada.yusuke@jp.fujitsu.com>
> > >
> > > The "%f" specifier in g_date_time_format() is only available in glib
> > > 2.65.2 or later. If combined with older glib, the function returns null
> > > and the timestamp displayed as "(null)".
> > >
> > > For backward compatibility, g_date_time_get_microsecond should be used
> > > to retrieve subsecond.
> > >
> > > In this patch the g_date_time_format() leaves subsecond field as "%06d"
> > > and let next snprintf to format with g_date_time_get_microsecond.
> > >
> > > Signed-off-by: Yusuke Okada <okada.yusuke@jp.fujitsu.com>
> > > ---
> > > tools/virtiofsd/passthrough_ll.c | 7 +++++--
> > > 1 file changed, 5 insertions(+), 2 deletions(-)
> >
> > Thanks, applied to my block tree for QEMU 7.2:
> > https://gitlab.com/stefanha/qemu/commits/block
>
> Hi Stefan,
>
> Wondering when do you plan to send it for merge. This seems like
> a simple fix. Not sure why it does not qualify as a fix for
> 7.1 instead.
The pull request with this patch was merged into qemu.git/master today.
Regarding 7.1, it needs to go through the -stable tree. I have CCed
qemu-stable so this patch can be picked up.
Thanks,
Stefan
next prev parent reply other threads:[~2022-09-27 15:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-18 18:46 [Virtio-fs] [PATCH] virtiofsd: use g_date_time_get_microsecond to get subsecond Yusuke Okada
2022-08-18 19:12 ` okada.yusuke
2022-08-24 11:05 ` Dr. David Alan Gilbert
2022-08-24 17:41 ` Stefan Hajnoczi
2022-09-20 17:58 ` Vivek Goyal
2022-09-27 15:50 ` Stefan Hajnoczi [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-08-18 17:46 Yusuke Okada
2022-08-19 1:47 ` liuyd.fnst
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJSP0QXUWia+U1uLVVDxputRxEeYJqNapORts4R0UTUiXaL17w@mail.gmail.com \
--to=stefanha@gmail.com \
--cc=okada.yusuke@jp.fujitsu.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=stefanha@redhat.com \
--cc=vgoyal@redhat.com \
--cc=virtio-fs@redhat.com \
--cc=yokada.996@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).