From: Markus Armbruster <armbru@redhat.com>
To: Greg Kurz <groug@kaod.org>
Cc: qemu-devel@nongnu.org, qemu_oss@crudebyte.com,
Alistair.Francis@wdc.com, bin.meng@windriver.com,
palmer@dabbelt.com, marcandre.lureau@redhat.com,
pbonzini@redhat.com, yuval.shaia.ml@gmail.com,
marcel.apfelbaum@gmail.com, mst@redhat.com, quintela@redhat.com,
dgilbert@redhat.com, pavel.dovgaluk@ispras.ru,
alex.bennee@linaro.org, peterx@redhat.com, david@redhat.com,
philmd@linaro.org, mrolnik@gmail.com, gaosong@loongson.cn,
yangxiaojuan@loongson.cn, aurelien@aurel32.net,
jiaxun.yang@flygoat.com, aleksandar.rikalo@syrmia.com,
berrange@redhat.com, thuth@redhat.com, lvivier@redhat.com,
suhang16@mails.ucas.ac.cn, chen.zhang@intel.com,
lizhijian@fujitsu.com, stefanha@redhat.com,
qemu-riscv@nongnu.org, qemu-ppc@nongnu.org, virtio-fs@redhat.com
Subject: Re: [Virtio-fs] [PATCH v2 1/2] cleanup: Tweak and re-run return_directly.cocci
Date: Thu, 24 Nov 2022 19:41:14 +0100 [thread overview]
Message-ID: <878rk019h1.fsf@pond.sub.org> (raw)
In-Reply-To: <20221124162403.7d45f4fb@bahia> (Greg Kurz's message of "Thu, 24 Nov 2022 16:24:03 +0100")
Greg Kurz <groug@kaod.org> writes:
> On Thu, 24 Nov 2022 16:15:11 +0100
> Greg Kurz <groug@kaod.org> wrote:
>
>> On Tue, 22 Nov 2022 14:49:16 +0100
>> Markus Armbruster <armbru@redhat.com> wrote:
>>
>> > Tweak the semantic patch to drop redundant parenthesis around the
>> > return expression.
>> >
>> > Coccinelle drops a comment in hw/rdma/vmw/pvrdma_cmd.c; restored
>> > manually.
>> >
>> > Coccinelle messes up vmdk_co_create(), not sure why. Change dropped,
>> > will be done manually in the next commit.
>> >
>> > Line breaks in target/avr/cpu.h and hw/rdma/vmw/pvrdma_cmd.c tidied up
>> > manually.
>> >
>> > Whitespace in tools/virtiofsd/fuse_lowlevel.c tidied up manually.
>> >
>> > checkpatch.pl complains "return of an errno should typically be -ve"
>> > two times for hw/9pfs/9p-synth.c. Preexisting, the patch merely makes
>> > it visible to checkpatch.pl.
>> >
>>
>> Hi Markus,
>>
>> Yeah these positive errno values have been sitting there since the
>> beginning. It was dead code until I hijacked the synth backend to
>> implement qtest for 9p. I didn't care much about the return value
>> of the two culprits at the time since both are passed to assert(!ret)
>> right away. For this reason, changing the sign should be easy :-)
>>
>> I see that checkpatch.pl considers this as an error. I'll post
>> a fix. I guess you'll need to rebase on this fix for your patches
>> to pass CI.
>>
>
> Or maybe I can fix the issues detected by coccinelle as well and
> you can just drop the 9p bits from this patch ?
Up to you!
>> Anyway, for 9p:
>>
>> Reviewed-by: Greg Kurz <groug@kaod.org>
Thanks!
next prev parent reply other threads:[~2022-11-24 18:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-22 13:49 [Virtio-fs] [PATCH v2 0/2] cleanup: Tweak and re-run return_directly.cocci Markus Armbruster
2022-11-22 13:49 ` [Virtio-fs] [PATCH v2 1/2] " Markus Armbruster
2022-11-22 15:10 ` Philippe Mathieu-Daudé
2022-11-24 14:24 ` Dr. David Alan Gilbert
2022-11-24 15:15 ` Greg Kurz
2022-11-24 15:24 ` Greg Kurz
2022-11-24 18:41 ` Markus Armbruster [this message]
2022-11-22 13:49 ` [Virtio-fs] [PATCH v2 2/2] block/vmdk: Simplify vmdk_co_create() to return directly Markus Armbruster
2022-11-22 13:52 ` Peter Maydell
2022-11-22 15:05 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878rk019h1.fsf@pond.sub.org \
--to=armbru@redhat.com \
--cc=Alistair.Francis@wdc.com \
--cc=aleksandar.rikalo@syrmia.com \
--cc=alex.bennee@linaro.org \
--cc=aurelien@aurel32.net \
--cc=berrange@redhat.com \
--cc=bin.meng@windriver.com \
--cc=chen.zhang@intel.com \
--cc=david@redhat.com \
--cc=dgilbert@redhat.com \
--cc=gaosong@loongson.cn \
--cc=groug@kaod.org \
--cc=jiaxun.yang@flygoat.com \
--cc=lizhijian@fujitsu.com \
--cc=lvivier@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mrolnik@gmail.com \
--cc=mst@redhat.com \
--cc=palmer@dabbelt.com \
--cc=pavel.dovgaluk@ispras.ru \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=qemu_oss@crudebyte.com \
--cc=quintela@redhat.com \
--cc=stefanha@redhat.com \
--cc=suhang16@mails.ucas.ac.cn \
--cc=thuth@redhat.com \
--cc=virtio-fs@redhat.com \
--cc=yangxiaojuan@loongson.cn \
--cc=yuval.shaia.ml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).