From: Marc Hartmayer <mhartmay@linux.ibm.com>
To: qemu-devel@nongnu.org
Cc: qemu-s390x <qemu-s390x@nongnu.org>,
virtio-fs@redhat.com,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Sven Schnelle <svens@linux.ibm.com>,
Stefan Liebler <stli@linux.ibm.com>
Subject: [Virtio-fs] [PATCH] virtiofsd: Add `sigreturn` to the seccomp whitelist
Date: Fri, 25 Nov 2022 15:39:46 +0100 [thread overview]
Message-ID: <20221125143946.27717-1-mhartmay@linux.ibm.com> (raw)
The virtiofsd currently crashes on s390x. This is because of a
`sigreturn` system call. See audit log below:
type=SECCOMP msg=audit(1669382477.611:459): auid=4294967295 uid=0 gid=0 ses=4294967295 subj=system_u:system_r:virtd_t:s0-s0:c0.c1023 pid=6649 comm="virtiofsd" exe="/usr/libexec/virtiofsd" sig=31 arch=80000016 syscall=119 compat=0 ip=0x3fff15f748a code=0x80000000AUID="unset" UID="root" GID="root" ARCH=s390x SYSCALL=sigreturn
Signed-off-by: Marc Hartmayer <mhartmay@linux.ibm.com>
---
tools/virtiofsd/passthrough_seccomp.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/virtiofsd/passthrough_seccomp.c b/tools/virtiofsd/passthrough_seccomp.c
index 888295c073de..0033dab4939e 100644
--- a/tools/virtiofsd/passthrough_seccomp.c
+++ b/tools/virtiofsd/passthrough_seccomp.c
@@ -110,6 +110,7 @@ static const int syscall_allowlist[] = {
#endif
SCMP_SYS(set_robust_list),
SCMP_SYS(setxattr),
+ SCMP_SYS(sigreturn),
SCMP_SYS(symlinkat),
SCMP_SYS(syncfs),
SCMP_SYS(time), /* Rarely needed, except on static builds */
--
2.34.1
next reply other threads:[~2022-11-25 14:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-25 14:39 Marc Hartmayer [this message]
2022-11-25 16:32 ` [Virtio-fs] [PATCH] virtiofsd: Add `sigreturn` to the seccomp whitelist German Maglione
2022-11-28 6:18 ` Christian Borntraeger
2022-11-28 9:00 ` Marc Hartmayer
2022-11-28 10:17 ` German Maglione
2022-12-01 9:44 ` Marc Hartmayer
2022-11-25 20:50 ` Stefan Hajnoczi
2022-11-28 18:47 ` Dr. David Alan Gilbert
2022-11-29 9:38 ` Marc Hartmayer
2022-11-29 9:42 ` Dr. David Alan Gilbert
2022-11-29 9:52 ` Christian Borntraeger
2022-11-29 9:57 ` Christian Borntraeger
2022-11-29 10:16 ` Dr. David Alan Gilbert
2022-11-29 12:04 ` Stefan Hajnoczi
2022-11-29 10:16 ` Marc Hartmayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221125143946.27717-1-mhartmay@linux.ibm.com \
--to=mhartmay@linux.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=dgilbert@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=stefanha@redhat.com \
--cc=stli@linux.ibm.com \
--cc=svens@linux.ibm.com \
--cc=virtio-fs@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).