From: "Michael S. Tsirkin" <mst@redhat.com>
To: virtio-comment@lists.oasis-open.org, virtio-dev@lists.oasis-open.org
Cc: virtio@lists.oasis-open.org
Subject: [virtio-dev] [PATCH] virtio-net: clarify error handling for coalescing
Date: Wed, 24 Jan 2024 06:15:55 -0500 [thread overview]
Message-ID: <ff9a6d805e7d510cde77b9989bef90aa21ffe4b4.1706094950.git.mst@redhat.com> (raw)
This is not a huge deal since it's a SHOULD anyway,
so make the new requirement SHOULD too.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
device-types/net/description.tex | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/device-types/net/description.tex b/device-types/net/description.tex
index aff5e08..d1d25fe 100644
--- a/device-types/net/description.tex
+++ b/device-types/net/description.tex
@@ -1792,7 +1792,11 @@ \subsubsection{Control Virtqueue}\label{sec:Device Types / Network Device / Devi
The device MUST ignore \field{reserved}.
-The device SHOULD respond to VIRTIO_NET_CTRL_NOTF_COAL_TX_SET and VIRTIO_NET_CTRL_NOTF_COAL_RX_SET commands with VIRTIO_NET_ERR if it was not able to change the parameters.
+The device SHOULD respond to VIRTIO_NET_CTRL_NOTF_COAL_TX_SET and
+VIRTIO_NET_CTRL_NOTF_COAL_RX_SET commands with VIRTIO_NET_ERR if
+it was not able to change coalescing parameters. In this case,
+the parameters SHOULD remain unchanged, for all VQs.
+
The device MUST respond to the VIRTIO_NET_CTRL_NOTF_COAL_VQ_SET command with VIRTIO_NET_ERR if it was not able to change the parameters.
--
MST
---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
next reply other threads:[~2024-01-24 11:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-24 11:15 Michael S. Tsirkin [this message]
2024-01-24 11:23 ` [virtio-dev] RE: [virtio] [PATCH] virtio-net: clarify error handling for coalescing Parav Pandit
2024-01-26 8:01 ` [virtio-dev] " Michael S. Tsirkin
2024-01-24 11:28 ` [virtio-dev] Re: [virtio-comment] " Heng Qi
2024-01-29 15:06 ` [virtio-dev] Re: [virtio] " Cornelia Huck
2024-01-29 16:26 ` Michael S. Tsirkin
2024-01-29 16:55 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ff9a6d805e7d510cde77b9989bef90aa21ffe4b4.1706094950.git.mst@redhat.com \
--to=mst@redhat.com \
--cc=virtio-comment@lists.oasis-open.org \
--cc=virtio-dev@lists.oasis-open.org \
--cc=virtio@lists.oasis-open.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).