From: Haixu Cui <quic_haixcui@quicinc.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: <virtio-dev@lists.oasis-open.org>,
<virtio-comment@lists.oasis-open.org>, <cohuck@redhat.com>,
<harald.mommer@opensynergy.com>, <broonie@kernel.org>,
<qiang4.zhang@linux.intel.com>, <quic_ztu@quicinc.com>
Subject: Re: [virtio-dev][PATCH V7 2/2] virtio-spi: add the device specification
Date: Mon, 4 Dec 2023 10:30:05 +0800 [thread overview]
Message-ID: <daee943c-1dfa-4c9a-85cf-8170ffbc1956@quicinc.com> (raw)
In-Reply-To: <20231201083753.uw7i2rwymak4etnj@vireshk-i7>
Hi Viresh,
On 12/1/2023 4:37 PM, Viresh Kumar wrote:
> On 01-12-23, 16:21, Haixu Cui wrote:
>> The Virtio SPI (Serial Peripheral Interface) device is a virtual
>> SPI controller that allows the driver to operate and use the SPI
>> controller under the control of the device.
>>
>> This patch adds the specification for virtio-spi.
>>
>> Signed-off-by: Haixu Cui <quic_haixcui@quicinc.com>
>> ---
>> device-types/spi/description.tex | 280 ++++++++++++++++++++++++
>> device-types/spi/device-conformance.tex | 7 +
>> device-types/spi/driver-conformance.tex | 7 +
>> 3 files changed, 294 insertions(+)
>> create mode 100644 device-types/spi/description.tex
>> create mode 100644 device-types/spi/device-conformance.tex
>> create mode 100644 device-types/spi/driver-conformance.tex
>>
>> diff --git a/device-types/spi/description.tex b/device-types/spi/description.tex
>> new file mode 100644
>> index 0000000..7c81df5
>> --- /dev/null
>> +++ b/device-types/spi/description.tex
>> @@ -0,0 +1,280 @@
>> +\section{SPI Controller Device}\label{sec:Device Types / SPI Controller Device}
>> +
>> +The Virtio SPI (Serial Peripheral Interface) device is a virtual SPI controller that
>> +allows the driver to operate and use the SPI controller under the control of the device,
>
> I feel the terminology here is still a bit confusing:
>
> "the SPI controller under the control of the device"
>
> The Virtio SPI controller is "the device" and it is not under its own control.
Exactly. I will update the statement as follows:
The Virtio SPI (Serial Peripheral Interface) device is a virtual SPI
controller that allows the driver to operate and use the SPI controller
under the control of the host, either a physical SPI controller, or an
emulated one.
>
> As I suggested earlier, maybe this should be written as:
>
> "the SPI controller under the control of the guest"
>
>> +either a physical SPI controller, or an emulated one.
>
> I just skimmed through the rest this time. Thanks for your effort.
Thank you so much for your supports and helpful comments. Really appreciate.
>
> Reviewed-by: Viresh Kumar <viresh.kumar@linaro.org>
>
Best Regards
Haixu Cui
---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
prev parent reply other threads:[~2023-12-04 2:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-01 8:21 [virtio-dev][PATCH V7 0/2] virtio-spi: add virtual SPI controller Haixu Cui
2023-12-01 8:21 ` [virtio-dev][PATCH V7 1/2] content: Rename SPI master to " Haixu Cui
2023-12-01 8:32 ` Viresh Kumar
2023-12-01 8:21 ` [virtio-dev][PATCH V7 2/2] virtio-spi: add the device specification Haixu Cui
2023-12-01 8:37 ` Viresh Kumar
2023-12-04 2:30 ` Haixu Cui [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=daee943c-1dfa-4c9a-85cf-8170ffbc1956@quicinc.com \
--to=quic_haixcui@quicinc.com \
--cc=broonie@kernel.org \
--cc=cohuck@redhat.com \
--cc=harald.mommer@opensynergy.com \
--cc=qiang4.zhang@linux.intel.com \
--cc=quic_ztu@quicinc.com \
--cc=viresh.kumar@linaro.org \
--cc=virtio-comment@lists.oasis-open.org \
--cc=virtio-dev@lists.oasis-open.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).