From: Parav Pandit <parav@nvidia.com>
To: "Michael S. Tsirkin" <mst@redhat.com>,
"Zhu, Lingshan" <lingshan.zhu@intel.com>
Cc: "virtio-dev@lists.oasis-open.org"
<virtio-dev@lists.oasis-open.org>,
"pasic@linux.ibm.com" <pasic@linux.ibm.com>,
"cohuck@redhat.com" <cohuck@redhat.com>,
"virtio-comment@lists.oasis-open.org"
<virtio-comment@lists.oasis-open.org>,
Shahaf Shuler <shahafs@nvidia.com>,
Max Gurtovoy <mgurtovoy@nvidia.com>
Subject: RE: [virtio-dev] Re: [PATCH 1/2] transport-pci: Improve config msix vector description
Date: Wed, 19 Apr 2023 19:02:18 +0000 [thread overview]
Message-ID: <PH0PR12MB548171533C1FE1A4A21FCA42DC629@PH0PR12MB5481.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20230419072522-mutt-send-email-mst@kernel.org>
> From: Michael S. Tsirkin <mst@redhat.com>
> Sent: Wednesday, April 19, 2023 7:27 AM
>
> On Wed, Apr 19, 2023 at 04:25:13PM +0800, Zhu, Lingshan wrote:
> > > > + The driver writes an MSI-X vector number here for Configuration
> change
> > > > + interrupts.
> > > Hmm I think it's "the vector", not an. And the order of words is
> > > unusual. We also don't normally use "writes here". Would
> > >
> > > Used by the driver to set the MSI-X vector number for Configuration
> change interrupts.
> > >
To keep the text consistent with rest of the fields and to address below comment about MSI-X table entry reference,
As:
The driver writes the MSI-X table entry index in this field for Configuration change notification interrupts.
Similar to,
The driver writes this to accept feature bits offered by ...
next prev parent reply other threads:[~2023-04-19 19:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-11 19:42 [virtio-dev] [PATCH 0/2] transport-pci: msix register desc improve Parav Pandit
2023-04-11 19:42 ` [virtio-dev] [PATCH 1/2] transport-pci: Improve config msix vector description Parav Pandit
2023-04-19 7:05 ` [virtio-dev] " Michael S. Tsirkin
2023-04-19 7:09 ` Michael S. Tsirkin
2023-04-19 8:25 ` Zhu, Lingshan
2023-04-19 11:27 ` Michael S. Tsirkin
2023-04-19 19:02 ` Parav Pandit [this message]
2023-04-11 19:42 ` [virtio-dev] [PATCH 2/2] transport-pci: Improve queue msix vector register desc Parav Pandit
2023-04-19 7:08 ` [virtio-dev] " Michael S. Tsirkin
2023-04-19 7:08 ` Michael S. Tsirkin
2023-04-19 1:53 ` [virtio-dev] RE: [PATCH 0/2] transport-pci: msix register desc improve Parav Pandit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH0PR12MB548171533C1FE1A4A21FCA42DC629@PH0PR12MB5481.namprd12.prod.outlook.com \
--to=parav@nvidia.com \
--cc=cohuck@redhat.com \
--cc=lingshan.zhu@intel.com \
--cc=mgurtovoy@nvidia.com \
--cc=mst@redhat.com \
--cc=pasic@linux.ibm.com \
--cc=shahafs@nvidia.com \
--cc=virtio-comment@lists.oasis-open.org \
--cc=virtio-dev@lists.oasis-open.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).