From: David Stevens <stevensd@chromium.org>
To: "Zhu, Lingshan" <lingshan.zhu@intel.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
jasowang@redhat.com, eperezma@redhat.com, cohuck@redhat.com,
stefanha@redhat.com, virtio-comment@lists.oasis-open.org,
virtio-dev@lists.oasis-open.org
Subject: [virtio-dev] Re: [PATCH] virtio: introduce SUSPEND bit in device status
Date: Mon, 26 Feb 2024 11:43:07 +0900 [thread overview]
Message-ID: <CAD=HUj40DFWr=oVZNsO=342xgv0n45SxYx8ex+QwhNq592yfVQ@mail.gmail.com> (raw)
In-Reply-To: <ac18a34e-6d8c-45a3-8c2f-65df0829a60f@intel.com>
On Mon, Feb 26, 2024 at 10:36 AM Zhu, Lingshan <lingshan.zhu@intel.com> wrote:
> On 2/25/2024 4:52 PM, Michael S. Tsirkin wrote:
> > On Fri, Feb 23, 2024 at 03:44:41PM +0800, Zhu, Lingshan wrote:
> >>
> >> On 2/20/2024 1:09 PM, David Stevens wrote:
> >>> On Tue, Feb 20, 2024 at 1:06 PM Zhu, Lingshan <lingshan.zhu@intel.com> wrote:
> >>>> On 2/19/2024 2:46 PM, David Stevens wrote:
> >>>>> On Sun, Feb 18, 2024 at 11:11 PM Michael S. Tsirkin <mst@redhat.com> wrote:
> >>>>>> On Sun, Feb 18, 2024 at 09:23:06PM +0800, Zhu Lingshan wrote:
> >>>>>>> This commit allows the driver to suspend the device by
> >>>>>>> introducing a new status bit SUSPEND in device_status.
> >>>>>>>
> >>>>>>> This commit also introduce a new feature bit VIRTIO_F_SUSPEND
> >>>>>>> which indicating whether the device support SUSPEND.
> >>>>>>>
> >>>>>>> This SUSPEND bit is transport-independent.
> >>>>>>>
> >>>>>>> Signed-off-by: Zhu Lingshan <lingshan.zhu@intel.com>
> >>>>>>> Signed-off-by: Jason Wang <jasowang@redhat.com>
> >>>>>>> Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
> >>>>>> Could we get some kind of dscription how this has taken into
> >>>>>> consideration the proposal from David Stevens?
> >>>>>>
> >>>>>> I find it really tiring when there are competing patches with authors
> >>>>>> ignoring each other's work and leaving it up to reviewers to
> >>>>>> figure out how do the patches compare.
> >>>>> This patch looks like it could be used to implement my use case.
> >>>>> However, parts of it are a bit vague and imprecise, so it's hard to
> >>>>> actually say whether my use case would actually be covered by a
> >>>>> specific implementation of this proposal.
> >>>> I am on vacation till this Friday. Shall we co-work on this and
> >>>> post something new together?
> >>> That works for me.
> >> Cool! How about two patches in a new series:
> >> 1) a general virtio suspending patch describing suspending behaviors for all
> >> virtio devices from me, an updating version of this patch
> >> 2) a PCI transport suspending patch from you, describing PCI specific
> >> behaviors.
> >>
> >> Dose this sound good to you?
> > Well David's patch was more precise than yours, and also better worded.
> > So think if there's an agreement you guys would really start with that,
> > move the functionality to the status bit and make other changes as needed.
> I think we plan to cooperate on a new series including both the status
> bit and
> PCI transport, collaborations on both of our patches.
>
> Let's see whether this looks good to David
That works for me. I can incorporate the feedback on both proposals
and send out a combined version in the next day or so.
Thanks,
David
---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
next prev parent reply other threads:[~2024-02-26 2:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-18 13:23 [virtio-dev] [PATCH] virtio: introduce SUSPEND bit in device status Zhu Lingshan
2024-02-18 14:11 ` [virtio-dev] " Michael S. Tsirkin
2024-02-19 6:46 ` David Stevens
2024-02-20 4:06 ` Zhu, Lingshan
2024-02-20 5:09 ` David Stevens
2024-02-20 7:48 ` Michael S. Tsirkin
2024-02-23 7:46 ` Zhu, Lingshan
2024-02-23 7:44 ` Zhu, Lingshan
2024-02-25 8:52 ` Michael S. Tsirkin
2024-02-26 1:36 ` Zhu, Lingshan
2024-02-26 2:43 ` David Stevens [this message]
2024-02-20 3:44 ` Zhu, Lingshan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=HUj40DFWr=oVZNsO=342xgv0n45SxYx8ex+QwhNq592yfVQ@mail.gmail.com' \
--to=stevensd@chromium.org \
--cc=cohuck@redhat.com \
--cc=eperezma@redhat.com \
--cc=jasowang@redhat.com \
--cc=lingshan.zhu@intel.com \
--cc=mst@redhat.com \
--cc=stefanha@redhat.com \
--cc=virtio-comment@lists.oasis-open.org \
--cc=virtio-dev@lists.oasis-open.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).