From: "Chen, Jiqian" <Jiqian.Chen@amd.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: "Marc-André Lureau" <marcandre.lureau@gmail.com>,
"Robert Beckett" <bob.beckett@collabora.com>,
"virtio-comment@lists.oasis-open.org"
<virtio-comment@lists.oasis-open.org>,
"virtio-dev@lists.oasis-open.org"
<virtio-dev@lists.oasis-open.org>,
"Stefano Stabellini" <sstabellini@kernel.org>,
"Roger Pau Monné" <roger.pau@citrix.com>,
"Deucher, Alexander" <Alexander.Deucher@amd.com>,
"Koenig, Christian" <Christian.Koenig@amd.com>,
"Hildebrand, Stewart" <Stewart.Hildebrand@amd.com>,
"Xenia Ragiadakou" <burzalodowa@gmail.com>,
"Huang, Honglei1" <Honglei1.Huang@amd.com>,
"Zhang, Julia" <Julia.Zhang@amd.com>,
"Huang, Ray" <Ray.Huang@amd.com>,
"Chen, Jiqian" <Jiqian.Chen@amd.com>
Subject: Re: [virtio-dev] Re: [VIRTIO GPU PATCH 1/1] virtio-gpu: Add new feature flag VIRTIO_GPU_F_FREEZING
Date: Thu, 6 Jul 2023 12:13:38 +0000 [thread overview]
Message-ID: <BL1PR12MB5849B31B8BF6444BAB6BBE91E72CA@BL1PR12MB5849.namprd12.prod.outlook.com> (raw)
In-Reply-To: <haz6sjtqvuzmyorb2v4pzgfkau3xudzkttosmpheov5slqox37@wdtafkzirhvi>
Hi Gerd Hoffmann,
Thank you for your review and suggestions.
On 2023/7/6 19:54, Gerd Hoffmann wrote:
> Hi,
>
>> +\item[VIRTIO_GPU_CMD_STATUS_FREEZING]
>> +Notify freezing status through controlq.
>> +Request data is \field{struct virtio_gpu_status_freezing}.
>> +Response type is VIRTIO_GPU_RESP_OK_NODATA.
>> +
>> +Guest notifies QEMU if virtio-gpu is in freezing status or not in \field{freezing}.
>> +zero means it is not in freezing status, none-zero is the opposite.
>> +When guest is in freezing status, QEMU will not destroy resources.
>
> This should be more clear which resources are meant here. Just
> resources created by VIRTIO_GPU_CMD_RESOURCE_CREATE_* commands?
> Or all objects (including cursors, scanouts, 3D contexts, ...)?
> Or some other set?
Yes, you are right, it should be clearer about resource here. I will elaborate on the types of resources in the next version.
>
> I've seen on the (code) patch discussion the topic of different
> suspend modes (s3/s4) came up.
> What was the conclusion there?
> Should a note about this be added to the spec too?
My modification was originally to support xen's s3 function, but I will try s4 locally, if s4 does not work, I will add instructions here.
>
> take care,
> Gerd
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
> For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
>
--
Best regards,
Jiqian Chen.
prev parent reply other threads:[~2023-07-06 12:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230630092138.855107-1-Jiqian.Chen@amd.com>
[not found] ` <20230630092138.855107-2-Jiqian.Chen@amd.com>
2023-07-06 11:54 ` [virtio-dev] Re: [VIRTIO GPU PATCH 1/1] virtio-gpu: Add new feature flag VIRTIO_GPU_F_FREEZING Gerd Hoffmann
2023-07-06 12:13 ` Chen, Jiqian [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BL1PR12MB5849B31B8BF6444BAB6BBE91E72CA@BL1PR12MB5849.namprd12.prod.outlook.com \
--to=jiqian.chen@amd.com \
--cc=Alexander.Deucher@amd.com \
--cc=Christian.Koenig@amd.com \
--cc=Honglei1.Huang@amd.com \
--cc=Julia.Zhang@amd.com \
--cc=Ray.Huang@amd.com \
--cc=Stewart.Hildebrand@amd.com \
--cc=bob.beckett@collabora.com \
--cc=burzalodowa@gmail.com \
--cc=kraxel@redhat.com \
--cc=marcandre.lureau@gmail.com \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=virtio-comment@lists.oasis-open.org \
--cc=virtio-dev@lists.oasis-open.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).