From: Haixu Cui <quic_haixcui@quicinc.com>
To: Cornelia Huck <cohuck@redhat.com>,
<virtio-dev@lists.oasis-open.org>,
<virtio-comment@lists.oasis-open.org>
Cc: <quic_ztu@quicinc.com>
Subject: [virtio-dev] Re: [PATCH] virtio-spi: add the device specification
Date: Mon, 17 Apr 2023 22:19:23 +0800 [thread overview]
Message-ID: <3c98e384-b8de-d6b8-d6c0-000ba4a69fa2@quicinc.com> (raw)
In-Reply-To: <87355qs9ym.fsf@redhat.com>
Hi Cornelia Huck,
Thank you so much for your helpful comments. I have them fixed in
another submission.
Best Regards
Haixu Cui
On 3/27/2023 7:35 PM, Cornelia Huck wrote:
> On Fri, Mar 24 2023, Haixu Cui <quic_haixcui@quicinc.com> wrote:
>
>> virtio-spi is a virtual SPI master and it allows a guset to operate and
>> use the physical SPI master controlled by the host.
>
> Please spell out what SPI is the first time you use it.
I explain SPI is the abbreviation of Serial Peripheral Interface.
>
> Also, please remember to post the separate patch that reserves the ID
> for it.
I have another patch for DEVICE ID for virtio-spi.
>
>>
>> Signed-off-by: Haixu Cui <quic_haixcui@quicinc.com>
>> ---
>> conformance.tex | 12 +-
>> content.tex | 1 +
>> device-types/spi/description.tex | 153 ++++++++++++++++++++++++
>> device-types/spi/device-conformance.tex | 7 ++
>> device-types/spi/driver-conformance.tex | 7 ++
>> 5 files changed, 176 insertions(+), 4 deletions(-)
>> create mode 100644 device-types/spi/description.tex
>> create mode 100644 device-types/spi/device-conformance.tex
>> create mode 100644 device-types/spi/driver-conformance.tex
>
> (...)
>
>> diff --git a/device-types/spi/description.tex b/device-types/spi/description.tex
>> new file mode 100644
>> index 0000000..0b69700
>> --- /dev/null
>> +++ b/device-types/spi/description.tex
>> @@ -0,0 +1,153 @@
>> +\section{SPI Master Device}\label{sec:Device Types / SPI Master Device}
>> +
>> +virtio-spi is a virtual SPI master and it allows a guest to operate and use
>> +the physical SPI master devices controlled by the host.
>
> Here as well; it's even more important that the acronym is expanded at
> least once in the spec.
>
> Also, does this mean that the device is supposed to be an interface to
> physical SPI master devices? It would be good if this could be framed
> without guest/host terminology (although this can be used as an
> example.) Maybe something like
>
> "The virtio SPI master device is a virtual SPI (Serial Peripheral
> Interface) master device, potentially interfacing to another SPI master
> device. It allows, for example, for a host to expose access to a
> physical SPI master device controlled by the host to a guest."
>
virtio-spi is similar to virtio-i2c, so I update the description
referring to the virtio-i2c specification.
>
>> +
>> +In a typical host and guest architecture with Virtio SPI, Virtio SPI driver
>> +is the front-end and exists in the guest kernel, Virtio SPI device acts as
>> +the back-end and exists in the host. And VirtQueues assist Virtio SPI driver
>> +and Virtio SPI device in perform VRing operations for communication between
>> +the front-end and the back-end.
>
> I'm not sure I can parse this properly -- does this mean that a
> virtqueue is used for communication between a front-end and a back-end?
yes, I also update the expression more clear.
> (Didn't look at the remainder of the patch yet.)
>
---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
prev parent reply other threads:[~2023-04-17 14:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-24 8:08 [virtio-dev] [PATCH] virtio-spi: add the device specification Haixu Cui
2023-03-27 11:35 ` [virtio-dev] " Cornelia Huck
2023-04-17 14:19 ` Haixu Cui [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3c98e384-b8de-d6b8-d6c0-000ba4a69fa2@quicinc.com \
--to=quic_haixcui@quicinc.com \
--cc=cohuck@redhat.com \
--cc=quic_ztu@quicinc.com \
--cc=virtio-comment@lists.oasis-open.org \
--cc=virtio-dev@lists.oasis-open.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).