From: "Michael S. Tsirkin" <mst@redhat.com>
To: Parav Pandit <parav@nvidia.com>
Cc: "virtio-dev@lists.oasis-open.org"
<virtio-dev@lists.oasis-open.org>,
"cohuck@redhat.com" <cohuck@redhat.com>,
"virtio-comment@lists.oasis-open.org"
<virtio-comment@lists.oasis-open.org>,
Shahaf Shuler <shahafs@nvidia.com>
Subject: [virtio-dev] Re: [PATCH 0/2] admin virtqueue fixes
Date: Tue, 2 May 2023 07:40:18 -0400 [thread overview]
Message-ID: <20230502073706-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <PH0PR12MB5481C415A8E662A9F3E9A3F8DC6F9@PH0PR12MB5481.namprd12.prod.outlook.com>
On Tue, May 02, 2023 at 11:34:10AM +0000, Parav Pandit wrote:
>
>
> > From: Michael S. Tsirkin <mst@redhat.com>
> > Sent: Tuesday, May 2, 2023 3:42 AM
> >
> > On Tue, May 02, 2023 at 01:44:28AM +0300, Parav Pandit wrote:
> > >
> > > Hi Michael,
> > >
> > > Please review these two small fixes for the admin virtqueue patches.
> > > They are on top of your work of v12 at [1].
> > >
> > > Patch summary:
> > > patch-1 removes PCI transport dependency on deprecated migration bit
> > > patch-2 fixes admin command command data type to be u8 similar to
> > > result
> > >
> > > [1]
> > > https://lore.kernel.org/virtio-comment/cover.1682354275.git.mst@redhat
> > > .com/T/#t
> >
> > I can take 1/2 since that's just removing text. Taking 2/2 will mean more review
> > time before vote - besides me not really liking that change, are you sure it's
> > worth it?
> > Was going to start voting today but if we are still tweaking command format
> > then I can't ...
> >
> There were 4 editorial fixes without which PDF is not readable for v12 and commit message needs update the AQ usage.
> It needs rebase also.
> And these two changes also.
>
> Given we have 6+ changes, better to make them and ask for vote after that.
>
> Vote includes spec and commit message content.
> So please roll v13 addressing above to make things easier to vote.
>
> You said posting too fast is not good. Now one week has passed, so its fine to repost v13 and ask for the vote.
Yes absolutely. I am still debating with myself whether
the change in result from u8 to le64 means I should wait another
week before vote ...
---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
prev parent reply other threads:[~2023-05-02 11:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-01 22:44 [virtio-dev] [PATCH 0/2] admin virtqueue fixes Parav Pandit
2023-05-01 22:44 ` [virtio-dev] [PATCH 1/2] admin: Remove dependency on the deprecated register Parav Pandit
2023-05-02 7:39 ` [virtio-dev] " Michael S. Tsirkin
2023-05-01 22:44 ` [virtio-dev] [PATCH 2/2] admin: Make optional command data type to u8 Parav Pandit
2023-05-02 7:37 ` [virtio-dev] " Michael S. Tsirkin
2023-05-02 11:29 ` [virtio-dev] " Parav Pandit
2023-05-02 11:36 ` [virtio-dev] " Michael S. Tsirkin
2023-05-02 7:41 ` [virtio-dev] Re: [PATCH 0/2] admin virtqueue fixes Michael S. Tsirkin
2023-05-02 11:34 ` [virtio-dev] " Parav Pandit
2023-05-02 11:40 ` Michael S. Tsirkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230502073706-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=cohuck@redhat.com \
--cc=parav@nvidia.com \
--cc=shahafs@nvidia.com \
--cc=virtio-comment@lists.oasis-open.org \
--cc=virtio-dev@lists.oasis-open.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).