From: "Michael S. Tsirkin" <mst@redhat.com>
To: Parav Pandit <parav@nvidia.com>
Cc: "virtio-dev@lists.oasis-open.org"
<virtio-dev@lists.oasis-open.org>,
"pasic@linux.ibm.com" <pasic@linux.ibm.com>,
"cohuck@redhat.com" <cohuck@redhat.com>,
"virtio-comment@lists.oasis-open.org"
<virtio-comment@lists.oasis-open.org>,
Shahaf Shuler <shahafs@nvidia.com>,
Max Gurtovoy <mgurtovoy@nvidia.com>
Subject: [virtio-dev] Re: [virtio-comment] [PATCH 1/2] transport-pci: Improve config msix vector description
Date: Fri, 21 Apr 2023 01:43:40 -0400 [thread overview]
Message-ID: <20230421014212-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <PH0PR12MB548172381252BEB73CAE6D44DC639@PH0PR12MB5481.namprd12.prod.outlook.com>
On Thu, Apr 20, 2023 at 08:51:57PM +0000, Parav Pandit wrote:
>
>
> > From: Michael S. Tsirkin <mst@redhat.com>
> > Sent: Thursday, April 20, 2023 4:45 PM
> > > \item[\field{config_msix_vector}]
> > > - The driver sets the Configuration Vector for MSI-X.
> > > + The driver writes the MSI-X table entry index in this field for
> > > + Configuration change notification interrupts.
> >
> >
> > Urm not exactly. there is also a special value of 0xffff.
> > I feel this here is just a high level description.
> It is high-level description. 0xffff is already covered elsewhere in the doc.
So make it as brief as possible then.
> > how about
> > Used by the driver to set the MSI-X vector for Configuration change
> > notification interrupts.
> >
> > pci spec also calls the entry "the vector" so I feel it's ok.
> >
>
> To keep the text consistent with rest of the fields, how about
>
> The driver writes the MSI-X table vector in this field for Configuration change notification interrupts.
> It uses a single verb instead two = "used" and "set".
>
---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
next prev parent reply other threads:[~2023-04-21 5:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-20 19:51 [virtio-dev] [PATCH 0/2] transport-pci: msix register desc improve Parav Pandit
2023-04-20 19:51 ` [virtio-dev] [PATCH 1/2] transport-pci: Improve config msix vector description Parav Pandit
2023-04-20 20:44 ` [virtio-dev] Re: [virtio-comment] " Michael S. Tsirkin
2023-04-20 20:51 ` [virtio-dev] " Parav Pandit
2023-04-21 5:37 ` [virtio-dev] " Michael S. Tsirkin
2023-04-21 5:43 ` Michael S. Tsirkin [this message]
2023-04-20 19:51 ` [virtio-dev] [PATCH 2/2] transport-pci: Improve queue msix vector register desc Parav Pandit
2023-04-20 20:45 ` [virtio-dev] " Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230421014212-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=cohuck@redhat.com \
--cc=mgurtovoy@nvidia.com \
--cc=parav@nvidia.com \
--cc=pasic@linux.ibm.com \
--cc=shahafs@nvidia.com \
--cc=virtio-comment@lists.oasis-open.org \
--cc=virtio-dev@lists.oasis-open.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).