From: "Michael S. Tsirkin" <mst@redhat.com>
To: Parav Pandit <parav@nvidia.com>
Cc: Cornelia Huck <cohuck@redhat.com>,
"virtio-dev@lists.oasis-open.org"
<virtio-dev@lists.oasis-open.org>,
"pasic@linux.ibm.com" <pasic@linux.ibm.com>,
"virtio-comment@lists.oasis-open.org"
<virtio-comment@lists.oasis-open.org>,
Shahaf Shuler <shahafs@nvidia.com>
Subject: [virtio-dev] Re: [PATCH] device-types/multiple: replace queues with enqueues
Date: Wed, 19 Apr 2023 12:15:19 -0400 [thread overview]
Message-ID: <20230419121514-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <PH0PR12MB5481908F52883B1C3BE31A15DC629@PH0PR12MB5481.namprd12.prod.outlook.com>
On Wed, Apr 19, 2023 at 01:35:32PM +0000, Parav Pandit wrote:
>
> > From: Cornelia Huck <cohuck@redhat.com>
> > Sent: Wednesday, April 19, 2023 9:33 AM
> >
> > On Tue, Apr 11 2023, Parav Pandit <parav@nvidia.com> wrote:
> >
> > > Queue is a verb and noun both. Replacing it with enqueue avoids
> > > ambiguity around plural queues noun vs verb; similar to virtio fs
> > > device description.
> >
> > Personally, I don't think this patch adds much, but I don't really mind it, either.
> >
> > >
> > > Suggested-by: Michael S. Tsirkin <mst@redhat.com>
> > > Signed-off-by: Parav Pandit <parav@nvidia.com>
> > > ---
> > > device-types/blk/description.tex | 2 +-
> > > device-types/gpio/description.tex | 4 ++--
> > > device-types/i2c/description.tex | 2 +-
> > > device-types/scsi/description.tex | 2 +-
> > > device-types/vsock/description.tex | 2 +-
> > > 5 files changed, 6 insertions(+), 6 deletions(-)
> > >
> >
> > (...)
> >
> > > diff --git a/device-types/vsock/description.tex
> > > b/device-types/vsock/description.tex
> > > index 105bb30..07909d6 100644
> > > --- a/device-types/vsock/description.tex
> > > +++ b/device-types/vsock/description.tex
> > > @@ -218,7 +218,7 @@ \subsubsection{Buffer Space
> > > Management}\label{sec:Device Types / Socket Device / \field{buf_alloc} and
> > \field{fwd_cnt} fields.
> > >
> > > \subsubsection{Receive and Transmit}\label{sec:Device Types / Socket
> > > Device / Device Operation / Receive and Transmit} -The driver queues
> > > outgoing packets on the tx virtqueue and incoming packet
> > > +The driver enqueues outgoing packets on the tx virtqueue and incoming
> > > +packet
> >
> > "queues (...) on" reads natural to me, but I'd use "to" with "enqueues"...
> Yes, I agree.
> The driver enqueues outgoing packets to the tx virtqueue reads better to me.
+1
> > can any
> > native speakers comment?
> >
> > > receive buffers on the rx virtqueue. Packets are of the following form:
> > >
> > > \begin{lstlisting}
---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
prev parent reply other threads:[~2023-04-19 16:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-11 20:03 [virtio-dev] [PATCH] device-types/multiple: replace queues with enqueues Parav Pandit
2023-04-19 1:54 ` [virtio-dev] " Parav Pandit
2023-04-19 7:17 ` [virtio-dev] " Michael S. Tsirkin
2023-04-19 13:33 ` Cornelia Huck
2023-04-19 13:35 ` [virtio-dev] " Parav Pandit
2023-04-19 16:15 ` Michael S. Tsirkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230419121514-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=cohuck@redhat.com \
--cc=parav@nvidia.com \
--cc=pasic@linux.ibm.com \
--cc=shahafs@nvidia.com \
--cc=virtio-comment@lists.oasis-open.org \
--cc=virtio-dev@lists.oasis-open.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).