From: Halil Pasic <pasic@linux.ibm.com>
To: Parav Pandit <parav@nvidia.com>
Cc: <mst@redhat.com>, <virtio-dev@lists.oasis-open.org>,
<cohuck@redhat.com>, <sgarzare@redhat.com>,
<virtio-comment@lists.oasis-open.org>, <shahafs@nvidia.com>,
Halil Pasic <pasic@linux.ibm.com>
Subject: [virtio-dev] Re: [PATCH v13 08/11] transport-ccw: Refer to the vq by its index
Date: Tue, 18 Apr 2023 18:54:57 +0200 [thread overview]
Message-ID: <20230418185457.66df510f.pasic@linux.ibm.com> (raw)
In-Reply-To: <20230411192341.751841-9-parav@nvidia.com>
On Tue, 11 Apr 2023 22:23:38 +0300
Parav Pandit <parav@nvidia.com> wrote:
> Currently specification uses virtqueue index and
> number interchangeably to refer to the virtqueue.
>
> Instead refer to it by its index.
>
> Fixes: https://github.com/oasis-tcs/virtio-spec/issues/163
> Signed-off-by: Parav Pandit <parav@nvidia.com>
Reviewed-by: Halil Pasic <pasic@linux.ibm.com>
> ---
> changelog:
> v11->v12:
> - removed changes related to index
> - replace number with index
> - added 'only' to make it more clear that
> notification has only vq index
> v9->v10:
> - replaced queue_select with vqn
> - used lower case letter for first word in comment
> v8->v9:
> - replaced 'named' with 'known'
> - replaced 'queue number' with 'vq number'
> v3->v4:
> - moved note to comment
> v2->v3:
> - added comment note for queue_select similar to max_queue_size
> v0->v1:
> - new patch
> ---
> transport-ccw.tex | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/transport-ccw.tex b/transport-ccw.tex
> index cb476c7..86272d1 100644
> --- a/transport-ccw.tex
> +++ b/transport-ccw.tex
> @@ -545,7 +545,7 @@ \subsubsection{Guest->Host Notification}\label{sec:Virtio Transport Options / Vi
> \end{tabular}
>
> When VIRTIO_F_NOTIFICATION_DATA has not been negotiated,
> -the \field{Notification data} contains the Virtqueue number.
> +the \field{Notification data} contains the virtqueue index.
>
> When VIRTIO_F_NOTIFICATION_DATA has been negotiated,
> the value has the following format:
---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
next prev parent reply other threads:[~2023-04-18 16:55 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-11 19:23 [virtio-dev] [PATCH v13 00/11] Rename queue number to queue index Parav Pandit
2023-04-11 19:23 ` [virtio-dev] [PATCH v13 01/11] content: Add vq index text Parav Pandit
2023-04-18 14:12 ` [virtio-dev] " Halil Pasic
2023-04-11 19:23 ` [virtio-dev] [PATCH v13 02/11] content.tex Replace virtqueue number with index Parav Pandit
2023-04-11 19:23 ` [virtio-dev] [PATCH v13 03/11] content: Rename confusing queue_notify_data and vqn names Parav Pandit
2023-04-17 3:41 ` Halil Pasic
2023-04-17 20:53 ` Parav Pandit
2023-04-18 6:04 ` Michael S. Tsirkin
2023-04-18 11:39 ` Halil Pasic
2023-04-18 11:43 ` Michael S. Tsirkin
2023-04-18 12:13 ` Parav Pandit
2023-04-18 12:06 ` Parav Pandit
2023-04-18 12:31 ` [virtio-dev] Re: [virtio-comment] " Cornelia Huck
2023-04-18 13:17 ` Cornelia Huck
2023-04-11 19:23 ` [virtio-dev] [PATCH v13 04/11] transport-pci: Avoid first vq index reference Parav Pandit
2023-04-11 19:23 ` [virtio-dev] [PATCH v13 05/11] transport-mmio: Rename QueueNum register Parav Pandit
2023-04-11 19:23 ` [virtio-dev] [PATCH v13 06/11] transport-mmio: Avoid referring to zero based index Parav Pandit
2023-04-11 19:23 ` [virtio-dev] [PATCH v13 07/11] transport-ccw: Rename queue depth/size to other transports Parav Pandit
2023-04-11 19:23 ` [virtio-dev] [PATCH v13 08/11] transport-ccw: Refer to the vq by its index Parav Pandit
2023-04-18 16:54 ` Halil Pasic [this message]
2023-04-11 19:23 ` [virtio-dev] [PATCH v13 09/11] virtio-net: Avoid duplicate receive queue example Parav Pandit
2023-04-11 19:23 ` [virtio-dev] [PATCH v13 10/11] virtio-net: Describe RSS using rss rq id Parav Pandit
2023-04-11 19:23 ` [virtio-dev] [PATCH v13 11/11] virtio-net: Update vqn to vq_index for cvq cmds Parav Pandit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230418185457.66df510f.pasic@linux.ibm.com \
--to=pasic@linux.ibm.com \
--cc=cohuck@redhat.com \
--cc=mst@redhat.com \
--cc=parav@nvidia.com \
--cc=sgarzare@redhat.com \
--cc=shahafs@nvidia.com \
--cc=virtio-comment@lists.oasis-open.org \
--cc=virtio-dev@lists.oasis-open.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).