virtio-dev.lists.oasis-open.org archive mirror
 help / color / mirror / Atom feed
From: Halil Pasic <pasic@linux.ibm.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Parav Pandit <parav@nvidia.com>,
	"virtio-dev@lists.oasis-open.org"
	<virtio-dev@lists.oasis-open.org>,
	"cohuck@redhat.com" <cohuck@redhat.com>,
	"sgarzare@redhat.com" <sgarzare@redhat.com>,
	"virtio-comment@lists.oasis-open.org"
	<virtio-comment@lists.oasis-open.org>,
	Shahaf Shuler <shahafs@nvidia.com>,
	Halil Pasic <pasic@linux.ibm.com>
Subject: [virtio-dev] Re: [virtio-comment] Re: [virtio-dev] [PATCH v10 0/8] Rename queue index to queue number
Date: Tue, 4 Apr 2023 18:44:25 +0200	[thread overview]
Message-ID: <20230404184425.300b9505.pasic@linux.ibm.com> (raw)
In-Reply-To: <20230404022928-mutt-send-email-mst@kernel.org>

On Tue, 4 Apr 2023 02:33:15 -0400
"Michael S. Tsirkin" <mst@redhat.com> wrote:

> On Mon, Apr 03, 2023 at 10:57:35PM -0400, Parav Pandit wrote:
> > > Both solutions are equally consistent in themselves, but I
> > > argue the latter is better because:
> > > * it is more consistent with historic usage  
> > Well index/vqn has mixed up anyway now.
> > For historic reason, I agree that index is right.
> > But it is too late now.
> > Comments have not come on time.  
> 
> Why, is there a deadline? Is this blocking some other feature? For
> something that is supposedly a cleanup we might as well get this right.
> If you guys both agree index is better, and at this point it sounds
> convincing, why not do it? It's more or less a machanical replacement.
> It's not like there's a lot of word smithing going on here except for
> 8/8 which really works with index just as well.

I agree.

Regards,
Halil

---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org


  reply	other threads:[~2023-04-04 16:44 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-29 21:23 [virtio-dev] [PATCH v10 0/8] Rename queue index to queue number Parav Pandit
2023-03-29 21:23 ` [virtio-dev] [PATCH v10 1/8] content: Add vq number text Parav Pandit
2023-03-30  7:44   ` [virtio-dev] " Cornelia Huck
2023-03-29 21:23 ` [virtio-dev] [PATCH v10 2/8] transport-pci: Refer to the vq by its number Parav Pandit
2023-03-30 17:10   ` [virtio-dev] Re: [virtio-comment] " Halil Pasic
2023-03-30 19:00     ` [virtio-dev] " Parav Pandit
2023-03-29 21:23 ` [virtio-dev] [PATCH v10 3/8] transport-mmio: Rename QueueNum register Parav Pandit
2023-03-29 21:23 ` [virtio-dev] [PATCH v10 4/8] transport-mmio: Refer to the vq by its number Parav Pandit
2023-03-29 21:23 ` [virtio-dev] [PATCH v10 5/8] transport-ccw: Rename queue depth/size to other transports Parav Pandit
2023-03-29 21:23 ` [virtio-dev] [PATCH v10 6/8] transport-ccw: Refer to the vq by its number Parav Pandit
2023-03-30  7:48   ` [virtio-dev] " Cornelia Huck
2023-03-29 21:23 ` [virtio-dev] [PATCH v10 7/8] virtio-net: Avoid duplicate receive queue example Parav Pandit
2023-03-30  7:53   ` [virtio-dev] " Cornelia Huck
2023-03-29 21:23 ` [virtio-dev] [PATCH v10 8/8] virtio-net: Describe RSS using rss rq id Parav Pandit
2023-03-30  9:17   ` [virtio-dev] " Cornelia Huck
2023-04-03 22:29     ` [virtio-dev] " Parav Pandit
2023-04-04  8:15       ` [virtio-dev] Re: [virtio-comment] " Cornelia Huck
2023-04-04 16:11         ` [virtio-dev] " Parav Pandit
2023-03-30 17:11 ` [virtio-dev] [PATCH v10 0/8] Rename queue index to queue number Halil Pasic
2023-03-30 19:13   ` Parav Pandit
2023-04-04  1:36     ` Halil Pasic
2023-04-04  2:57       ` Parav Pandit
2023-04-04  6:33         ` Michael S. Tsirkin
2023-04-04 16:44           ` Halil Pasic [this message]
2023-04-04  7:07         ` Michael S. Tsirkin
2023-04-04 15:55           ` Halil Pasic
2023-04-04 16:08             ` [virtio-dev] Re: [virtio-comment] " Cornelia Huck
2023-04-04  7:13         ` Michael S. Tsirkin
2023-03-31  8:13   ` Cornelia Huck
2023-04-04  6:34     ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230404184425.300b9505.pasic@linux.ibm.com \
    --to=pasic@linux.ibm.com \
    --cc=cohuck@redhat.com \
    --cc=mst@redhat.com \
    --cc=parav@nvidia.com \
    --cc=sgarzare@redhat.com \
    --cc=shahafs@nvidia.com \
    --cc=virtio-comment@lists.oasis-open.org \
    --cc=virtio-dev@lists.oasis-open.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).