From: Heng Qi <hengqi@linux.alibaba.com>
To: Parav Pandit <parav@nvidia.com>, Cornelia Huck <cohuck@redhat.com>
Cc: "Michael S . Tsirkin" <mst@redhat.com>,
Jason Wang <jasowang@redhat.com>,
Xuan Zhuo <xuanzhuo@linux.alibaba.com>,
Yuri Benditovich <yuri.benditovich@daynix.com>,
Satananda Burla <sburla@marvell.com>,
"virtio-comment@lists.oasis-open.org"
<virtio-comment@lists.oasis-open.org>
Subject: Re: [virtio-comment] [PATCH RESEND v3] virtio-net: support the RSS context
Date: Tue, 24 Oct 2023 11:45:45 +0800 [thread overview]
Message-ID: <fb9bbd04-c01d-4266-bda2-b91d33490a30@linux.alibaba.com> (raw)
In-Reply-To: <PH0PR12MB5481D10B5D788695BCFBBA89DCDFA@PH0PR12MB5481.namprd12.prod.outlook.com>
在 2023/10/24 上午11:41, Parav Pandit 写道:
> Hi Heng,
>
>> From: Heng Qi <hengqi@linux.alibaba.com>
>> Sent: Tuesday, October 24, 2023 9:07 AM
>>
>>
>> 在 2023/10/12 下午3:47, Heng Qi 写道:
>>> Commit 84a1d9c48200 ("net: ethtool: extend RXNFC API to support RSS
>>> spreading of filter matches") adds support for RSS context as a
>>> destination for receive flow filters (see WIP work: https://lists.oasis-
>> open.org/archives/virtio-comment/202308/msg00194.html).
>>> An RSS context consists of configurable parameters specified by receive-side
>> scaling.
>>> Some use cases:
>>> 1. When users want some data flows to be steered to specific multiple rxqs,
>> they can set
>>> receive flow filter rules for these data flows to an RSS context with desired
>> rxqs.
>>> 2. Traffic isolation. Used when users want the traffic of certain applications to
>> occupy
>>> several queues without being distubed.
>>>
>>> How to set/configure an RSS context:
>>> Assuming no RSS context has been created before.
>>> 1. ethtool -X eth0 context new start 5 equal 8
>>>
>>> This command creates an RSS context with an id=1 for eth0, and fills
>>> in the indirection table with rxq indexes 5-8 circularly. The hash key
>>> and hash types reuse the default RSS configuration.
>>>
>>> Then, we can use 'ethtool -x eth0 context 1' to query the above configuration.
>>>
>>> 2. ethtool -X eth0 context new start 6 equal 7 \
>>> hkey 8f:bf:dd:11:23:58:d2:8a:00:31:d0:32:a3:b5:1f:\
>>>
>>> 1f:e4:d1:fe:47:7f:64:42:fd:d0:61:16:b8:b0:f9:71:e8:2d:36:7f:18:dd:4d:c
>>> 8:f3
>>>
>>> This command creates an RSS context with an id=2 for eth0, and fills
>>> in the indirection table with rxq indexes 6-7 circularly. The hash key
>>> is 8f:bf:dd:11:23:58:d2:8a:00:31:d0\
>> :32:a3:b5:1f:1f:e4:d1:fe:47:7f:64:42:fd:d0:61:16:b8:b0:f9:71:e8:2d:36:7f:18:dd:4
>> d:c8:f3.
>>> Hash types reuse the default RSS configuration.
>>>
>>> 3. ethtool -N eth0 rx-flow-hash tcp4 sdfn context 1
>>>
>>> This command specifies the hash types for the RSS context whose id=1 on
>> eth0.
>>> Now this RSS context only has the hash key to reuse the default RSS
>> configuration.
>>> 4. ethtool -N eth0 flow-type udp4 src-ip 1.1.1.1 context 1
>>>
>>> This command configures a receive flow filter rule for eth0, and the
>>> data flow matching this rule will continue to select the final rxq
>>> according to the RSS context configuration with id=1.
>>>
>>> Fixes: https://github.com/oasis-tcs/virtio-spec/issues/178
>>> Signed-off-by: Heng Qi <hengqi@linux.alibaba.com>
>>> Signed-off-by: Parav Pandit <parav@nvidia.com>
>>> Acked-by: Satananda Burla <sburla@marvell.com>
>> Hi Cornelia.
>>
>> Could you please open a vote for this work? This work has been long delayed.
>>
>> Thanks!
>>
> Can you please rebase the patch on top of Xuan's patch [1]?
>
> This is because, Xuan patch uses same feature bit 50.
> Please mention in the commit log as well for the dependency.
>
> Once you rebase and use different feature bit, it is due for vote.
>
> I will also rebase the flow filters on top of your series to avoid the collision on feature bit.
Ok, I'll rebase this work on top of Xuan's voting patch.
Thanks.
>
> [1] https://lists.oasis-open.org/archives/virtio-comment/202310/msg00047.html
This publicly archived list offers a means to provide input to the
OASIS Virtual I/O Device (VIRTIO) TC.
In order to verify user consent to the Feedback License terms and
to minimize spam in the list archive, subscription is required
before posting.
Subscribe: virtio-comment-subscribe@lists.oasis-open.org
Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org
List help: virtio-comment-help@lists.oasis-open.org
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/
prev parent reply other threads:[~2023-10-24 3:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-12 7:47 [virtio-comment] [PATCH RESEND v3] virtio-net: support the RSS context Heng Qi
2023-10-24 3:36 ` Heng Qi
2023-10-24 3:41 ` Parav Pandit
2023-10-24 3:45 ` Heng Qi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb9bbd04-c01d-4266-bda2-b91d33490a30@linux.alibaba.com \
--to=hengqi@linux.alibaba.com \
--cc=cohuck@redhat.com \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=parav@nvidia.com \
--cc=sburla@marvell.com \
--cc=virtio-comment@lists.oasis-open.org \
--cc=xuanzhuo@linux.alibaba.com \
--cc=yuri.benditovich@daynix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).