From: Haixu Cui <quic_haixcui@quicinc.com>
To: Mark Brown <broonie@kernel.org>
Cc: Harald Mommer <harald.mommer@opensynergy.com>,
<virtio-dev@lists.oasis-open.org>,
<virtio-comment@lists.oasis-open.org>, <cohuck@redhat.com>,
<quic_ztu@quicinc.com>
Subject: [virtio-comment] Re: [virtio-dev] [PATCH v4] virtio-spi: add the device specification
Date: Fri, 10 Nov 2023 10:37:29 +0800 [thread overview]
Message-ID: <cda9cfc8-1897-4fcf-9b30-1ad9c81185e6@quicinc.com> (raw)
In-Reply-To: <ZUzaZt4flHQgsBzu@finisterre.sirena.org.uk>
On 11/9/2023 9:11 PM, Mark Brown wrote:
> On Thu, Nov 09, 2023 at 07:21:57PM +0800, Haixu Cui wrote:
>
>> For checking the parameters above in virtio_spi_transfer_head, I'd like
>> to add these field in config space:
>
>> 5. freq_max_speed: if non-zero, maximum clock rate support, in Hz
>> unit. if 0, no limitation.
>>
>> 6. max_word_delay_ns: if non-zero, the maximum word delay supported.
>> if 0, word delay is not supported to introduce.
>>
>> 7. max_delay_after_cs_asserted: if non-zero, the maximum cs setup
>> delay supported.if 0, cs setup delay is not supported to
>> introduce
>>
>> 8. max_delay_before_cs_deassert: if non-zero, the maximum
>> cs_delay_hold_ns delay supported.if 0, cs setup delay is
>> not supported to introduce
>>
>> 9. max_delay_after_cs_deassert: if non-zero, the maximum
>> cs_change_delay_inactive_ns delay supported.if 0, cs
>> setup delay is not supported to introduce
>
> I think this all makes sense - for the above we probably also need to
> say that if the value requested by the client can't be met exactly we
> either treat it as a minimum or maximum depending on the delays and
> choose the next value (probably a maximum for the clock and minimum for
> the rest). So for example if the client requests 21MHz and the
> controller can only select 20MHz or 25MHz then it should pick 20MHz.
Sure, I will update to make it more flexible.
Thanks a lot.
Best Regards
Haixu Cui
This publicly archived list offers a means to provide input to the
OASIS Virtual I/O Device (VIRTIO) TC.
In order to verify user consent to the Feedback License terms and
to minimize spam in the list archive, subscription is required
before posting.
Subscribe: virtio-comment-subscribe@lists.oasis-open.org
Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org
List help: virtio-comment-help@lists.oasis-open.org
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/
next prev parent reply other threads:[~2023-11-10 2:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-24 12:53 [virtio-comment] [PATCH v4] virtio-spi: add the device specification Haixu Cui
2023-10-24 13:08 ` [virtio-comment] " Haixu Cui
[not found] ` <56fbe6cc-d7a5-438f-1dd2-939f4197a970@opensynergy.com>
2023-11-07 17:10 ` Haixu Cui
[not found] ` <ZUjrDjHpFVReDSgk@finisterre.sirena.org.uk>
2023-11-08 15:42 ` [virtio-comment] Re: [virtio-dev] " Haixu Cui
[not found] ` <ZUuxfbkSboAFQIQF@finisterre.sirena.org.uk>
2023-11-08 18:37 ` Harald Mommer
2023-11-09 11:21 ` Haixu Cui
[not found] ` <ZUzaZt4flHQgsBzu@finisterre.sirena.org.uk>
2023-11-10 2:37 ` Haixu Cui [this message]
[not found] ` <ZUnpqRj4c2BbhaLI@qzhang4-desk.sh.intel.com>
2023-11-09 2:52 ` Haixu Cui
[not found] ` <ZUxUa+5510GLrKQh@qzhang4-desk.sh.intel.com>
2023-11-09 10:21 ` Haixu Cui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cda9cfc8-1897-4fcf-9b30-1ad9c81185e6@quicinc.com \
--to=quic_haixcui@quicinc.com \
--cc=broonie@kernel.org \
--cc=cohuck@redhat.com \
--cc=harald.mommer@opensynergy.com \
--cc=quic_ztu@quicinc.com \
--cc=virtio-comment@lists.oasis-open.org \
--cc=virtio-dev@lists.oasis-open.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).