From: Parav Pandit <parav@nvidia.com>
To: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
Cc: "jasowang@redhat.com" <jasowang@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
David Edmondson <david.edmondson@oracle.com>,
"virtio-comment@lists.oasis-open.org"
<virtio-comment@lists.oasis-open.org>,
"virtio-dev@lists.oasis-open.org"
<virtio-dev@lists.oasis-open.org>,
Heng Qi <hengqi@linux.alibaba.com>
Subject: [virtio-comment] RE: RE: RE: [virtio-dev] RE: RE: RE: RE: [PATCH v16] virtio-net: support device stats
Date: Tue, 5 Sep 2023 06:51:59 +0000 [thread overview]
Message-ID: <PH0PR12MB5481AD3E8B95ED755FD8FA73DCE8A@PH0PR12MB5481.namprd12.prod.outlook.com> (raw)
In-Reply-To: <1693896141.8898118-1-xuanzhuo@linux.alibaba.com>
> From: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
> Sent: Tuesday, September 5, 2023 12:12 PM
>
> On Tue, 5 Sep 2023 03:31:41 +0000, Parav Pandit <parav@nvidia.com> wrote:
> >
> >
> > > From: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
> > > Sent: Tuesday, September 5, 2023 8:26 AM
> >
> > > > Sure, it can avoid segmentation, but not at the cost of skipping mtu check.
> > > > For example, sender sends skb with gso with each segment of 9K,
> > > > and receiver
> > > has mtu of 1500, same skb without segmentation is not good.
> > > > Because gso_size should be same as 1500 to match the mtu.
> > >
> > > First, for me, I think the size of the each buffer specified by the
> > > desc is irrelated to the gso_size.
> > >
> > > And the receiver can set the gso_size to match the MTU.
> > >
> > > So the sender can send a gso packet with any segments, any gso_size.
> > > For the receiver, it receives a big packet, it copys to the driver
> > > with multple buffers, and sets the right gso_size.
> > >
> > > Is that right?
> >
> > Right.
> > By definition of GSO it is segmented.
> > Soi counters should be for the segmented.
> > And for special case of "Note", there should be separate counter to indicate
> GSO was requested_but_not_done.
>
>
> I agree. So the new version should be:
>
> +\begin{description}
> + \item [tx_gso_packets]
> + The number of the GSO packets sent by the device.
> +
> + \item [tx_gso_bytes]
> + The bytes of the GSO packets sent by the device.
> +
> + \item [tx_gso_segments]
> + The number of segments cutted from GSO packets.
> +
> + \item [tx_gso_segments_bytes]
> + The bytes of segments cutted from GSO packets.
>
> + \item [tx_gso_packets_nocut]
> + The number of the GSO packets which are not cut into segments.
> +
> + \item [tx_gso_bytes_nocut]
> + The bytes of the GSO packets which are not cut into segments.
> +
> +\end{description}
>
Looks good. A text can be bit better than "cut, no cut".
May be something like,
The number of the GSO packets transmitted without segmentation...
s/nocut/noseg/
This publicly archived list offers a means to provide input to the
OASIS Virtual I/O Device (VIRTIO) TC.
In order to verify user consent to the Feedback License terms and
to minimize spam in the list archive, subscription is required
before posting.
Subscribe: virtio-comment-subscribe@lists.oasis-open.org
Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org
List help: virtio-comment-help@lists.oasis-open.org
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/
prev parent reply other threads:[~2023-09-05 6:52 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-30 5:52 [virtio-comment] [PATCH v16] virtio-net: support device stats Xuan Zhuo
2023-09-01 13:58 ` [virtio-comment] " Parav Pandit
2023-09-01 14:45 ` [virtio-comment] " Michael S. Tsirkin
2023-09-04 7:46 ` Xuan Zhuo
2023-09-04 7:33 ` [virtio-comment] Re: " Xuan Zhuo
2023-09-04 8:00 ` [virtio-comment] " Parav Pandit
2023-09-04 8:02 ` [virtio-comment] " Xuan Zhuo
2023-09-04 8:08 ` [virtio-comment] " Parav Pandit
2023-09-04 8:52 ` [virtio-comment] " Xuan Zhuo
2023-09-04 10:26 ` [virtio-comment] " Parav Pandit
2023-09-04 11:11 ` [virtio-comment] Re: [virtio-dev] " Heng Qi
2023-09-04 12:21 ` [virtio-comment] " Parav Pandit
2023-09-04 13:28 ` [virtio-comment] " Michael S. Tsirkin
2023-09-04 13:40 ` [virtio-comment] " Parav Pandit
2023-09-05 2:55 ` [virtio-comment] " Xuan Zhuo
2023-09-05 3:31 ` [virtio-comment] " Parav Pandit
2023-09-05 6:42 ` [virtio-comment] " Xuan Zhuo
2023-09-05 6:51 ` Parav Pandit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH0PR12MB5481AD3E8B95ED755FD8FA73DCE8A@PH0PR12MB5481.namprd12.prod.outlook.com \
--to=parav@nvidia.com \
--cc=david.edmondson@oracle.com \
--cc=hengqi@linux.alibaba.com \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=virtio-comment@lists.oasis-open.org \
--cc=virtio-dev@lists.oasis-open.org \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).