From: Parav Pandit <parav@nvidia.com>
To: Peter Hilber <peter.hilber@opensynergy.com>,
"virtio-comment@lists.oasis-open.org"
<virtio-comment@lists.oasis-open.org>
Cc: Cornelia Huck <cohuck@redhat.com>
Subject: RE: [virtio-comment] [RFC PATCH v2] virtio-rtc: Add device specification.
Date: Wed, 18 Oct 2023 17:09:58 +0000 [thread overview]
Message-ID: <PH0PR12MB548184F98B9F300D17C06322DCD5A@PH0PR12MB5481.namprd12.prod.outlook.com> (raw)
In-Reply-To: <520b95c5-0295-4d36-85cd-48e5021f0579@opensynergy.com>
> From: virtio-comment@lists.oasis-open.org <virtio-comment@lists.oasis-
> open.org> On Behalf Of Peter Hilber
> Sent: Wednesday, October 18, 2023 10:30 PM
> > I will need to re-read the rtc v2, but the generic approach I had in mind is to
> take the ctrl vq opcode being common between net and rtc.
> > And follow the net's cvq command response format (don’t recall if fullfils rtc
> or not).
> > And that’s it. Rtc and net gets both same command, same response.
> > Net will have feature bit to indicate this functionality exists, for rtc it is implicit
> as its being and rtc device.
> >
>
> But that would force virtio-rtc to use the not padded request/reply headers
> which the virtio-net controlq has, implying dedicated descriptors for
> class/command and ack to still have natural alignment in command-specific-
> data and command-specific-result.
>
> struct virtio_net_ctrl {
> u8 class;
> u8 command;
> u8 command-specific-data[];
> u8 ack;
> u8 command-specific-result[];
> };
>
> To me, this looks like a net legacy issue, so it should be addressed in net by
> encapsulating the aligned RTC request/response.
>
Right. It makes sense to have rtc request as command-specific-data and rtc response as command-specific-result.
prev parent reply other threads:[~2023-10-18 17:10 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-30 9:29 [virtio-comment] [RFC PATCH v2] virtio-rtc: Add device specification Peter Hilber
2023-07-02 22:55 ` Parav Pandit
2023-07-27 10:20 ` Peter Hilber
2023-07-31 3:15 ` Parav Pandit
2023-08-04 16:08 ` Peter Hilber
2023-08-21 5:42 ` Parav Pandit
2023-09-13 9:04 ` Peter Hilber
2023-09-25 9:31 ` Parav Pandit
2023-09-29 18:38 ` Peter Hilber
2023-10-01 10:33 ` Parav Pandit
2023-10-12 10:56 ` Peter Hilber
2023-10-13 7:40 ` Parav Pandit
2023-10-13 15:30 ` Peter Hilber
2023-10-17 4:06 ` Parav Pandit
2023-10-17 16:06 ` Peter Hilber
2023-10-18 5:36 ` Parav Pandit
2023-10-18 16:14 ` Peter Hilber
2023-10-18 16:24 ` Parav Pandit
2023-10-18 17:00 ` Peter Hilber
2023-10-18 17:09 ` Parav Pandit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH0PR12MB548184F98B9F300D17C06322DCD5A@PH0PR12MB5481.namprd12.prod.outlook.com \
--to=parav@nvidia.com \
--cc=cohuck@redhat.com \
--cc=peter.hilber@opensynergy.com \
--cc=virtio-comment@lists.oasis-open.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).