From: Parav Pandit <parav@nvidia.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: "virtio-comment@lists.oasis-open.org"
<virtio-comment@lists.oasis-open.org>,
"cohuck@redhat.com" <cohuck@redhat.com>,
"david.edmondson@oracle.com" <david.edmondson@oracle.com>,
"virtio-dev@lists.oasis-open.org"
<virtio-dev@lists.oasis-open.org>,
"sburla@marvell.com" <sburla@marvell.com>,
"jasowang@redhat.com" <jasowang@redhat.com>,
Yishai Hadas <yishaih@nvidia.com>,
Maor Gottlieb <maorg@nvidia.com>,
Shahaf Shuler <shahafs@nvidia.com>
Subject: RE: [virtio-comment] RE: [PATCH v6 4/4] transport-pci: Introduce group legacy group member config region access
Date: Wed, 21 Jun 2023 20:43:35 +0000 [thread overview]
Message-ID: <PH0PR12MB5481824968904CE745CBCDE7DC5DA@PH0PR12MB5481.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20230621162636-mutt-send-email-mst@kernel.org>
> From: Michael S. Tsirkin <mst@redhat.com>
> Sent: Wednesday, June 21, 2023 4:31 PM
> To: Parav Pandit <parav@nvidia.com>
> Cc: virtio-comment@lists.oasis-open.org; cohuck@redhat.com;
> david.edmondson@oracle.com; virtio-dev@lists.oasis-open.org;
> sburla@marvell.com; jasowang@redhat.com; Yishai Hadas
> <yishaih@nvidia.com>; Maor Gottlieb <maorg@nvidia.com>; Shahaf Shuler
> <shahafs@nvidia.com>
> Subject: Re: [virtio-comment] RE: [PATCH v6 4/4] transport-pci: Introduce group
> legacy group member config region access
>
> On Wed, Jun 21, 2023 at 08:22:58PM +0000, Parav Pandit wrote:
> >
> >
> > > From: Michael S. Tsirkin <mst@redhat.com>
> > > Sent: Wednesday, June 21, 2023 4:06 PM
> >
> > [..]
> > > > > To put it in our terms, something like this:
> > > > > when a legacy driver accesses a member device of
> > > > > a group using the
> > > > > legacy interface, a modern driver can intercept
> > > > > the access and forward it to the owner device.
> > > > >
> > > > I will not mention "modern driver" as it has zero reference in
> > > > spec and don't
> > > want to bring Linux terms here.
> > > > "the driver can intercept" is enough.
>
> Maybe a (non legacy) driver can intercept? Would that be acceptable?
> Just to clarify the confusion above.
>
Non legacy driver wording is fine.
> > > when a legacy member device driver accesses a member device of
> > > a group using the
> > > legacy interface, an owner device driver can intercept
> > > the access and forward it to the owner device.
> > >
> > Above is not correct.
> >
> > We have 3 drivers in picture.
> > 1. guest driver
>
> this is legacy driver, so easy
>
> > 2. hypervisor level member device driver
>
> this is just for notifications, optionally, yes?
>
For notifications (optionally) and for configuration region access.
>
> > 3. group owner device driver
> >
> > Trying to write without introducing guest and hypervisor term,
> >
> > A group owner device driver provides the service to access member device's
> configuration region.
> > A member device driver avail this service when it wants to access the member
> device's configuration region.
>
>
> I agree, it's getting complicated.
>
> >
> > > > I will rewrite it as,
> > > >
> > > > The group owner device should not expose PCI BAR0 in the PCI
> > > > SR-IOV extended capability for the group member PCI VF devices
> > > > when it prefers to
> > > support legacy interface for legacy configuration access using this group
> owner.
> > >
> > >
> > > This seems to ignore all my comments.
> > >
> > I replied after that, probably missed in exchanges.
> >
> > How about:
> > The group owner device MUST hardwire PCI BAR0 in the PCI SR-IOV extended
> capability for the group member PCI VF devices when it supports legacy
> configuration access commands.
> >
>
> better but it's not a PCI BAR0. let's add link to sriov spec, and name it VF BAR0
> same as in that spec.
>
Yes, VF BAR0, will correct it.
This publicly archived list offers a means to provide input to the
OASIS Virtual I/O Device (VIRTIO) TC.
In order to verify user consent to the Feedback License terms and
to minimize spam in the list archive, subscription is required
before posting.
Subscribe: virtio-comment-subscribe@lists.oasis-open.org
Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org
List help: virtio-comment-help@lists.oasis-open.org
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/
next prev parent reply other threads:[~2023-06-21 20:43 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-13 17:30 [virtio-comment] [PATCH v6 0/4] admin: Introduce legacy registers access using AQ Parav Pandit
2023-06-13 17:30 ` [virtio-comment] [PATCH v6 1/4] admin: Split opcode table rows with a line Parav Pandit
2023-06-13 17:30 ` [virtio-comment] [PATCH v6 2/4] admin: Fix section numbering Parav Pandit
2023-06-13 17:30 ` [virtio-comment] [PATCH v6 3/4] admin: Add group member legacy register access commands Parav Pandit
2023-06-19 16:20 ` [virtio-comment] " Michael S. Tsirkin
2023-06-19 16:29 ` [virtio-comment] " Parav Pandit
2023-06-19 16:40 ` [virtio-comment] " Michael S. Tsirkin
2023-06-19 16:45 ` [virtio-comment] " Parav Pandit
2023-06-19 17:10 ` [virtio-comment] " Michael S. Tsirkin
2023-06-19 17:21 ` [virtio-comment] RE: [virtio-dev] " Parav Pandit
2023-06-19 17:33 ` [virtio-comment] " Michael S. Tsirkin
2023-06-19 17:38 ` [virtio-comment] " Parav Pandit
2023-06-13 17:30 ` [virtio-comment] [PATCH v6 4/4] transport-pci: Introduce group legacy group member config region access Parav Pandit
2023-06-19 16:16 ` [virtio-comment] " Michael S. Tsirkin
2023-06-19 21:07 ` [virtio-comment] " Parav Pandit
2023-06-21 20:05 ` Michael S. Tsirkin
2023-06-21 20:22 ` Parav Pandit
2023-06-21 20:31 ` Michael S. Tsirkin
2023-06-21 20:43 ` Parav Pandit [this message]
2023-06-19 16:37 ` [virtio-comment] " Michael S. Tsirkin
2023-06-19 16:39 ` [virtio-comment] " Parav Pandit
2023-06-19 17:19 ` [virtio-comment] " Michael S. Tsirkin
2023-06-19 17:26 ` [virtio-comment] " Parav Pandit
2023-06-19 17:37 ` [virtio-comment] " Michael S. Tsirkin
2023-06-19 17:45 ` [virtio-comment] " Parav Pandit
2023-06-19 17:57 ` [virtio-comment] " Michael S. Tsirkin
2023-06-19 18:07 ` [virtio-comment] " Parav Pandit
2023-06-20 14:12 ` Parav Pandit
2023-06-21 15:50 ` Parav Pandit
2023-06-21 15:56 ` [virtio-comment] " Michael S. Tsirkin
2023-06-21 16:01 ` [virtio-comment] " Parav Pandit
2023-06-21 19:43 ` Michael S. Tsirkin
2023-06-21 20:04 ` Parav Pandit
2023-06-21 20:08 ` Michael S. Tsirkin
2023-06-19 18:00 ` [virtio-comment] " Michael S. Tsirkin
2023-06-19 18:12 ` [virtio-comment] " Parav Pandit
2023-06-21 19:47 ` Michael S. Tsirkin
2023-06-19 17:04 ` [virtio-comment] " Michael S. Tsirkin
2023-06-19 17:11 ` [virtio-comment] RE: [virtio-dev] " Parav Pandit
2023-06-19 17:26 ` [virtio-comment] " Michael S. Tsirkin
2023-06-19 17:35 ` [virtio-comment] " Parav Pandit
2023-06-19 17:46 ` [virtio-comment] " Michael S. Tsirkin
2023-06-20 0:14 ` [virtio-comment] " Parav Pandit
2023-06-20 10:21 ` [virtio-comment] " Michael S. Tsirkin
2023-06-21 1:09 ` [virtio-comment] " Parav Pandit
2023-06-21 5:05 ` [virtio-comment] " Michael S. Tsirkin
2023-06-19 12:38 ` [virtio-comment] RE: [PATCH v6 0/4] admin: Introduce legacy registers access using AQ Parav Pandit
2023-06-19 15:18 ` [virtio-comment] " Michael S. Tsirkin
2023-06-19 15:58 ` [virtio-comment] " Parav Pandit
2023-06-19 16:28 ` [virtio-comment] " Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH0PR12MB5481824968904CE745CBCDE7DC5DA@PH0PR12MB5481.namprd12.prod.outlook.com \
--to=parav@nvidia.com \
--cc=cohuck@redhat.com \
--cc=david.edmondson@oracle.com \
--cc=jasowang@redhat.com \
--cc=maorg@nvidia.com \
--cc=mst@redhat.com \
--cc=sburla@marvell.com \
--cc=shahafs@nvidia.com \
--cc=virtio-comment@lists.oasis-open.org \
--cc=virtio-dev@lists.oasis-open.org \
--cc=yishaih@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).