From: Parav Pandit <parav@nvidia.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: "Chen, Jiqian" <Jiqian.Chen@amd.com>,
"Jason Wang" <jasowang@redhat.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Xuan Zhuo" <xuanzhuo@linux.alibaba.com>,
"David Airlie" <airlied@redhat.com>,
"Gurchetan Singh" <gurchetansingh@chromium.org>,
"Chia-I Wu" <olvaffe@gmail.com>,
"Marc-André Lureau" <marcandre.lureau@gmail.com>,
"Robert Beckett" <bob.beckett@collabora.com>,
"Mikhail Golubev-Ciuchea"
<Mikhail.Golubev-Ciuchea@opensynergy.com>,
"virtio-comment@lists.oasis-open.org"
<virtio-comment@lists.oasis-open.org>,
"virtio-dev@lists.oasis-open.org"
<virtio-dev@lists.oasis-open.org>,
"Stefano Stabellini" <sstabellini@kernel.org>,
"Roger Pau Monné" <roger.pau@citrix.com>,
"Deucher, Alexander" <Alexander.Deucher@amd.com>,
"Koenig, Christian" <Christian.Koenig@amd.com>,
"Hildebrand, Stewart" <Stewart.Hildebrand@amd.com>,
"Xenia Ragiadakou" <burzalodowa@gmail.com>,
"Huang, Honglei1" <Honglei1.Huang@amd.com>,
"Zhang, Julia" <Julia.Zhang@amd.com>,
"Huang, Ray" <Ray.Huang@amd.com>
Subject: [virtio-comment] RE: [virtio-dev] Re: [VIRTIO PCI PATCH v5 1/1] transport-pci: Add freeze_mode to virtio_pci_common_cfg
Date: Wed, 27 Sep 2023 10:18:37 +0000 [thread overview]
Message-ID: <PH0PR12MB54817697DBA852FF2E1F619FDCC2A@PH0PR12MB5481.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20230926075503-mutt-send-email-mst@kernel.org>
> From: Michael S. Tsirkin <mst@redhat.com>
> Sent: Tuesday, September 26, 2023 5:28 PM
[..]
> > When new feature bit of suspend is offered, guest will _not_ do reset, hence
> no need to mix reset with suspend.
> >
> > [1] https://lists.oasis-open.org/archives/virtio-comment/202309/msg00260.html
>
> I frankly don't understand what you proposed there.
>
> reset is a simple operation, it just erases all virtio state from the device. It is very
> commonly is performed at OS/driver startup. Making it not reset some virtio
> state is a bad idea since suddenly you kexec a guest that attempts a reset and
> device is stuck in some weird state.
Just exactly what you said.
Reset simply resets the device including the suspended state and any other bit being set.
Reset flow cannot be influenced by some suspend bit setting.
I said same in above [1].
next prev parent reply other threads:[~2023-09-27 10:18 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-19 11:42 [virtio-comment] [VIRTIO PCI PATCH v5 0/1] Add freeze_mode to virtio_pci_common_cfg Jiqian Chen
2023-09-19 11:42 ` [virtio-comment] [VIRTIO PCI PATCH v5 1/1] transport-pci: " Jiqian Chen
2023-09-19 12:10 ` [virtio-comment] " Parav Pandit
2023-09-19 14:09 ` [virtio-comment] " Michael S. Tsirkin
2023-09-20 3:57 ` [virtio-comment] Re: [virtio-dev] " Chen, Jiqian
2023-09-20 4:10 ` [virtio-comment] " Parav Pandit
2023-09-19 12:31 ` [virtio-comment] " Michael S. Tsirkin
2023-09-20 4:56 ` Chen, Jiqian
2023-09-20 5:59 ` Zhu, Lingshan
2023-09-20 6:33 ` [virtio-comment] Re: [virtio-dev] " Chen, Jiqian
2023-09-20 6:58 ` [virtio-comment] " Parav Pandit
2023-09-20 7:06 ` [virtio-comment] " Zhu, Lingshan
2023-09-20 7:10 ` [virtio-comment] " Parav Pandit
2023-09-20 7:27 ` [virtio-comment] " Zhu, Lingshan
2023-09-20 7:32 ` [virtio-comment] " Parav Pandit
2023-09-20 7:45 ` [virtio-comment] " Zhu, Lingshan
2023-09-20 7:47 ` [virtio-comment] " Parav Pandit
2023-09-20 7:24 ` [virtio-comment] " Chen, Jiqian
2023-09-20 7:30 ` Zhu, Lingshan
2023-09-20 7:35 ` [virtio-comment] " Parav Pandit
2023-09-20 7:47 ` [virtio-comment] " Zhu, Lingshan
2023-09-20 7:51 ` [virtio-comment] " Parav Pandit
2023-09-20 7:55 ` [virtio-comment] " Zhu, Lingshan
2023-09-20 7:53 ` Chen, Jiqian
2023-09-20 7:56 ` [virtio-comment] " Parav Pandit
2023-09-20 8:18 ` Chen, Jiqian
2023-09-20 6:58 ` [virtio-comment] " Zhu, Lingshan
2023-09-20 7:17 ` Chen, Jiqian
2023-09-20 7:42 ` Zhu, Lingshan
2023-09-21 4:22 ` Jason Wang
2023-09-21 6:28 ` [virtio-comment] Re: [virtio-dev] " Chen, Jiqian
2023-09-22 3:17 ` Jason Wang
2023-09-22 8:07 ` Chen, Jiqian
2023-09-25 2:52 ` Jason Wang
2023-09-26 2:23 ` Chen, Jiqian
2023-09-26 2:51 ` Jason Wang
2023-09-26 11:00 ` Chen, Jiqian
2023-09-26 11:09 ` Michael S. Tsirkin
2023-09-27 9:00 ` Chen, Jiqian
2023-09-26 11:37 ` [virtio-comment] " Parav Pandit
2023-09-26 11:57 ` [virtio-comment] " Michael S. Tsirkin
2023-09-27 10:18 ` Parav Pandit [this message]
2023-09-27 9:19 ` Chen, Jiqian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH0PR12MB54817697DBA852FF2E1F619FDCC2A@PH0PR12MB5481.namprd12.prod.outlook.com \
--to=parav@nvidia.com \
--cc=Alexander.Deucher@amd.com \
--cc=Christian.Koenig@amd.com \
--cc=Honglei1.Huang@amd.com \
--cc=Jiqian.Chen@amd.com \
--cc=Julia.Zhang@amd.com \
--cc=Mikhail.Golubev-Ciuchea@opensynergy.com \
--cc=Ray.Huang@amd.com \
--cc=Stewart.Hildebrand@amd.com \
--cc=airlied@redhat.com \
--cc=bob.beckett@collabora.com \
--cc=burzalodowa@gmail.com \
--cc=gurchetansingh@chromium.org \
--cc=jasowang@redhat.com \
--cc=kraxel@redhat.com \
--cc=marcandre.lureau@gmail.com \
--cc=mst@redhat.com \
--cc=olvaffe@gmail.com \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=virtio-comment@lists.oasis-open.org \
--cc=virtio-dev@lists.oasis-open.org \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).