From: Parav Pandit <parav@nvidia.com>
To: Parav Pandit <parav@nvidia.com>,
"virtio-comment@lists.oasis-open.org"
<virtio-comment@lists.oasis-open.org>,
"mst@redhat.com" <mst@redhat.com>,
"cohuck@redhat.com" <cohuck@redhat.com>
Cc: Shahaf Shuler <shahafs@nvidia.com>,
"xuanzhuo@linux.alibaba.com" <xuanzhuo@linux.alibaba.com>,
"yuri.benditovich@daynix.com" <yuri.benditovich@daynix.com>
Subject: [virtio-comment] RE: [PATCH v1 0/2] virtio-net: Clarify virtio_net_hdr size and rx buffer size
Date: Mon, 15 Jan 2024 06:47:44 +0000 [thread overview]
Message-ID: <PH0PR12MB54814D477DC0FA6CF58205B0DC6C2@PH0PR12MB5481.namprd12.prod.outlook.com> (raw)
In-Reply-To: <PH0PR12MB54811CB1F5B077F18B5E7225DC6C2@PH0PR12MB5481.namprd12.prod.outlook.com>
Hi Cornelia,
> From: virtio-comment@lists.oasis-open.org <virtio-comment@lists.oasis-
> open.org> On Behalf Of Parav Pandit
> Sent: Monday, January 15, 2024 11:30 AM
> To: virtio-comment@lists.oasis-open.org; mst@redhat.com;
> cohuck@redhat.com
> Cc: Shahaf Shuler <shahafs@nvidia.com>; xuanzhuo@linux.alibaba.com;
> yuri.benditovich@daynix.com
> Subject: [virtio-comment] RE: [PATCH v1 0/2] virtio-net: Clarify virtio_net_hdr
> size and rx buffer size
>
> Hi Cornelia,
>
> > From: Parav Pandit <parav@nvidia.com>
> > Sent: Friday, January 5, 2024 1:31 PM
> > To: virtio-comment@lists.oasis-open.org; mst@redhat.com;
> > cohuck@redhat.com
> > Cc: Shahaf Shuler <shahafs@nvidia.com>; xuanzhuo@linux.alibaba.com;
> > yuri.benditovich@daynix.com; Parav Pandit <parav@nvidia.com>
> > Subject: [PATCH v1 0/2] virtio-net: Clarify virtio_net_hdr size and rx
> > buffer size
> >
> > There are few small issues around size of receive buffer and size of
> > the struct virtio_net_hdr as following.
> >
> > 1. VIRTIO_NET_F_HASH_REPORT is only applicable on the rx side processing.
> > However it changes the size of the struct virtio_net_hdr for the tx side
> > as well. This was not clarified when VIRTIO_NET_F_HASH_REPORT
> > feature was
> > introduced.
> >
> > 2. Receive buffer size calculation description and requirements did not
> > reflect negotiation of VIRTIO_NET_F_HASH_REPORT.
> >
> > 3. Receive buffer size calculation was incorrect for ipv6 guest gso feature.
> >
> > Above issue 2 was reported in [1].
> > Since issue 2 and 3 both touches the same set of requirements and
> > description, they are updated under a new issue along with tx side fix
> > as well touching the clarification needed for VIRTIO_NET_F_HASH_REPORT.
> >
> > Hence above three issues are fixed under issue of [2].
> >
> > Patch summary:
> > patch-1 fixes receive side description and requirement
> > patch-2 adds transmit side clarification for VIRTIO_NET_F_HASH_REPORT
> >
> > changelog:
> > v0->v1:
> > - addressed comments from Xuan to rewrite tx normative
> >
>
> Can you please raise the voting request for these two small description
> changes?
I missed your response to patch_1. Fixing it in v2.
Please ignore my above request for vote.
Will ask after posting v2.
Thanks.
This publicly archived list offers a means to provide input to the
OASIS Virtual I/O Device (VIRTIO) TC.
In order to verify user consent to the Feedback License terms and
to minimize spam in the list archive, subscription is required
before posting.
Subscribe: virtio-comment-subscribe@lists.oasis-open.org
Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org
List help: virtio-comment-help@lists.oasis-open.org
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/
prev parent reply other threads:[~2024-01-15 6:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-05 8:00 [virtio-comment] [PATCH v1 0/2] virtio-net: Clarify virtio_net_hdr size and rx buffer size Parav Pandit
2024-01-05 8:00 ` [virtio-comment] [PATCH v1 1/2] virtio-net: Fix receive buffer size calculation text Parav Pandit
2024-01-12 11:24 ` [virtio-comment] " Cornelia Huck
2024-01-05 8:00 ` [virtio-comment] [PATCH v1 2/2] virtio-net: Clarify the size of the struct virtio_net_hdr for tx Parav Pandit
2024-01-15 5:59 ` [virtio-comment] RE: [PATCH v1 0/2] virtio-net: Clarify virtio_net_hdr size and rx buffer size Parav Pandit
2024-01-15 6:47 ` Parav Pandit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH0PR12MB54814D477DC0FA6CF58205B0DC6C2@PH0PR12MB5481.namprd12.prod.outlook.com \
--to=parav@nvidia.com \
--cc=cohuck@redhat.com \
--cc=mst@redhat.com \
--cc=shahafs@nvidia.com \
--cc=virtio-comment@lists.oasis-open.org \
--cc=xuanzhuo@linux.alibaba.com \
--cc=yuri.benditovich@daynix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).