From: Matias Ezequiel Vara Larsen <mvaralar@redhat.com>
To: Harald Mommer <harald.mommer@opensynergy.com>
Cc: virtio-comment@lists.oasis-open.org
Subject: Re: [virtio-comment] [PATCH] virtio-can: define out of rage can-id
Date: Thu, 29 Feb 2024 10:59:45 +0100 [thread overview]
Message-ID: <CAHYGQ0wH1E2WZepY=Vvb8o-OR-Lhz2GNYiU67+jLhpJh_yJAWw@mail.gmail.com> (raw)
In-Reply-To: <17d6675d-f084-4570-97fd-e9a4ddc7c5c5@opensynergy.com>
Hello,
On Wed, Feb 28, 2024 at 7:15 PM Harald Mommer
<harald.mommer@opensynergy.com> wrote:
>
>
> On 28.02.24 17:15, Matias Ezequiel Vara Larsen wrote:
> > This commit explains when a message is out of range.
> >
> > Signed-off-by: Matias Ezequiel Vara Larsen <mvaralar@redhat.com>
> > ---
> > * This patch applies on top of virtio-1.4, which has not been released
> > yet.
> > ---
> > device-types/can/description.tex | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/device-types/can/description.tex b/device-types/can/description.tex
> > index 2511d9c..0a5cf02 100644
> > --- a/device-types/can/description.tex
> > +++ b/device-types/can/description.tex
> > @@ -191,6 +191,9 @@ \subsubsection{Controller Mode}\label{sec:Device Types / CAN Device / Device Ope
> > invalid state with VIRTIO_CAN_RESULT_NOT_OK in \field{result} and MUST
> > NOT schedule the message for transmission.
> >
> > +Note that a message is out of range when a standard frame uses more than 11
> > +bits of can-id or when an extended frame uses more than 29 bits.
>
>
> "_" and "-" and missing \field{}: It's "\field{can_id}" in the paragraph
> above.
>
> => "can-id" => "\field{can_id}"
>
> Looked through the spec. I did at least not totally forget to mention
> the 11 bits for standard CAN and the 29 bits for extended CAN (line
> 28ff). But could have been expressed more clearly, the note makes it
> clear now.
>
Thanks! I will add those changes in v1.
Matias
This publicly archived list offers a means to provide input to the
OASIS Virtual I/O Device (VIRTIO) TC.
In order to verify user consent to the Feedback License terms and
to minimize spam in the list archive, subscription is required
before posting.
Subscribe: virtio-comment-subscribe@lists.oasis-open.org
Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org
List help: virtio-comment-help@lists.oasis-open.org
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/
prev parent reply other threads:[~2024-02-29 10:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-28 16:15 [virtio-comment] [PATCH] virtio-can: define out of rage can-id Matias Ezequiel Vara Larsen
2024-02-28 18:15 ` Harald Mommer
2024-02-29 9:59 ` Matias Ezequiel Vara Larsen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHYGQ0wH1E2WZepY=Vvb8o-OR-Lhz2GNYiU67+jLhpJh_yJAWw@mail.gmail.com' \
--to=mvaralar@redhat.com \
--cc=harald.mommer@opensynergy.com \
--cc=virtio-comment@lists.oasis-open.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).