From: Harald Mommer <harald.mommer@opensynergy.com>
To: Haixu Cui <quic_haixcui@quicinc.com>,
virtio-dev@lists.oasis-open.org,
virtio-comment@lists.oasis-open.org, cohuck@redhat.com,
broonie@kernel.org, qiang4.zhang@linux.intel.com,
viresh.kumar@linaro.org
Cc: quic_ztu@quicinc.com
Subject: [virtio-comment] Re: [virtio-dev][PATCH V9 2/2] virtio-spi: add the device specification
Date: Tue, 2 Jan 2024 15:10:14 +0100 [thread overview]
Message-ID: <47c07655-ac98-449f-b284-851f8393d980@opensynergy.com> (raw)
In-Reply-To: <0e8c5a22-ba7e-47db-9f72-f385d8f6d8bb@quicinc.com>
Hello Haixu,
>
> There are such strange usage scenarios that frame size exceeds 32
> bits, even 4096 bits. For these strange cases, It's impossible to use
> only 32 bits bits_per_word_mask to enumerate all the conditions. Seems
> that a similar situation exists in Linux spi driver also.
>
> Assume a case where the spi controller supports the frame size to be
> any value from 16 to 64, 32 bits mask can only cover the 16 ~ 32
> conditions.
>
> Even so, it's not a good idea to expand the bits_per_word_mask, 32
> bits can cover most of the cases, except for some situations that are
> not commonly used. Besides, it's hard to determine the bit width to
> cover all the cases, and expanding will make the logic more
> complicated. To summarize, I think the following statement is probably
> proper:
>
> "\field{bits_per_word_mask} is a mask indicating which values of
> bits_per_word are supported. If bit n of \field{bits_per_word_mask} is
> set, the bits_per_word with value (n+1) is supported. If
> \field{bits_per_word_mask} is 0, there is no limitation for
> bits_per_word."
>
> Do you think it is acceptable and appropriate?
Perfect.
Currently in the middle (almost done) of updating my software to draft V10.
Regards
Harald Mommer
This publicly archived list offers a means to provide input to the
OASIS Virtual I/O Device (VIRTIO) TC.
In order to verify user consent to the Feedback License terms and
to minimize spam in the list archive, subscription is required
before posting.
Subscribe: virtio-comment-subscribe@lists.oasis-open.org
Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org
List help: virtio-comment-help@lists.oasis-open.org
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/
next prev parent reply other threads:[~2024-01-02 14:10 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-12 3:33 [virtio-comment] [virtio-dev][PATCH V9 0/2] virtio-spi: add virtual SPI controller Haixu Cui
2023-12-12 3:33 ` [virtio-comment] [virtio-dev][PATCH V9 1/2] content: Rename SPI master to " Haixu Cui
2023-12-12 3:33 ` [virtio-comment] [virtio-dev][PATCH V9 2/2] virtio-spi: add the device specification Haixu Cui
2023-12-18 11:04 ` [virtio-comment] " Cornelia Huck
2023-12-21 3:57 ` Haixu Cui
2023-12-21 8:44 ` Cornelia Huck
2023-12-21 9:37 ` Haixu Cui
2023-12-21 9:54 ` Cornelia Huck
2023-12-26 3:05 ` Haixu Cui
2023-12-21 11:25 ` Harald Mommer
2023-12-22 2:28 ` Haixu Cui
2023-12-22 14:32 ` Harald Mommer
2023-12-26 4:15 ` Haixu Cui
2024-01-02 14:10 ` Harald Mommer [this message]
2023-12-22 12:21 ` Cornelia Huck
2023-12-26 3:11 ` Haixu Cui
2023-12-13 6:54 ` [virtio-comment] Re: [virtio-dev][PATCH V9 0/2] virtio-spi: add virtual SPI controller Haixu Cui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47c07655-ac98-449f-b284-851f8393d980@opensynergy.com \
--to=harald.mommer@opensynergy.com \
--cc=broonie@kernel.org \
--cc=cohuck@redhat.com \
--cc=qiang4.zhang@linux.intel.com \
--cc=quic_haixcui@quicinc.com \
--cc=quic_ztu@quicinc.com \
--cc=viresh.kumar@linaro.org \
--cc=virtio-comment@lists.oasis-open.org \
--cc=virtio-dev@lists.oasis-open.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).