From: Heng Qi <hengqi@linux.alibaba.com>
To: Jason Wang <jasowang@redhat.com>,
Yuri Benditovich <yuri.benditovich@daynix.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
Xuan Zhuo <xuanzhuo@linux.alibaba.com>,
"virtio-comment@lists.oasis-open.org"
<virtio-comment@lists.oasis-open.org>
Subject: Re: [virtio-comment] Re: [PATCH v4 1/2] virtio-net: update description for VIRTIO_NET_F_GUEST_CSUM.
Date: Mon, 11 Dec 2023 17:17:57 +0800 [thread overview]
Message-ID: <432c176e-9538-44e3-901b-85915684d804@linux.alibaba.com> (raw)
In-Reply-To: <4f612fd1-b090-4b2b-ba19-7efd4d61cc32@linux.alibaba.com>
Hi all.
Because there are already many V4 threads and valid opinions collected!
For the review experience of maintainers, v5 is refreshed[1], please review.
[1]
https://lists.oasis-open.org/archives/virtio-comment/202312/msg00069.html
Thanks!
在 2023/12/11 下午3:40, Heng Qi 写道:
>
>
> 在 2023/12/11 下午3:26, Jason Wang 写道:
>> On Mon, Dec 11, 2023 at 10:18 AM Heng Qi <hengqi@linux.alibaba.com>
>> wrote:
>>>
>>>
>>> 在 2023/12/10 下午1:39, Yuri Benditovich 写道:
>>>> If somebody explains the problem that this patch addresses it will
>>>> be very,
>>>> _very_ helpful.
>>>> We _were_ sure that if the host suggests VIRTIO_NET_F_GUEST_CSUM
>>>> and the
>>>> driver acks it - they both can do _more_ than without this feature.
>>>> Specifically the driver claims that it is able to deal with additional
>>>> types of incoming packets and such a way the device is able to provide
>>>> _more_ types of incoming packets than if this feature is not acked..
>>> Hi Yuir.
>>>
>>> Why do you think this patch will change that..?
>>> What types of packets a driver or device can handle will *not change*
>>> with this patch.
>> Well, I think the confusion came from you wanting to modify the
>> definition of VIRTIO_NET_F_GUEST_CSUM.
>
> As we discussed, modifications to the GUEST_CSUM definition will be
> removed in the next version.
>
>> As discussed, there's no issue with the current definition:
>>
>> When VIRTIO_NET_F_GUEST_CSUM is negotiated and DATA_VALID is set, the
>> checksum is still partial.
>
> I'm confused about this sentence.
>
> DATA_VALID will not appear in a packet together with a partial checksum.
>
> I think what you are saying is that partial checksum means
> CHECKSUM_UNNECESSARY.
>
> Thanks!
>
>>
>> Or did you see any?
>>
>> Thanks
>
>
> This publicly archived list offers a means to provide input to the
> OASIS Virtual I/O Device (VIRTIO) TC.
>
> In order to verify user consent to the Feedback License terms and
> to minimize spam in the list archive, subscription is required
> before posting.
>
> Subscribe: virtio-comment-subscribe@lists.oasis-open.org
> Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org
> List help: virtio-comment-help@lists.oasis-open.org
> List archive: https://lists.oasis-open.org/archives/virtio-comment/
> Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
> List Guidelines:
> https://www.oasis-open.org/policies-guidelines/mailing-lists
> Committee: https://www.oasis-open.org/committees/virtio/
> Join OASIS: https://www.oasis-open.org/join/
This publicly archived list offers a means to provide input to the
OASIS Virtual I/O Device (VIRTIO) TC.
In order to verify user consent to the Feedback License terms and
to minimize spam in the list archive, subscription is required
before posting.
Subscribe: virtio-comment-subscribe@lists.oasis-open.org
Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org
List help: virtio-comment-help@lists.oasis-open.org
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/
next prev parent reply other threads:[~2023-12-11 9:18 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-28 8:07 [virtio-comment] [PATCH v4 0/2] virtio-net: support distinguishing between partial and full checksum Heng Qi
2023-11-28 8:07 ` [virtio-comment] [PATCH v4 1/2] virtio-net: update description for VIRTIO_NET_F_GUEST_CSUM Heng Qi
2023-11-29 8:00 ` [virtio-comment] " Jason Wang
2023-11-29 8:23 ` Heng Qi
2023-12-01 5:18 ` Jason Wang
2023-12-01 6:24 ` Heng Qi
2023-12-01 6:29 ` Heng Qi
2023-12-01 7:05 ` Jason Wang
2023-12-01 7:15 ` Heng Qi
2023-12-04 7:18 ` Jason Wang
2023-12-04 7:37 ` Heng Qi
2023-12-04 8:49 ` Jason Wang
2023-12-04 8:53 ` Michael S. Tsirkin
2023-12-04 8:59 ` Jason Wang
2023-12-04 9:05 ` Michael S. Tsirkin
2023-12-04 9:34 ` Heng Qi
2023-12-05 3:52 ` Jason Wang
2023-12-05 14:18 ` Heng Qi
2023-12-05 14:45 ` Michael S. Tsirkin
2023-12-06 2:21 ` Heng Qi
2023-12-06 4:36 ` Jason Wang
2023-12-06 4:51 ` Heng Qi
2023-12-06 6:51 ` Michael S. Tsirkin
2023-12-06 7:54 ` Xuan Zhuo
2023-12-06 7:57 ` Xuan Zhuo
2023-12-06 8:46 ` Jason Wang
2023-12-06 9:03 ` Heng Qi
2023-12-07 4:52 ` Heng Qi
2023-12-07 5:34 ` Jason Wang
2023-12-10 5:39 ` Yuri Benditovich
2023-12-11 2:17 ` Heng Qi
2023-12-11 3:47 ` Heng Qi
2023-12-11 7:26 ` Jason Wang
2023-12-11 7:40 ` Heng Qi
2023-12-11 9:17 ` Heng Qi [this message]
2023-12-06 4:35 ` Jason Wang
2023-12-04 9:06 ` Heng Qi
2023-12-04 9:08 ` Jason Wang
2023-11-28 8:07 ` [virtio-comment] [PATCH v4 2/2] virtio-net: support distinguishing between partial and full checksum Heng Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=432c176e-9538-44e3-901b-85915684d804@linux.alibaba.com \
--to=hengqi@linux.alibaba.com \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=virtio-comment@lists.oasis-open.org \
--cc=xuanzhuo@linux.alibaba.com \
--cc=yuri.benditovich@daynix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).