From: Anton Yakovlev <anton.yakovlev@opensynergy.com>
To: Matias Ezequiel Vara Larsen <mvaralar@redhat.com>,
Radu Ocica <rocica@blackberry.com>
Cc: "virtio-comment@lists.oasis-open.org"
<virtio-comment@lists.oasis-open.org>
Subject: [virtio-comment] Re: [virtio-dev] virtio-snd comments/questions
Date: Wed, 29 Nov 2023 16:37:12 +0900 [thread overview]
Message-ID: <342d04d4-9496-486c-893e-9e687dd0e3fb@opensynergy.com> (raw)
In-Reply-To: <CAHYGQ0whtt3pUK+dqrCFpRP4zJTV+6kXt4S3VG-WAM+ROV5N3w@mail.gmail.com>
Hi Matias,
On 07.11.2023 00:18, Matias Ezequiel Vara Larsen wrote:
> On Fri, Nov 03, 2023 at 06:17:17PM +0000, Radu Ocica wrote:
>> I also think that the driver should not send a STOP command after a failed START command. There is no explicit description of any states in the virtio sound device specification. We have both adopted an interpretation that the state is determined by the last successful pcm control request and the transitions specified for pcm control requests assume success of these control requests. I wish this was clarified explicitly in the spec, to not allow room for interpretation.
>>
>>
> I agree. I think what is missed in the spec is to define the behavior of
> the PCM command cycle in case a command fails. I worked on a RFC to
> improve that section, feel free to comment at
> https://ddec1-0-en-ctp.trendmicro.com:443/wis/clicktime/v1/query?url=https%3a%2f%2flists.oasis%2dopen.org%2farchives%2fvirtio%2dcomment%2f202307%2fmsg00158.html&umid=76a8a4e7-2580-42db-b254-1053a2900dcf&auth=53c7c7de28b92dfd96e93d9dd61a23e634d2fbec-69dce88acbdf64019491f6342547f0e136609169.
> I think an overall solution would be to implement the PCM state machine
> in the driver thus control messages would be sent only if the stream is
> in the correct state.
Such a state machine already exists and is implemented in the ALSA subsystem
of the kernel. The spec tries to simulate exactly this one. What you could do
is to check it and fix possible issues in the spec.
Kind regards,
>
> Matias
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
> For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
>
--
Anton Yakovlev
Senior Software Engineer
OpenSynergy GmbH
Rotherstr. 20, 10245 Berlin
This publicly archived list offers a means to provide input to the
OASIS Virtual I/O Device (VIRTIO) TC.
In order to verify user consent to the Feedback License terms and
to minimize spam in the list archive, subscription is required
before posting.
Subscribe: virtio-comment-subscribe@lists.oasis-open.org
Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org
List help: virtio-comment-help@lists.oasis-open.org
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/
next prev parent reply other threads:[~2023-11-29 7:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <02725a6508584ed2aa8b31c9e9f4264a@blackberry.com>
2023-10-24 10:18 ` [virtio-comment] Re: [virtio-dev] virtio-snd comments/questions Matias Ezequiel Vara Larsen
[not found] ` <6df30c7945ca4ac2bb1c170b1c028719@blackberry.com>
2023-11-06 15:09 ` Matias Ezequiel Vara Larsen
2023-10-24 13:30 ` Matias Ezequiel Vara Larsen
[not found] ` <134bb8dbb49643e6b3d6e9b65239b6a8@blackberry.com>
2023-11-06 15:18 ` Matias Ezequiel Vara Larsen
2023-11-29 7:37 ` Anton Yakovlev [this message]
2023-11-29 7:20 ` Anton Yakovlev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=342d04d4-9496-486c-893e-9e687dd0e3fb@opensynergy.com \
--to=anton.yakovlev@opensynergy.com \
--cc=mvaralar@redhat.com \
--cc=rocica@blackberry.com \
--cc=virtio-comment@lists.oasis-open.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).