From: Heng Qi <hengqi@linux.alibaba.com>
To: "Michael S. Tsirkin" <mst@redhat.com>, Jason Wang <jasowang@redhat.com>
Cc: virtio-comment@lists.oasis-open.org,
Parav Pandit <parav@nvidia.com>,
Xuan Zhuo <xuanzhuo@linux.alibaba.com>
Subject: Re: [virtio-comment] [PATCH v2] virtio-net: support distinguishing between partial and full checksum
Date: Thu, 9 Nov 2023 16:42:34 +0800 [thread overview]
Message-ID: <33bf91ec-c9c2-4a52-9b35-53ee09a0fca0@linux.alibaba.com> (raw)
In-Reply-To: <20231109030057-mutt-send-email-mst@kernel.org>
在 2023/11/9 下午4:01, Michael S. Tsirkin 写道:
> On Thu, Nov 09, 2023 at 11:55:01AM +0800, Jason Wang wrote:
>>>> Most userspace doesn't care about the checksum though.
>>>>
>>>>> Maybe we need a flag
>>>>> to say which offloads are expensive?
>>>>>
>>>> That exposes some device details which seem not good (e.g we may want
>>>> to do migration among hardware and software).
>>>>
>>>> Thanks
>>> If you do then things will be less well tuned on one of the migration
>>> ends but then that is by design, isn't it?
>> Ok, so I'm fine to enable it by default.
>>
>> Thanks
> I was really asking a question. Is it true that full is more expensive
> than partial for the device?
It depends on the device. For performant (e.g. IO queues are hardware
accelerated)
or well-resourced devices, the overhead of full csum compared to partial
csum is almost negligible.
> So it should only be enabled if
> strictly required?
I think for software devices, yes.
Thanks.
>
>>> --
>>> MST
>>>
>
> This publicly archived list offers a means to provide input to the
> OASIS Virtual I/O Device (VIRTIO) TC.
>
> In order to verify user consent to the Feedback License terms and
> to minimize spam in the list archive, subscription is required
> before posting.
>
> Subscribe: virtio-comment-subscribe@lists.oasis-open.org
> Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org
> List help: virtio-comment-help@lists.oasis-open.org
> List archive: https://lists.oasis-open.org/archives/virtio-comment/
> Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
> List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
> Committee: https://www.oasis-open.org/committees/virtio/
> Join OASIS: https://www.oasis-open.org/join/
This publicly archived list offers a means to provide input to the
OASIS Virtual I/O Device (VIRTIO) TC.
In order to verify user consent to the Feedback License terms and
to minimize spam in the list archive, subscription is required
before posting.
Subscribe: virtio-comment-subscribe@lists.oasis-open.org
Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org
List help: virtio-comment-help@lists.oasis-open.org
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/
prev parent reply other threads:[~2023-11-09 8:42 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-19 6:17 [virtio-comment] [PATCH v2] virtio-net: support distinguishing between partial and full checksum Heng Qi
2023-10-27 2:35 ` Heng Qi
2023-10-27 7:39 ` Michael S. Tsirkin
2023-10-28 1:53 ` Xuan Zhuo
2023-10-28 2:36 ` Heng Qi
2023-11-01 4:16 ` Jason Wang
2023-11-01 4:59 ` Heng Qi
2023-11-02 5:30 ` Jason Wang
2023-11-02 6:59 ` Michael S. Tsirkin
2023-11-06 6:51 ` Heng Qi
2023-11-01 5:37 ` Michael S. Tsirkin
2023-11-01 6:46 ` Heng Qi
2023-11-02 4:40 ` Jason Wang
2023-11-02 6:50 ` Michael S. Tsirkin
2023-11-09 3:55 ` Jason Wang
2023-11-09 8:01 ` Michael S. Tsirkin
2023-11-09 8:42 ` Heng Qi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=33bf91ec-c9c2-4a52-9b35-53ee09a0fca0@linux.alibaba.com \
--to=hengqi@linux.alibaba.com \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=parav@nvidia.com \
--cc=virtio-comment@lists.oasis-open.org \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).