virtio-comment.lists.oasis-open.org archive mirror
 help / color / mirror / Atom feed
From: Jean-Philippe Brucker <jean-philippe@linaro.org>
To: virtio-comment@lists.oasis-open.org
Cc: vivek.gautam@arm.com, tina.zhang@intel.com, seb@rivosinc.com,
	sameo@rivosinc.com, eric.auger@redhat.com, kevin.tian@intel.com,
	Jean-Philippe Brucker <jean-philippe@linaro.org>
Subject: [virtio-comment] [PATCH v3 9/9] virtio-iommu: Add PASID information to fault report
Date: Mon, 22 Jan 2024 17:14:43 +0000	[thread overview]
Message-ID: <20240122171442.1740297-11-jean-philippe@linaro.org> (raw)
In-Reply-To: <20240122171442.1740297-2-jean-philippe@linaro.org>

With page table support comes PASID support, so it's useful to have the
faulting address space in error reports.

Signed-off-by: Jean-Philippe Brucker <jean-philippe@linaro.org>
---
 device-types/iommu/description.tex | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/device-types/iommu/description.tex b/device-types/iommu/description.tex
index 7c81516..7e142bd 100644
--- a/device-types/iommu/description.tex
+++ b/device-types/iommu/description.tex
@@ -1111,13 +1111,14 @@ \subsubsection{Fault reporting}\label{sec:Device Types / IOMMU Device / Device o
   u8    reserved[3];
   le32  flags;
   le32  endpoint;
-  le32  reserved1;
+  le32  pasid;
   le64  address;
 };
 
 #define VIRTIO_IOMMU_FAULT_F_READ     (1 << 0)
 #define VIRTIO_IOMMU_FAULT_F_WRITE    (1 << 1)
 #define VIRTIO_IOMMU_FAULT_F_ADDRESS  (1 << 8)
+#define VIRTIO_IOMMU_FAULT_F_PASID    (1 << 9)
 \end{lstlisting}
 
 \begin{description}
@@ -1132,9 +1133,11 @@ \subsubsection{Fault reporting}\label{sec:Device Types / IOMMU Device / Device o
         access \field{address}, which wasn't mapped in the domain or
         didn't have the correct protection flags.
     \end{description}
+  \item[\field{reserved}] Should be zero.
   \item[\field{flags}] Information about the fault context.
   \item[\field{endpoint}] The endpoint causing the fault.
-  \item[\field{reserved} and \field{reserved1}] Should be zero.
+  \item[\field{pasid}] If VIRTIO_IOMMU_FAULT_F_PASID is set, the
+    address space ID of the fault.
   \item[\field{address}] If VIRTIO_IOMMU_FAULT_F_ADDRESS is set, the
     address causing the fault.
 \end{description}
-- 
2.43.0


This publicly archived list offers a means to provide input to the
OASIS Virtual I/O Device (VIRTIO) TC.

In order to verify user consent to the Feedback License terms and
to minimize spam in the list archive, subscription is required
before posting.

Subscribe: virtio-comment-subscribe@lists.oasis-open.org
Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org
List help: virtio-comment-help@lists.oasis-open.org
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/


      parent reply	other threads:[~2024-01-22 17:21 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-22 17:14 [virtio-comment] [PATCH v3 0/9] virtio-iommu: Support page tables Jean-Philippe Brucker
2024-01-22 17:14 ` [virtio-comment] [PATCH v3 1/9] virtio-iommu: Add ATTACH_TABLE request Jean-Philippe Brucker
2024-01-22 17:14 ` [virtio-comment] [PATCH v3 2/9] virtio-iommu: Add INVALIDATE request Jean-Philippe Brucker
2024-01-22 17:14 ` [virtio-comment] [PATCH v3 3/9] virtio-iommu: Add Arm SMMUv3 support Jean-Philippe Brucker
2024-01-22 17:14 ` [virtio-comment] [PATCH v3 4/9] virtio-iommu: Add PASID field to DETACH Jean-Philippe Brucker
2024-01-22 17:14 ` [virtio-comment] [PATCH v3 5/9] virtio-iommu: Add VT-d IO page table Jean-Philippe Brucker
2024-01-22 17:14 ` [virtio-comment] [PATCH v3 6/9] virtio-iommu: Add RISC-V page tables Jean-Philippe Brucker
2024-01-22 17:14 ` [virtio-comment] [PATCH v3 7/9] virtio-iommu: Add AMD " Jean-Philippe Brucker
2024-01-22 17:14 ` [virtio-comment] [PATCH v3 8/9] virtio-iommu: Add VIRTIO_IOMMU_RESV_MEM_T_IDENTITY Jean-Philippe Brucker
2024-01-22 17:14 ` Jean-Philippe Brucker [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240122171442.1740297-11-jean-philippe@linaro.org \
    --to=jean-philippe@linaro.org \
    --cc=eric.auger@redhat.com \
    --cc=kevin.tian@intel.com \
    --cc=sameo@rivosinc.com \
    --cc=seb@rivosinc.com \
    --cc=tina.zhang@intel.com \
    --cc=virtio-comment@lists.oasis-open.org \
    --cc=vivek.gautam@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).