From: Parav Pandit <parav@nvidia.com>
To: <virtio-comment@lists.oasis-open.org>, <mst@redhat.com>,
<cohuck@redhat.com>
Cc: <shahafs@nvidia.com>, Parav Pandit <parav@nvidia.com>
Subject: [virtio-comment] [PATCH 0/2] virtio-net: Clarify virtio_net_hdr size and rx buffer size
Date: Fri, 10 Nov 2023 14:40:38 +0200 [thread overview]
Message-ID: <20231110124040.2093394-1-parav@nvidia.com> (raw)
There are few small issues around size of receive buffer and size of the
struct virtio_net_hdr as following.
1. VIRTIO_NET_F_HASH_REPORT is only applicable on the rx side processing.
However it changes the size of the struct virtio_net_hdr for the tx side
as well. This was not clarified when VIRTIO_NET_F_HASH_REPORT feature was
introduced.
2. Receive buffer size calculation description and requirements did not
reflect negotiation of VIRTIO_NET_F_HASH_REPORT.
3. Receive buffer size calculation was incorrect for ipv6 guest gso feature.
Above issue 2 was reported in [1].
Since issue 2 and 3 both touches the same set of requirements and description,
they are updated under a new issue along with tx side fix as well touching the
clarification needed for VIRTIO_NET_F_HASH_REPORT.
Hence above three issues are fixed under issue of [2].
Patch summary:
patch-1 fixes receive side description and requirement
patch-2 adds transmit side clarification for VIRTIO_NET_F_HASH_REPORT
Fixes: https://github.com/oasis-tcs/virtio-spec/issues/170
Fixes: https://github.com/oasis-tcs/virtio-spec/issues/183
Please review.
Parav Pandit (2):
virtio-net: Fix receive buffer size calculation text
virtio-net: Clarify the size of the struct virtio_net_hdr for tx
device-types/net/description.tex | 31 ++++++++++++++++++++++++-------
1 file changed, 24 insertions(+), 7 deletions(-)
--
2.34.1
This publicly archived list offers a means to provide input to the
OASIS Virtual I/O Device (VIRTIO) TC.
In order to verify user consent to the Feedback License terms and
to minimize spam in the list archive, subscription is required
before posting.
Subscribe: virtio-comment-subscribe@lists.oasis-open.org
Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org
List help: virtio-comment-help@lists.oasis-open.org
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/
next reply other threads:[~2023-11-10 12:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-10 12:40 Parav Pandit [this message]
2023-11-10 12:40 ` [virtio-comment] [PATCH 1/2] virtio-net: Fix receive buffer size calculation text Parav Pandit
2023-12-13 6:43 ` Xuan Zhuo
2023-12-13 6:54 ` Parav Pandit
2023-12-13 10:28 ` Yuri Benditovich
2023-12-14 2:27 ` Xuan Zhuo
2023-11-10 12:40 ` [virtio-comment] [PATCH 2/2] virtio-net: Clarify the size of the struct virtio_net_hdr for tx Parav Pandit
2023-12-13 6:02 ` Xuan Zhuo
2023-12-13 6:23 ` Parav Pandit
2023-12-13 6:30 ` Xuan Zhuo
2023-12-13 6:52 ` Parav Pandit
2023-12-14 2:27 ` Xuan Zhuo
2023-12-14 4:29 ` Parav Pandit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231110124040.2093394-1-parav@nvidia.com \
--to=parav@nvidia.com \
--cc=cohuck@redhat.com \
--cc=mst@redhat.com \
--cc=shahafs@nvidia.com \
--cc=virtio-comment@lists.oasis-open.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).