From: Markus Elfring <Markus.Elfring@web.de>
To: Dominique Martinet <asmadeus@codewreck.org>,
Eric Van Hensbergen <ericvh@kernel.org>,
v9fs@lists.linux.dev, kernel-janitors@vger.kernel.org
Cc: "Christian Schönebeck" <linux_oss@crudebyte.com>,
"Latchesar Ionkov" <lucho@ionkov.net>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: fs/9p: Improve exception handling in v9fs_session_init()
Date: Mon, 8 Jan 2024 13:15:43 +0100 [thread overview]
Message-ID: <f97521ef-0600-401a-8fdb-9648d576ea4c@web.de> (raw)
In-Reply-To: <ZZvX6sQLkgm0kOTN@codewreck.org>
>> The kfree() function was called in up to two cases by
>> the v9fs_session_init() function during error handling
>> even if the passed variable contained a null pointer.
>
> I don't see the problem in calling kfree on null things (especially on
> error path).
Will you become willing to reduce the number of redundant function calls
for improved exception handling?
Regards,
Markus
prev parent reply other threads:[~2024-01-08 12:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-28 20:01 [PATCH] fs/9p: Improve exception handling in v9fs_session_init() Markus Elfring
2024-01-08 11:09 ` Dominique Martinet
2024-01-08 12:15 ` Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f97521ef-0600-401a-8fdb-9648d576ea4c@web.de \
--to=markus.elfring@web.de \
--cc=asmadeus@codewreck.org \
--cc=ericvh@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux_oss@crudebyte.com \
--cc=lucho@ionkov.net \
--cc=v9fs@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).