From: Kent Overstreet <kent.overstreet@linux.dev>
To: Brian Foster <bfoster@redhat.com>
Cc: linux-bcachefs@vger.kernel.org,
Eric Van Hensbergen <eric.vanhensbergen@linux.dev>,
v9fs@lists.linux.dev
Subject: Re: [PATCH v3 0/4] bcachefs: fiemap delalloc support and cleanup
Date: Mon, 8 Apr 2024 23:33:05 -0400 [thread overview]
Message-ID: <bytl4gftjro45osrlzqeokzci2imtdidne5a7pkn3xtr6fdbhf@mxjefwpljsto> (raw)
In-Reply-To: <20240408144846.1001243-1-bfoster@redhat.com>
On Mon, Apr 08, 2024 at 10:48:42AM -0400, Brian Foster wrote:
> Hi all,
>
> Here's v3 of the fiemap delalloc support patches for bcachefs. The main
> difference from v2 is that the pagecache seek calls are now using
> nonblocking mode to avoid deadlocks between fiemap and the write path.
> The write path locks in folio -> extent btree order while fiemap walks
> the extent btree and scans for folios in transaction context. Therefore,
> the latter must restart the iterating transaction in the event of folio
> trylock failure and restart the scan from where it left off.
>
> The series is pushed to CI via my test branch, as usual:
>
> https://evilpiepirate.org/~testdashboard/ci?branch=bfoster
So our testing is currently busted because of a bug in 9pfs - I need you
to rebase onto my 9p-revert branch so we can get test results we can
look at:
https://evilpiepirate.org/git/bcachefs.git/log/?h=9p-revert
Eric, is this getting fixed? If it's not, and _soon_, we need to send
this revert to Linus - then put it through more testing, more asserts,
whatever you need and send it again next cycle, _after_ you've figured
out what wwent wrong.
Patch series looks good, though - if there's nothing you think needs
special attention I'll go ahead and merge it.
I wonder if at some point we could clean up the indirect extent lookup,
that's common between this code and the read paths, but that's low
priority.
next parent reply other threads:[~2024-04-09 3:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240408144846.1001243-1-bfoster@redhat.com>
2024-04-09 3:33 ` Kent Overstreet [this message]
2024-04-09 12:21 ` [PATCH v3 0/4] bcachefs: fiemap delalloc support and cleanup Brian Foster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bytl4gftjro45osrlzqeokzci2imtdidne5a7pkn3xtr6fdbhf@mxjefwpljsto \
--to=kent.overstreet@linux.dev \
--cc=bfoster@redhat.com \
--cc=eric.vanhensbergen@linux.dev \
--cc=linux-bcachefs@vger.kernel.org \
--cc=v9fs@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).