From: Dominique Martinet <asmadeus@codewreck.org>
To: Vitaly Chikunov <vt@altlinux.org>
Cc: Christian Schoenebeck <linux_oss@crudebyte.com>,
Fedor Pchelkin <pchelkin@ispras.ru>,
Eric Van Hensbergen <ericvh@kernel.org>,
Latchesar Ionkov <lucho@ionkov.net>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
v9fs@lists.linux.dev, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
Alexey Khoroshilov <khoroshilov@ispras.ru>,
lvc-project@linuxtesting.org
Subject: Re: [PATCH v4] net: 9p: avoid freeing uninit memory in p9pdu_vreadf
Date: Sun, 7 Jan 2024 19:26:24 +0900 [thread overview]
Message-ID: <ZZp8UPkH-TJIUngl@codewreck.org> (raw)
In-Reply-To: <2et72smsvglzicqsyvt5m7bx2akyqzi2moq7tjupppygbsme3u@o2sltttok5wy>
Vitaly Chikunov wrote on Sun, Jan 07, 2024 at 10:56:23AM +0300:
> On Tue, Dec 12, 2023 at 08:21:30AM +0900, Dominique Martinet wrote:
> > Christian Schoenebeck wrote on Thu, Dec 07, 2023 at 01:54:02PM +0100:
> > > I just checked whether this could create a leak, but it looks clean, so LGTM:
> >
> > Right, either version look good to me.
>
> Also, there was unnoticed bug in v2[1] - `int i` is moved to outer block
> and `i` counld be used uninitialized inside of `if (errcode) {`.
Thanks for pointing it out; I'm not sure if it's the same thing
Christian noticed but I believe what I had applied with his suggestion
of initializing i worked either way... But this is moot since I updated
to v4 afterwards:
this v4 has been merged in 6.7-rc7 as follow:
https://git.kernel.org/linus/ff49bf1867578f23a5ffdd38f927f6e1e16796c4
(the message-id also points to the v4 correctly, e.g.
https://lkml.kernel.org/r/20231206200913.16135-1-pchelkin@ispras.ru )
Thanks,
--
Dominique Martinet | Asmadeus
next prev parent reply other threads:[~2024-01-07 10:26 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-05 8:05 [PATCH] net: 9p: avoid freeing uninit memory in p9pdu_vreadf Fedor Pchelkin
2023-12-05 9:07 ` Dominique Martinet
2023-12-05 9:19 ` [PATCH v2] " Fedor Pchelkin
2023-12-05 9:31 ` Dominique Martinet
2023-12-05 12:15 ` Fedor Pchelkin
2023-12-05 12:43 ` Dominique Martinet
2023-12-05 12:29 ` Christian Schoenebeck
2023-12-05 13:09 ` Fedor Pchelkin
2023-12-05 18:05 ` [PATCH v3] " Fedor Pchelkin
2023-12-06 13:12 ` Christian Schoenebeck
2023-12-06 20:09 ` [PATCH v4] " Fedor Pchelkin
2023-12-07 12:54 ` Christian Schoenebeck
2023-12-11 23:21 ` Dominique Martinet
2024-01-07 7:56 ` Vitaly Chikunov
2024-01-07 9:48 ` Fedor Pchelkin
2024-01-07 10:14 ` Vitaly Chikunov
2024-01-07 10:26 ` Dominique Martinet [this message]
2023-12-11 13:51 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZZp8UPkH-TJIUngl@codewreck.org \
--to=asmadeus@codewreck.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=ericvh@kernel.org \
--cc=khoroshilov@ispras.ru \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux_oss@crudebyte.com \
--cc=lucho@ionkov.net \
--cc=lvc-project@linuxtesting.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pchelkin@ispras.ru \
--cc=v9fs@lists.linux.dev \
--cc=vt@altlinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).