From: Eric Van Hensbergen <ericvh@kernel.org>
To: Latchesar Ionkov <lucho@ionkov.net>,
Dominique Martinet <asmadeus@codewreck.org>,
Christian Schoenebeck <linux_oss@crudebyte.com>
Cc: v9fs@lists.linux.dev, linux-kernel@vger.kernel.org,
kernel@pengutronix.de,
Robert Schwebel <r.schwebel@pengutronix.de>,
Eric Van Hensbergen <ericvh@kernel.org>
Subject: [PATCH 0/3] fs/9p: fix mmap regression
Date: Mon, 17 Jul 2023 16:28:59 +0000 [thread overview]
Message-ID: <20230716-fixes-overly-restrictive-mmap-v1-0-0683b283b932@kernel.org> (raw)
This series attempts to fix a reported exception with mmap
on newer kernels.
-- original regression report --
TL;DR: mmap() seems to be broken on 9pfs on Linux 6.4. setting
"rootflags=ignoreqv" fixes it as well, but it feels like a regression.
I'm tracking down an issue which recently turned up in DistroKit [1] (an
embedded Linux distro based on the ptxdist build system). The issue was a bit
uggly, as my CI didn't find it (systems boot up normally after a while, and I
only use 9p for virtual qemu machines, while most of the test farm is real
hardware).
The qemu machine in question is qemu-system-arm, emulating an ARM v7a machine.
When starting the systems interactively, I get a lot of error output from
ldconfig, like this:
[ 17.412964] systemd-rc-once[127]: ldconfig: Cannot mmap file /lib/libgcc_s.so.1.
[ 17.418851] systemd-rc-once[127]: ldconfig: Cannot mmap file /lib/libstdc++.so.
[ 17.425009] systemd-rc-once[127]: ldconfig: Cannot mmap file /lib/libstdc++.so.6.0.30.
[ 17.436671] systemd-rc-once[127]: ldconfig: Cannot mmap file /lib/libstdc++.so.6.
[ 17.448451] systemd-rc-once[127]: ldconfig: Cannot mmap file /lib/libatomic.so.
[ 17.456418] systemd-rc-once[127]: ldconfig: Cannot mmap file /lib/libatomic.so.1.2.0.
...
Running ldconfig with strace shows this, for all libraries::
| statx(AT_FDCWD, "/lib/libnm.so.0", AT_STATX_SYNC_AS_STAT|AT_SYMLINK_NOFOLLOW|AT_NO_AUTOMOUNT, STATX_BASIC_STATS, {stx_mask=STATX_BASIC_STATS|STATX_MNT_ID, stx_attributes=0, stx_mode=S_IFLNK|0777, stx_size=14, ...}) = 0
| statx(AT_FDCWD, "/lib/libnm.so.0", AT_STATX_SYNC_AS_STAT|AT_NO_AUTOMOUNT, STATX_BASIC_STATS, {stx_mask=STATX_BASIC_STATS|STATX_MNT_ID, stx_attributes=0, stx_mode=S_IFREG|064 4, stx_size=862228, ...}) = 0
| openat(AT_FDCWD, "/lib/libnm.so.0", O_RDONLY|O_LARGEFILE) = 4
| statx(4, "", AT_STATX_SYNC_AS_STAT|AT_NO_AUTOMOUNT|AT_EMPTY_PATH, STATX_BASIC_STATS, {stx_mask=STATX_BASIC_STATS|STATX_MNT_ID, stx_attributes=0, stx_mode=S_IFREG|0644, stx_s ize=862228, ...}) = 0
| mmap2(NULL, 862228, PROT_READ, MAP_SHARED, 4, 0) = -1 ENODEV (No such device)
| write(2, "ldconfig: ", 10ldconfig: ) = 10
| write(2, "Cannot mmap file /lib/libnm.so.0"..., 34Cannot mmap file /lib/libnm.so.0.) = 34
| write(2, "\n", 1) = 1
| close(4) = 0
I could track down the breakage to
1543b4c5071c54d76aad7a7a26a6e43082269b0c
My test setup has, in addition to the patch above, the following patches also
reverted on top of a vanilla 6.4 kernel:
4eb3117888a923f6b9b1ad2dd093641c49a63ae5
21e26d5e54ab7cfe6b488fd27d4d70956d07e03b
as 1543b cannot be reverted without those; however, the effect only goes away
when I also revert 1543b. The kernel has no other patches applied, only these
three reverts.
-- end bug report --
Reported-by: Robert Schwebel <r.schwebel@pengutronix.de>
Signed-off-by: Eric Van Hensbergen <ericvh@kernel.org>
---
Eric Van Hensbergen (3):
fs/9p: remove unecessary and overrestrictive check
fs/9p: fix typo in comparison logic for cache mode
fs/9p: fix type mismatch in file cache mode helper
fs/9p/fid.h | 6 +++---
fs/9p/vfs_file.c | 2 --
2 files changed, 3 insertions(+), 5 deletions(-)
---
base-commit: 95f41d87810083d8b3dedcce46a4e356cf4a9673
change-id: 20230716-fixes-overly-restrictive-mmap-30a23501e787
Best regards,
--
Eric Van Hensbergen <ericvh@kernel.org>
next reply other threads:[~2023-07-17 16:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-17 16:28 Eric Van Hensbergen [this message]
2023-07-17 16:29 ` [PATCH 1/3] fs/9p: remove unecessary and overrestrictive check Eric Van Hensbergen
2023-07-18 2:45 ` Dominique Martinet
2023-07-18 9:17 ` Christian Schoenebeck
2023-07-17 16:29 ` [PATCH 2/3] fs/9p: fix typo in comparison logic for cache mode Eric Van Hensbergen
2023-07-18 2:48 ` Dominique Martinet
2023-07-18 9:34 ` Christian Schoenebeck
2023-07-17 16:29 ` [PATCH 3/3] fs/9p: fix type mismatch in file cache mode helper Eric Van Hensbergen
2023-07-18 2:50 ` Dominique Martinet
2023-07-18 9:40 ` Christian Schoenebeck
2023-07-19 14:17 ` [PATCH 0/3] fs/9p: fix mmap regression Thorsten Leemhuis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230716-fixes-overly-restrictive-mmap-v1-0-0683b283b932@kernel.org \
--to=ericvh@kernel.org \
--cc=asmadeus@codewreck.org \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux_oss@crudebyte.com \
--cc=lucho@ionkov.net \
--cc=r.schwebel@pengutronix.de \
--cc=v9fs@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).